AGESA buildsystem: Reduce include path exposure
Remove AGESA_AUTOINCLUDES -list from coreboot proper CPPFLAGS. Couple individual directories are now manually added to complete builds. Change-Id: I2595b87641c70e34e49fedf11b42f4961b0842dd Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/21479 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
parent
d136b8ef21
commit
1210026bda
|
@ -1,3 +1,7 @@
|
||||||
|
|
||||||
|
CPPFLAGS_x86_32 += -I$(src)/southbridge/amd/agesa/hudson
|
||||||
|
CPPFLAGS_x86_64 += -I$(src)/southbridge/amd/agesa/hudson
|
||||||
|
|
||||||
romstage-y += smbus.c smbus_spd.c
|
romstage-y += smbus.c smbus_spd.c
|
||||||
ramstage-y += hudson.c
|
ramstage-y += hudson.c
|
||||||
ramstage-y += usb.c
|
ramstage-y += usb.c
|
||||||
|
|
|
@ -11,6 +11,7 @@ subdirs-y += common
|
||||||
classes-y += libagesa
|
classes-y += libagesa
|
||||||
libagesa-y =
|
libagesa-y =
|
||||||
libagesa-generic-ccopts += -D__LIBAGESA__
|
libagesa-generic-ccopts += -D__LIBAGESA__
|
||||||
|
libagesa-generic-ccopts += $(AGESA_INC) $(AGESA_AUTOINCLUDES)
|
||||||
|
|
||||||
ifeq ($(CONFIG_ARCH_ROMSTAGE_X86_32),y)
|
ifeq ($(CONFIG_ARCH_ROMSTAGE_X86_32),y)
|
||||||
$(eval $(call create_class_compiler,libagesa,x86_32))
|
$(eval $(call create_class_compiler,libagesa,x86_32))
|
||||||
|
@ -18,7 +19,11 @@ else
|
||||||
$(eval $(call create_class_compiler,libagesa,x86_64))
|
$(eval $(call create_class_compiler,libagesa,x86_64))
|
||||||
endif
|
endif
|
||||||
|
|
||||||
|
# buildOpts should be in libagesa
|
||||||
$(obj)/romstage/mainboard/$(MAINBOARDDIR)/buildOpts.o: CPPFLAGS_x86_32 += $(BUILDOPTS_INCLUDES)
|
$(obj)/romstage/mainboard/$(MAINBOARDDIR)/buildOpts.o: CPPFLAGS_x86_32 += $(BUILDOPTS_INCLUDES)
|
||||||
$(obj)/ramstage/mainboard/$(MAINBOARDDIR)/buildOpts.o: CPPFLAGS_x86_32 += $(BUILDOPTS_INCLUDES)
|
$(obj)/ramstage/mainboard/$(MAINBOARDDIR)/buildOpts.o: CPPFLAGS_x86_32 += $(BUILDOPTS_INCLUDES)
|
||||||
|
|
||||||
|
$(obj)/romstage/vendorcode/amd/agesa/common/agesa-entry.o: CPPFLAGS_x86_32 += $(BUILDOPTS_INCLUDES)
|
||||||
|
$(obj)/ramstage/vendorcode/amd/agesa/common/agesa-entry.o: CPPFLAGS_x86_32 += $(BUILDOPTS_INCLUDES)
|
||||||
|
|
||||||
endif
|
endif
|
||||||
|
|
|
@ -32,20 +32,23 @@ AGESA_ROOT = src/vendorcode/amd/agesa/f12
|
||||||
|
|
||||||
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
||||||
|
|
||||||
AGESA_INC = -I$(src)/vendorcode/amd/include -I$(src)/mainboard/$(MAINBOARDDIR)
|
AGESA_INC = -I$(src)/vendorcode/amd/include
|
||||||
AGESA_INC += -I$(AGESA_ROOT)
|
AGESA_INC += -I$(AGESA_ROOT)
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/../common
|
AGESA_INC += -I$(AGESA_ROOT)/../common
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/Include
|
AGESA_INC += -I$(AGESA_ROOT)/Include
|
||||||
AGESA_INC += $(AGESA_AUTOINCLUDES)
|
|
||||||
|
|
||||||
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC)
|
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC) $(AGESA_AUTOINCLUDES)
|
||||||
|
|
||||||
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
|
|
||||||
export AGESA_INC := $(AGESA_INC)
|
# These are invalid, coreboot proper should not require
|
||||||
CPPFLAGS_x86_32 += $(AGESA_INC)
|
# use of AGESA internal header files.
|
||||||
CPPFLAGS_x86_64 += $(AGESA_INC)
|
CPPFLAGS_x86_ANY =
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU # heapManager.h
|
||||||
|
|
||||||
|
CPPFLAGS_x86_32 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
CPPFLAGS_x86_64 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
|
||||||
#######################################################################
|
#######################################################################
|
||||||
|
|
||||||
|
|
|
@ -32,20 +32,25 @@ AGESA_ROOT = src/vendorcode/amd/agesa/f14
|
||||||
|
|
||||||
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
||||||
|
|
||||||
AGESA_INC = -I$(src)/vendorcode/amd/include -I$(src)/mainboard/$(MAINBOARDDIR)
|
AGESA_INC = -I$(src)/vendorcode/amd/include
|
||||||
AGESA_INC += -I$(AGESA_ROOT)
|
AGESA_INC += -I$(AGESA_ROOT)
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/../common
|
AGESA_INC += -I$(AGESA_ROOT)/../common
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/Include
|
AGESA_INC += -I$(AGESA_ROOT)/Include
|
||||||
AGESA_INC += $(AGESA_AUTOINCLUDES)
|
|
||||||
|
|
||||||
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC)
|
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC) $(AGESA_AUTOINCLUDES)
|
||||||
|
|
||||||
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
|
|
||||||
export AGESA_INC := $(AGESA_INC)
|
# These are invalid, coreboot proper should not require
|
||||||
CPPFLAGS_x86_32 += $(AGESA_INC)
|
# use of AGESA internal header files.
|
||||||
CPPFLAGS_x86_64 += $(AGESA_INC)
|
CPPFLAGS_x86_ANY =
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU # heapManager.h
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU/Family
|
||||||
|
|
||||||
|
CPPFLAGS_x86_32 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
CPPFLAGS_x86_64 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
|
||||||
#######################################################################
|
#######################################################################
|
||||||
|
|
||||||
subdirs-y += Legacy/Proc
|
subdirs-y += Legacy/Proc
|
||||||
|
|
|
@ -21,21 +21,26 @@ AGESA_ROOT = src/vendorcode/amd/agesa/f15
|
||||||
|
|
||||||
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
||||||
|
|
||||||
AGESA_INC = -I$(src)/vendorcode/amd/include -I$(src)/mainboard/$(MAINBOARDDIR)
|
AGESA_INC = -I$(src)/vendorcode/amd/include
|
||||||
AGESA_INC += -I$(AGESA_ROOT)
|
AGESA_INC += -I$(AGESA_ROOT)
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/../common
|
AGESA_INC += -I$(AGESA_ROOT)/../common
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/Include
|
AGESA_INC += -I$(AGESA_ROOT)/Include
|
||||||
AGESA_INC += $(AGESA_AUTOINCLUDES)
|
|
||||||
|
|
||||||
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC)
|
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC) $(AGESA_AUTOINCLUDES)
|
||||||
|
|
||||||
## AGESA need sse feature ##
|
## AGESA need sse feature ##
|
||||||
CFLAGS_x86_32 += -msse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_32 += -msse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
CFLAGS_x86_64 += -msse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_64 += -msse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
|
|
||||||
export AGESA_INC := $(AGESA_INC)
|
# These are invalid, coreboot proper should not require
|
||||||
CPPFLAGS_x86_32 += $(AGESA_INC)
|
# use of AGESA internal header files.
|
||||||
CPPFLAGS_x86_64 += $(AGESA_INC)
|
CPPFLAGS_x86_ANY =
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU # heapManager.h
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU/Family
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Common # CreateStruct.h
|
||||||
|
|
||||||
|
CPPFLAGS_x86_32 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
CPPFLAGS_x86_64 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
|
||||||
#######################################################################
|
#######################################################################
|
||||||
|
|
||||||
|
|
|
@ -32,22 +32,30 @@ AGESA_ROOT = src/vendorcode/amd/agesa/f15tn
|
||||||
|
|
||||||
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
||||||
|
|
||||||
AGESA_INC = -I$(src)/vendorcode/amd/include -I$(src)/mainboard/$(MAINBOARDDIR)
|
AGESA_INC = -I$(src)/vendorcode/amd/include
|
||||||
AGESA_INC += -I$(AGESA_ROOT)
|
AGESA_INC += -I$(AGESA_ROOT)
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/../common
|
AGESA_INC += -I$(AGESA_ROOT)/../common
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/Include
|
AGESA_INC += -I$(AGESA_ROOT)/Include
|
||||||
AGESA_INC += $(AGESA_AUTOINCLUDES)
|
|
||||||
|
|
||||||
AGESA_INC += -I$(src)/southbridge/amd/agesa/hudson
|
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC) $(AGESA_AUTOINCLUDES)
|
||||||
|
|
||||||
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC)
|
|
||||||
|
|
||||||
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
|
|
||||||
export AGESA_INC := $(AGESA_INC)
|
# These are invalid, coreboot proper should not require
|
||||||
CPPFLAGS_x86_32 += $(AGESA_INC)
|
# use of AGESA internal header files.
|
||||||
CPPFLAGS_x86_64 += $(AGESA_INC)
|
CPPFLAGS_x86_ANY =
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU # heapManager.h
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU/Family
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/IDS # OptionsIds.h
|
||||||
|
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Fch # FchPlatform.h
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Fch/Common # FchCommonCfg.h
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Common # AmdFch.h
|
||||||
|
|
||||||
|
CPPFLAGS_x86_32 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
CPPFLAGS_x86_64 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
|
||||||
#######################################################################
|
#######################################################################
|
||||||
|
|
||||||
subdirs-y += Legacy/Proc
|
subdirs-y += Legacy/Proc
|
||||||
|
|
|
@ -32,23 +32,29 @@ AGESA_ROOT = src/vendorcode/amd/agesa/f16kb
|
||||||
|
|
||||||
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
AGESA_AUTOINCLUDES := $(shell find $(AGESA_ROOT)/Proc -type d -exec echo -n "-I"{}" " \;)
|
||||||
|
|
||||||
AGESA_INC = -I$(src)/vendorcode/amd/include -I$(src)/mainboard/$(MAINBOARDDIR)
|
AGESA_INC = -I$(src)/vendorcode/amd/include
|
||||||
AGESA_INC += -I$(AGESA_ROOT)
|
AGESA_INC += -I$(AGESA_ROOT)
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/../common
|
AGESA_INC += -I$(AGESA_ROOT)/../common
|
||||||
AGESA_INC += -I$(AGESA_ROOT)/Include
|
AGESA_INC += -I$(AGESA_ROOT)/Include
|
||||||
AGESA_INC += $(AGESA_AUTOINCLUDES)
|
|
||||||
|
|
||||||
AGESA_INC += -I$(src)/southbridge/amd/agesa/hudson
|
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC) $(AGESA_AUTOINCLUDES)
|
||||||
|
|
||||||
BUILDOPTS_INCLUDES = -I$(AGESA_ROOT)/Config $(AGESA_INC)
|
|
||||||
|
|
||||||
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_32 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
CFLAGS_x86_64 += -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
|
||||||
|
|
||||||
|
# These are invalid, coreboot proper should not require
|
||||||
|
# use of AGESA internal header files.
|
||||||
|
CPPFLAGS_x86_ANY =
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU # heapManager.h
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/CPU/Family
|
||||||
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/IDS # OptionsIds.h
|
||||||
|
|
||||||
export AGESA_INC := $(AGESA_INC)
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Fch # FchPlatform.h
|
||||||
CPPFLAGS_x86_32 += $(AGESA_INC)
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Fch/Common # FchCommonCfg.h
|
||||||
CPPFLAGS_x86_64 += $(AGESA_INC)
|
CPPFLAGS_x86_ANY += -I$(AGESA_ROOT)/Proc/Common # AmdFch.h
|
||||||
|
|
||||||
|
CPPFLAGS_x86_32 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
CPPFLAGS_x86_64 += $(AGESA_INC) $(CPPFLAGS_x86_ANY)
|
||||||
|
|
||||||
#######################################################################
|
#######################################################################
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue