GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/pineview/raminit: Refactor timings selection 

This does not use loops to compute timings but uses DIV_ROUND_UP.

Another thing affected by this patch are minimum timings. Presumably
those only need to be guarded against on DDR3. With this change
timings are set up like vendor (with tWTR below previous minimum)

TESTED on Intel D510MO

Change-Id: Ia374f26e5bbb8b90d90c24ae6c20412ba53bd7b6
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19495
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Arthur Heymans 2017-04-28 20:53:05 +02:00 committed by Martin Roth
parent 349e08535a
commit 12a4e98cea
1 changed files with 22 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
src/northbridge/intel/pineview/raminit.c
View File

@ -356,7 +356,6 @@ static void sdram_detect_smallest_params(struct sysinfo *s)
}; };
u8 i; u8 i;
u32 tmp;
u32 maxtras = 0; u32 maxtras = 0;
u32 maxtrp = 0; u32 maxtrp = 0;
u32 maxtrcd = 0; u32 maxtrcd = 0;
@ -377,62 +376,28 @@ static void sdram_detect_smallest_params(struct sysinfo *s)
maxtrrd = max(maxtrrd, (s->dimms[i].spd_data[28] * 1000) >> 2); maxtrrd = max(maxtrrd, (s->dimms[i].spd_data[28] * 1000) >> 2);
maxtrtp = max(maxtrtp, (s->dimms[i].spd_data[38] * 1000) >> 2); maxtrtp = max(maxtrtp, (s->dimms[i].spd_data[38] * 1000) >> 2);
} }
for (i = 9; i < 24; i++) { // 16 /*
tmp = mult[s->selected_timings.mem_clock] * i; * TODO: on ddr3 there might be some minimal required values for some
if (tmp >= maxtras) { * Timings: MIN_TRAS = 9, MIN_TRP = 3, MIN_TRCD = 3, MIN_TWR = 3,
s->selected_timings.tRAS = i; * MIN_TWTR = 4, MIN_TRRD = 2, MIN_TRTP = 4
break; */
} s->selected_timings.tRAS = MIN(24, DIV_ROUND_UP(maxtras,
} mult[s->selected_timings.mem_clock]));
for (i = 3; i < 10; i++) { s->selected_timings.tRP = MIN(10, DIV_ROUND_UP(maxtrp,
tmp = mult[s->selected_timings.mem_clock] * i; mult[s->selected_timings.mem_clock]));
if (tmp >= maxtrp) { s->selected_timings.tRCD = MIN(10, DIV_ROUND_UP(maxtrcd,
s->selected_timings.tRP = i; mult[s->selected_timings.mem_clock]));
break; s->selected_timings.tWR = MIN(15, DIV_ROUND_UP(maxtwr,
} mult[s->selected_timings.mem_clock]));
} /* Needs to be even */
for (i = 3; i < 10; i++) { s->selected_timings.tRFC = 0xfe & (MIN(78, DIV_ROUND_UP(maxtrfc,
tmp = mult[s->selected_timings.mem_clock] * i; mult[s->selected_timings.mem_clock])) + 1);
if (tmp >= maxtrcd) { s->selected_timings.tWTR = MIN(15, DIV_ROUND_UP(maxtwtr,
s->selected_timings.tRCD = i; mult[s->selected_timings.mem_clock]));
break; s->selected_timings.tRRD = MIN(15, DIV_ROUND_UP(maxtrrd,
} mult[s->selected_timings.mem_clock]));
} s->selected_timings.tRTP = MIN(15, DIV_ROUND_UP(maxtras,
for (i = 3; i < 15; i++) { mult[s->selected_timings.mem_clock]));
tmp = mult[s->selected_timings.mem_clock] * i;
if (tmp >= maxtwr) {
s->selected_timings.tWR = i;
break;
}
}
for (i = 15; i < 78; i++) {
tmp = mult[s->selected_timings.mem_clock] * i;
if (tmp >= maxtrfc) {
s->selected_timings.tRFC = ((i + 16) & 0xfe) - 15;
break;
}
}
for (i = 4; i < 15; i++) {
tmp = mult[s->selected_timings.mem_clock] * i;
if (tmp >= maxtwtr) {
s->selected_timings.tWTR = i;
break;
}
}
for (i = 2; i < 15; i++) {
tmp = mult[s->selected_timings.mem_clock] * i;
if (tmp >= maxtrrd) {
s->selected_timings.tRRD = i;
break;
}
}
for (i = 4; i < 15; i++) {
tmp = mult[s->selected_timings.mem_clock] * i;
if (tmp >= maxtrtp) {
s->selected_timings.tRTP = i;
break;
}
}
PRINTK_DEBUG("Selected timings:\n"); PRINTK_DEBUG("Selected timings:\n");
PRINTK_DEBUG("\tFSB: %dMHz\n", fsb_reg_to_mhz(s->selected_timings.fsb_clock)); PRINTK_DEBUG("\tFSB: %dMHz\n", fsb_reg_to_mhz(s->selected_timings.fsb_clock));