GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork: enable wake on MKBP events 

The EC generates EC_MKBP_EVENT_DP_ALT_MODE_ENTERED when USB-C
connections enter DP alt mode, which should wake the system from S3.
Configure S3 wake events to include MKBP so this actually wakes
the system.

BUG=b:174121852
BRANCH=zork
TEST=Generating DP event on MKBP via EC console wakes morphius

Change-Id: I8100c6253e8e5cae91586c4f2f45d66c15fecc6d
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48844
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Reviewed-by: Sam McNally <sammc@google.com>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Peter Marheine 2020-12-21 17:02:08 +11:00 committed by Karthik Ramasubramanian
parent 8eca669fc0
commit 12defa9ee7
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h
View File

@ -38,7 +38,8 @@
#define MAINBOARD_EC_S3_WAKE_EVENTS \ #define MAINBOARD_EC_S3_WAKE_EVENTS \
(MAINBOARD_EC_S5_WAKE_EVENTS |\ (MAINBOARD_EC_S5_WAKE_EVENTS |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP))
/* Log EC wake events plus EC shutdown events */ /* Log EC wake events plus EC shutdown events */
#define MAINBOARD_EC_LOG_EVENTS \ #define MAINBOARD_EC_LOG_EVENTS \

3
src/mainboard/google/zork/variants/morphius/include/variant/ec.h
View File

@ -14,7 +14,8 @@
(MAINBOARD_EC_S5_WAKE_EVENTS |\ (MAINBOARD_EC_S5_WAKE_EVENTS |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_DEVICE) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_DEVICE) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) | \
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP))
/* Enable trackpoint S3 wakeups */ /* Enable trackpoint S3 wakeups */
#define MAINBOARD_EC_S3_DEVICE_EVENTS \ #define MAINBOARD_EC_S3_DEVICE_EVENTS \
(EC_DEVICE_EVENT_MASK(EC_DEVICE_EVENT_TRACKPAD)) (EC_DEVICE_EVENT_MASK(EC_DEVICE_EVENT_TRACKPAD))