From 130de14a0590cf4dac8021bbf66850a26896d932 Mon Sep 17 00:00:00 2001 From: Boris Mittelberg Date: Thu, 10 Feb 2022 16:30:40 -0800 Subject: [PATCH] arch/x86/acpi: Add code for KEY_MENU Support of MENU key (aka hamburger) for Chromebooks with Vivaldi keyboard BUG=b:215038215 TEST=manually tested on Anahera device: pressing T13 key opens menu Signed-off-by: Boris Mittelberg Change-Id: I07873dd9385c743a6512408688ec44a5e97219f9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61835 Reviewed-by: Rajat Jain Reviewed-by: Lance Zhao Reviewed-by: Tim Wawrzynczak Tested-by: build bot (Jenkins) --- src/acpi/acpigen_ps2_keybd.c | 1 + src/ec/google/chromeec/ec_acpi.c | 1 + src/include/acpi/acpigen_ps2_keybd.h | 1 + 3 files changed, 3 insertions(+) diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index a3ea4ef284..7928dad9da 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -55,6 +55,7 @@ static const uint32_t action_keymaps[] = { KEY_PRIVACY_SCREEN_TOGGLE), [PS2_KEY_MICMUTE] = KEYMAP(0x9b, KEY_MICMUTE), /* e01b */ [PS2_KEY_KBD_BKLIGHT_TOGGLE] = KEYMAP(0x9e, KEY_KBDILLUMTOGGLE), /* e01e */ + [PS2_KEY_MENU] = KEYMAP(0xdd, KEY_CONTROLPANEL), /* e0d5 */ }; /* Keymap for numeric keypad keys */ diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c index bf224b03e1..0244fd15e8 100644 --- a/src/ec/google/chromeec/ec_acpi.c +++ b/src/ec/google/chromeec/ec_acpi.c @@ -225,6 +225,7 @@ static const enum ps2_action_key ps2_enum_val[] = { [TK_PREV_TRACK] = PS2_KEY_PREV_TRACK, [TK_KBD_BKLIGHT_TOGGLE] = PS2_KEY_KBD_BKLIGHT_TOGGLE, [TK_MICMUTE] = PS2_KEY_MICMUTE, + [TK_MENU] = PS2_KEY_MENU, }; static void fill_ssdt_ps2_keyboard(const struct device *dev) diff --git a/src/include/acpi/acpigen_ps2_keybd.h b/src/include/acpi/acpigen_ps2_keybd.h index e32ca2a334..7dd82822f7 100644 --- a/src/include/acpi/acpigen_ps2_keybd.h +++ b/src/include/acpi/acpigen_ps2_keybd.h @@ -26,6 +26,7 @@ enum ps2_action_key { PS2_KEY_PREV_TRACK, PS2_KEY_KBD_BKLIGHT_TOGGLE, PS2_KEY_MICMUTE, + PS2_KEY_MENU, }; #define PS2_MIN_TOP_ROW_KEYS 10