GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "mb/starlabs/*: Enable the Mirror flag for boards that support" 

This reverts commit 35354583cd.

Reason for revert: The mirror flag "0x01" is mirror once, which
relies on the EC remembering that it's been mirrored. However, the
EC forgets this if it's been without power for 20 minutes or so.

Even if power is connected then, it'll instantly try to mirror and
it can't charge whilst doing it. It can either result in
incomplete EC firmware, or a loop where it's constantly trying to
mirror.

Change-Id: Ie82cbafd4bea2416526e2847738802a05ed45582
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72677
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Sean Rhodes 2023-02-16 08:20:20 +00:00 committed by Felix Held
parent 42f0396a10
commit 132fb3cc52
5 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/starlabs/starbook/Kconfig
View File

@ -29,7 +29,6 @@ config BOARD_STARLABS_LABTOP_CML
select BOARD_ROMSIZE_KB_16384
select BOARD_STARLABS_STARBOOK_SERIES
select EC_STARLABS_MAX_CHARGE
select EC_STARLABS_MIRROR_FLAG
select EC_STARLABS_NEED_ITE_BIN
select HAVE_INTEL_PTT
select HAVE_SPD_IN_CBFS
@ -45,7 +44,6 @@ config BOARD_STARLABS_STARBOOK_TGL
select DRIVERS_INTEL_USB4_RETIMER
select EC_STARLABS_KBL_LEVELS
select EC_STARLABS_MAX_CHARGE
select EC_STARLABS_MIRROR_FLAG
select EC_STARLABS_NEED_ITE_BIN
select MEMORY_MAPPED_TPM
select SOC_INTEL_COMMON_BLOCK_TCSS

1
src/mainboard/starlabs/starbook/cmos.default
View File

@ -15,7 +15,6 @@ legacy_8254_timer=Disable
# EC
kbl_timeout=30 seconds
fn_ctrl_swap=Disable
mirror_flag=Enable
# southbridge
power_on_after_fail=Disable
# Functions

1
src/mainboard/starlabs/starbook/cmos.layout
View File

@ -34,7 +34,6 @@ entries
608 1 e 1 fn_ctrl_swap
616 2 e 8 max_charge
624 2 e 9 fan_mode
632 1 e 1 mirror_flag
# coreboot config options: southbridge
800 2 e 6 power_on_after_fail

1
src/mainboard/starlabs/starbook/variants/tgl/cmos.default
View File

@ -16,7 +16,6 @@ thunderbolt=Disable
# EC
kbl_timeout=30 seconds
fn_ctrl_swap=Disable
mirror_flag=Enable
# southbridge
power_on_after_fail=Disable
# Functions

1
src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
View File

@ -35,7 +35,6 @@ entries
608 1 e 1 fn_ctrl_swap
616 2 e 8 max_charge
624 2 e 9 fan_mode
632 1 e 1 mirror_flag
# coreboot config options: southbridge
800 2 e 6 power_on_after_fail