GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/prodrive/hermes: Use PCH_DEV_SMBUS definition 

This allows dropping ugly preprocessor usage from this file.

Change-Id: Idb66d295129d98725f38d11ac162978418bd94c2
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47959
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Angel Pons 2020-11-24 15:39:26 +01:00 committed by Patrick Georgi
parent fe17a8cd6a
commit 13c50005c5
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mainboard/prodrive/hermes/eeprom.c
View File

@ -31,14 +31,8 @@ bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_off
{ {
int ret = 0; int ret = 0;
#if ENV_ROMSTAGE u32 smb_ctrl_reg = pci_read_config32(PCH_DEV_SMBUS, HOSTC);
pci_devfn_t dev = PCI_DEV(0, PCH_DEV_SLOT_LPC, 4); pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);
#else
const struct device *dev = pcidev_on_root(PCH_DEV_SLOT_LPC, 4);
#endif
u32 smb_ctrl_reg = pci_read_config32(dev, HOSTC);
pci_write_config32(dev, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);
printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__, printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__,
read_offset, size); read_offset, size);
@ -61,7 +55,7 @@ bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_off
} }
/* Restore I2C_EN bit */ /* Restore I2C_EN bit */
pci_write_config32(dev, HOSTC, smb_ctrl_reg); pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg);
return ret; return ret;
} }