GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload: Fix unaligned buffer logic in default_memset 

Fix an issue when setting an unaligned buffer where n is less
than the difference of the rounded up pointer and the pointer.
This was identified where n=1 was passed.  n was decremented
once, as expected, then decremented again after the while()
evaluated to false.  This resulted in a new n of 4GB.

Change-Id: I862671bbe7efa8d370d0148e22ea55407e260053
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/20655
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Marshall Dawson 2017-07-19 16:14:03 -06:00 committed by Julius Werner
parent 65943e1670
commit 148a7a60d8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
payloads/libpayload/libc/memory.c
View File

@ -41,8 +41,10 @@ static void *default_memset(void *s, int c, size_t n)
u8 *p = s; u8 *p = s;
s = (void *)ALIGN_UP((uintptr_t)s, sizeof(unsigned long)); s = (void *)ALIGN_UP((uintptr_t)s, sizeof(unsigned long));
while (p != (u8 *)s && n--) while (p != (u8 *)s && n) {
*p++ = c; *p++ = c;
n--;
}
for (i = 1; i < sizeof(unsigned long); i <<= 1) for (i = 1; i < sizeof(unsigned long); i <<= 1)
w = (w << (i * 8)) | w; w = (w << (i * 8)) | w;