GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/alderlake: remove unnecessary test condition 

mch_id is set to zero and then unnecessarily tested.

TEST=build and boot image on ADL RVP board

Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Change-Id: I20734e1638714027b976043b3a0457cbf3cd8442
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65121
Reviewed-by: Bora Guvendik <bora.guvendik@intel.com>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-by: Cliff Huang <cliff.huang@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jeremy Compostella 2022-06-07 10:25:43 -07:00 committed by Felix Held
parent 52ab283f00
commit 14908bf05a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/intel/alderlake/vr_config.c
View File

@ -181,13 +181,9 @@ void fill_vr_domain_config(FSP_S_CONFIG *s_cfg,
s_cfg->TdcTimeWindow[domain] = cfg->tdc_timewindow; s_cfg->TdcTimeWindow[domain] = cfg->tdc_timewindow;
s_cfg->TdcCurrentLimit[domain] = cfg->tdc_currentlimit; s_cfg->TdcCurrentLimit[domain] = cfg->tdc_currentlimit;
} else { } else {
uint16_t mch_id = 0;
uint8_t tdp = get_cpu_tdp(); uint8_t tdp = get_cpu_tdp();
struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
if (!mch_id) { uint16_t mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff;
struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff;
}
s_cfg->AcLoadline[domain] = load_table(vr_config_ll, ARRAY_SIZE(vr_config_ll), s_cfg->AcLoadline[domain] = load_table(vr_config_ll, ARRAY_SIZE(vr_config_ll),
domain, mch_id, tdp); domain, mch_id, tdp);