GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge: Do not hardcode resource indices 

Other northbridges use an index variable to assign monotonically
incrementing values to each resource. Do it here as well.

Change-Id: I8719a1a5973a10531cf11b3307652212cb3d4895
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41375
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Angel Pons 2020-05-13 21:46:46 +02:00 committed by Patrick Georgi
parent aae1633069
commit 14ea2fc90c
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/northbridge/intel/sandybridge/northbridge.c
View File

@ -135,6 +135,7 @@ static void mc_read_resources(struct device *dev)
uint32_t tseg_base, uma_size, tolud; uint32_t tseg_base, uma_size, tolud;
uint16_t ggc; uint16_t ggc;
unsigned long long tomk; unsigned long long tomk;
unsigned long index = 3;
pci_dev_read_resources(dev); pci_dev_read_resources(dev);
@ -238,9 +239,9 @@ static void mc_read_resources(struct device *dev)
printk(BIOS_INFO, "Available memory below 4GB: %lluM\n", tomk >> 10); printk(BIOS_INFO, "Available memory below 4GB: %lluM\n", tomk >> 10);
/* Report the memory regions */ /* Report the memory regions */
ram_resource(dev, 3, 0, legacy_hole_base_k); ram_resource(dev, index++, 0, legacy_hole_base_k);
ram_resource(dev, 4, legacy_hole_base_k + legacy_hole_size_k, ram_resource(dev, index++, legacy_hole_base_k + legacy_hole_size_k,
(tomk - (legacy_hole_base_k + legacy_hole_size_k))); (tomk - (legacy_hole_base_k + legacy_hole_size_k)));
/* /*
* If >= 4GB installed, then memory from TOLUD to 4GB is remapped above TOM. * If >= 4GB installed, then memory from TOLUD to 4GB is remapped above TOM.
@ -248,11 +249,11 @@ static void mc_read_resources(struct device *dev)
*/ */
touud >>= 10; /* Convert to KB */ touud >>= 10; /* Convert to KB */
if (touud > 4096 * 1024) { if (touud > 4096 * 1024) {
ram_resource(dev, 5, 4096 * 1024, touud - (4096 * 1024)); ram_resource(dev, index++, 4096 * 1024, touud - (4096 * 1024));
printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (touud >> 10) - 4096); printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (touud >> 10) - 4096);
} }
add_fixed_resources(dev, 6); add_fixed_resources(dev, index++);
} }
static void northbridge_dmi_init(struct device *dev) static void northbridge_dmi_init(struct device *dev)