From 14f61424d04b881c2b03c84b3098c8a35611dd78 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Mon, 21 May 2012 14:38:08 +0200 Subject: [PATCH] libpayload: Disable some buggy debugging code This disables some debugging code in the OHCI USB driver which causes reboots under rare circumstances. Change-Id: Ic274c162846137ee00638ffbc59ccf1d8130586f Signed-off-by: Nico Huber Reviewed-on: http://review.coreboot.org/1074 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- payloads/libpayload/drivers/usb/ohci.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c index 2c14b9fed6..1e2386e588 100644 --- a/payloads/libpayload/drivers/usb/ohci.c +++ b/payloads/libpayload/drivers/usb/ohci.c @@ -214,6 +214,11 @@ wait_for_ed(usbdev_t *dev, ed_t *head) mdelay(1); } mdelay(5); +#if 0 + /* XXX: The following debugging code may follow invalid lists and + * cause a reboot. + */ +#ifdef USB_DEBUG if (OHCI_INST(dev->controller)->opreg->HcInterruptStatus & WritebackDoneHead) { debug("done queue:\n"); debug("%x, %x\n", OHCI_INST(dev->controller)->hcca->HccaDoneHead, phys_to_virt(OHCI_INST(dev->controller)->hcca->HccaDoneHead)); @@ -236,6 +241,8 @@ wait_for_ed(usbdev_t *dev, ed_t *head) } OHCI_INST(dev->controller)->opreg->HcInterruptStatus &= ~WritebackDoneHead; } +#endif +#endif if (head->head_pointer & 1) { debug("HALTED!\n");