GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Call PNOT() when Battery Status Changes 

PNOT() should be called when the battery status changes, to give the SOC
an opportunity to handle it. This is in preparation for the low/no
battery boot changes.

This CL also updates the PNOT() comments to better match the name of the
function and why it's called.

BRANCH=none
BUG=b:217911928
TEST=Boot skyrim

Change-Id: I8b74313d242fd4959315a67579eb6c5f49a31a76
Signed-off-by: Tim Van Patten <timvp@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66993
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
Tim Van Patten 2022-08-22 14:06:11 -06:00 committed by Felix Held
parent 5684941f8b
commit 14fa11f9b9
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/ec/google/chromeec/acpi/ec.asl
View File

@ -166,8 +166,10 @@ Device (EC0)
// Initialize AC power state // Initialize AC power state
Store (ACEX, \PWRS) Store (ACEX, \PWRS)
/* /*
* Inform platform code about the current AC power state. * Call PNOT (Platform Notify) to inform platform code
* This allows the platform to take any action based on the initialized state. * about the current AC/battery state. This handles all cases,
* the battery transitioning into and out of having critically
* low charge.
* PWRS isn't valid before this point. * PWRS isn't valid before this point.
*/ */
\PNOT () \PNOT ()
@ -258,6 +260,12 @@ Device (EC0)
Notify (\_SB.DPTF.TCHG, 0x80) Notify (\_SB.DPTF.TCHG, 0x80)
} }
#endif #endif
/*
* Call PNOT (Platform Notify) to inform platform code
* about the current battery state. This handles all cases,
* the battery transitioning into and out of having critically
* low charge.
*/
\PNOT () \PNOT ()
} }
@ -272,6 +280,12 @@ Device (EC0)
Notify (\_SB.DPTF.TCHG, 0x80) Notify (\_SB.DPTF.TCHG, 0x80)
} }
#endif #endif
/*
* Call PNOT (Platform Notify) to inform platform code
* about the current battery state. This handles all cases,
* the battery transitioning into and out of having critically
* low charge.
*/
\PNOT () \PNOT ()
} }
@ -384,6 +398,14 @@ Device (EC0)
Notify (BAT1, 0x80) Notify (BAT1, 0x80)
} }
#endif #endif
/*
* Call PNOT (Platform Notify) to inform platform code
* about the current battery state. This handles all cases,
* the battery transitioning into and out of having critically
* low charge.
*/
\PNOT ()
} }
// MKBP interrupt. // MKBP interrupt.