From 156ff1304905845736834d33b6a2d04ef5773ec5 Mon Sep 17 00:00:00 2001 From: Christopher Kilgour Date: Sat, 15 Jun 2013 23:52:36 -0700 Subject: [PATCH] cpu/amd/geode_lx/cache_as_ram.inc: Use $ for constant value instead of memory reference An uninitialized RAM value was used to select an MSR because a $ was forgotten in front of `CPU_DM_CONFIG0`. It should be the constant value 0x1800, corresponding to CPU_DM_CONFIG0 MSR defined in `src/include/cpu/amd/lxdef.h`. Change-Id: Id53ca98b06cc4a9b55916fd8db23904f98008d45 Signed-off-by: Christopher Kilgour Reviewed-on: http://review.coreboot.org/3478 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Christian Gmeiner --- src/cpu/amd/geode_lx/cache_as_ram.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/amd/geode_lx/cache_as_ram.inc b/src/cpu/amd/geode_lx/cache_as_ram.inc index d2c241565e..45fd16691b 100644 --- a/src/cpu/amd/geode_lx/cache_as_ram.inc +++ b/src/cpu/amd/geode_lx/cache_as_ram.inc @@ -46,7 +46,7 @@ DCacheSetup: wrmsr /* in LX DCDIS is set after POR which disables the cache..., clear this bit */ - movl CPU_DM_CONFIG0,%ecx + movl $CPU_DM_CONFIG0,%ecx rdmsr andl $(~(DM_CONFIG0_LOWER_DCDIS_SET)), %eax /* TODO: make consistent with i$ init, either whole reg = 0, or just this bit... */ wrmsr