GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/nvidia/ck804: Remove old debugging code 

These printk() statements were added in commit cdc526e582
(southbridge/nvidia/ck804: Fix boot hang on ASUS KFSN4-DRE w/ K8 CPU)
when debugging another issue. They have undefined reads if ck804_num
is 0 and aren't needed anymore, so drop them.

Change-Id: I80b775370ac6485958948f0bff4510755a6cd2b8
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 137058{1,3}
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33459
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jacob Garber 2019-06-13 16:34:54 -06:00 committed by Patrick Georgi
parent 967f862e47
commit 15947182fd
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/southbridge/nvidia/ck804/early_setup_car.c
View File

@ -355,11 +355,8 @@ static int ck804_early_setup_x(void)
} }
} }
printk(BIOS_DEBUG, "ck804_early_set_port(%d, %d, %d)\n", ck804_num, busn[0], io_base[0]);
ck804_early_set_port(ck804_num, busn, io_base); ck804_early_set_port(ck804_num, busn, io_base);
printk(BIOS_DEBUG, "ck804_early_setup(%d, %d, %d)\n", ck804_num, busn[0], io_base[0]);
ck804_early_setup(ck804_num, busn, io_base); ck804_early_setup(ck804_num, busn, io_base);
printk(BIOS_DEBUG, "ck804_early_clear_port(%d, %d, %d)\n", ck804_num, busn[0], io_base[0]);
ck804_early_clear_port(ck804_num, busn, io_base); ck804_early_clear_port(ck804_num, busn, io_base);
return set_ht_link_ck804(4); return set_ht_link_ck804(4);