GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i945/gma: Fix wrong comment about the documentation. 

The GTT location is documented in the "309219" datasheet.
For instance it can be found in the TOLUD register description.

The 309219 datasheet is for the
"Mobile Intel® 945 Express Chipset Family". It was published in 2008.

Change-Id: I75ac095ebc577e031af566963ebffe9ed2587c96
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Reviewed-on: http://review.coreboot.org/9622
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Denis 'GNUtoo' Carikli 2014-10-14 07:33:53 +02:00 committed by Patrick Georgi
parent 9616f3ceb7
commit 16110e7ffa
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/northbridge/intel/i945/gma.c
View File

@ -58,12 +58,7 @@ static int gtt_setup(void *mmiobase)
/* /*
* The Video BIOS places the GTT right below top of memory. * The Video BIOS places the GTT right below top of memory.
* */
* It is not documented in the Intel 945 datasheet, but the Intel
* developers said that it is normally placed there.
*
* TODO: Add option to make the GTT size runtime configurable
*/
tom = pci_read_config8(dev_find_slot(0, PCI_DEVFN(0, 0)), TOLUD) << 24; tom = pci_read_config8(dev_find_slot(0, PCI_DEVFN(0, 0)), TOLUD) << 24;
PGETBL_save = tom - 256 * KiB; PGETBL_save = tom - 256 * KiB;
PGETBL_save |= PGETBL_ENABLED; PGETBL_save |= PGETBL_ENABLED;