From 163dfe68f68890b4a0c3283c215d159bf90ea1bb Mon Sep 17 00:00:00 2001 From: Ren Kuo Date: Mon, 2 Aug 2021 14:31:35 +0800 Subject: [PATCH] mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen The all shipped magolor and maglia has SSFC= 0x840. The value is defined as 5M MIPI camera.But the value:0x840 will conflict with the updated touchscreen field. It will cause some touchscreen no function if make auto-update new firmware.The CL would correct the field error. The original fields: CAMERA_WFC 38 40 TS_SOURCE 41 44 Correct fields: MIPI Cam CAMERA_WFC 38 40 CAMERA_UFC 41 42 CAMERA_VCM 43 44 Touch-screen TS_SOURCE 45 48 The SSFC value of Magolor: CAMERA_OVTI5675 5M AF (SSFC = 0x840) CAMERA_OVTI8856 8M AF (SSFC = 0x880) BUG=b:194639170 TEST=Build firmware and verify on camera and touch-screen devices Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1 Signed-off-by: Ren Kuo Reviewed-on: https://review.coreboot.org/c/coreboot/+/56685 Reviewed-by: Evan Green Reviewed-by: Karthik Ramasubramanian Tested-by: build bot (Jenkins) --- .../dedede/variants/magolor/overridetree.cb | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index ef0dd2c3d6..60e82cb3b1 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -1,10 +1,17 @@ fw_config field CAMERA_WFC 38 40 - option CAMERA_NONE 0 + option CAMERA_UNPROVISIONED 0 option CAMERA_OVTI5675 1 option CAMERA_OVTI8856 2 end - field TS_SOURCE 41 44 + field CAMERA_UFC 41 42 + option CAMERA_UFC_UNPROVISIONED 0 + end + field CAMERA_VCM 43 44 + option CAMERA_VCM_UNPROVISIONED 0 + option CAMERA_VCM0 1 + end + field TS_SOURCE 45 48 option TS_UNPROVISIONED 0 option TS_ELAN_6915 1 option TS_ELAN_6918 2 @@ -324,7 +331,7 @@ chip soc/intel/jasperlake register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" device i2c 36 on - probe CAMERA_WFC CAMERA_NONE + probe CAMERA_WFC CAMERA_UNPROVISIONED probe CAMERA_WFC CAMERA_OVTI5675 end end @@ -381,8 +388,10 @@ chip soc/intel/jasperlake register "pr0" = ""\\_SB.PCI0.I2C3.CAM0.PRIC"" register "vcm_compat" = ""dongwoon,dw9714"" - device i2c 0C on end - + device i2c 0C on + probe CAMERA_VCM CAMERA_VCM_UNPROVISIONED + probe CAMERA_VCM CAMERA_VCM0 + end end chip drivers/intel/mipi_camera register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"