From 16612c483515bb09796ea2dad0e8ba24cd425069 Mon Sep 17 00:00:00 2001 From: Reka Norman Date: Thu, 16 Sep 2021 14:11:34 +1000 Subject: [PATCH] lib/Makefile.inc: Fail build if SPD file doesn't exist Currently, if LIB_SPD_DEPS contains an SPD file which doesn't exist, the file is silently skipped when creating spd.bin. Instead, fail the build. BUG=b:191776301 TEST=Build test on brya. Build fails if a non-existent file is included in LIB_SPD_DEPS. Change-Id: I1bdadb72e087c2ee7a88fbab2f3607bd400fa2e4 Signed-off-by: Reka Norman Reviewed-on: https://review.coreboot.org/c/coreboot/+/57697 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Furquan Shaikh --- src/lib/Makefile.inc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index bb3cf6a080..7b21c80dc7 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -366,10 +366,14 @@ $(LIB_SPD_BIN): $(LIB_SPD_DEPS) (echo "HAVE_SPD_IN_CBFS is set but SPD_SOURCES is empty" && exit 1) test -n "$(LIB_SPD_DEPS)" || \ (echo "SPD_SOURCES is set but no SPD file was found" && exit 1) - for f in $(LIB_SPD_DEPS); \ - do for c in $$(cat $$f | grep --binary-files=text -v ^#); \ - do printf $$(printf '\\%o' 0x$$c); \ - done; \ + for f in $(LIB_SPD_DEPS); do \ + if [ ! -f $$f ]; then \ + echo "File not found: $$f" >&2; \ + exit 1; \ + fi; \ + for c in $$(cat $$f | grep --binary-files=text -v ^#); \ + do printf $$(printf '\\%o' 0x$$c); \ + done; \ done > $@ cbfs-files-y += spd.bin