GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Kconfig: Allow mainboards to disable stage cache 

On recent Intel ChromeOS devices, although S3 is still supported, only
S0ix is used on user devices, so we don't care about optimising S3
resume time. Disabing the stage cache saves boot time at the cost of
increasing the S3 resume time. E.g. on nissa this reduces boot time by
6 ms and increases S3 resume time by 89 ms.

BUG=b:247940538, b:192032803
TEST=Build and boot on nissa with MAINBOARD_DISABLE_STAGE_CACHE
selected.

Change-Id: I243a401a112a12bb824c5447a8fecc99500f7739
Signed-off-by: Reka Norman <rekanorman@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71676
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Reka Norman 2022-12-19 11:11:48 +11:00 committed by Subrata Banik
parent 17c847b5ea
commit 166c30309e
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Kconfig
View File

@ -347,7 +347,7 @@ endif
choice
prompt "Stage Cache for ACPI S3 resume"
default NO_STAGE_CACHE if !HAVE_ACPI_RESUME
default NO_STAGE_CACHE if !HAVE_ACPI_RESUME || MAINBOARD_DISABLE_STAGE_CACHE
default TSEG_STAGE_CACHE if SMM_TSEG
config NO_STAGE_CACHE
@ -380,6 +380,13 @@ config CBMEM_STAGE_CACHE
endchoice
config MAINBOARD_DISABLE_STAGE_CACHE
bool
help
Selected by mainboards which wish to disable the stage cache.
E.g. mainboards which don't use S3 resume in the field may wish to
disable it to save boot time at the cost of increasing S3 resume time.
config UPDATE_IMAGE
bool "Update existing coreboot.rom image"
help