From 16b6937ea7520aa2c55df7a2c7cc624e5dfbe68f Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 28 Jul 2023 09:13:05 -0500 Subject: [PATCH] mb/google/{auron,link,slippy}/acpi: Drop EC serial port The EC serial port on these devices is not accessible to the end user and exposing it to the OS via ACPI serves no purpose. Debugging over the EC serial port (via the servo interface) does not require the ACPI exist. Drop it since it's not needed and serves no purpose. TEST=build/boot Win11 on auron/link/slippy, verify Windows Device Manager no longer shows an unusable COM port. Change-Id: If453bfca8e094aa06043293bdf91a40c38cc7866 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/76793 Reviewed-by: Eric Lai Reviewed-by: Felix Singer Reviewed-by: CoolStar Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/google/auron/acpi/superio.asl | 1 - src/mainboard/google/link/acpi/superio.asl | 1 - src/mainboard/google/slippy/acpi/superio.asl | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mainboard/google/auron/acpi/superio.asl b/src/mainboard/google/auron/acpi/superio.asl index e3a31bc657..42eaba1825 100644 --- a/src/mainboard/google/auron/acpi/superio.asl +++ b/src/mainboard/google/auron/acpi/superio.asl @@ -6,7 +6,6 @@ #define SIO_EC_MEMMAP_ENABLE // EC Memory Map Resources #define SIO_EC_HOST_ENABLE // EC Host Interface Resources #define SIO_EC_ENABLE_PS2K // Enable PS/2 Keyboard -#define SIO_EC_ENABLE_COM1 // Enable Serial Port 1 /* ACPI code for EC SuperIO functions */ #include diff --git a/src/mainboard/google/link/acpi/superio.asl b/src/mainboard/google/link/acpi/superio.asl index 0dc0696336..b30da54749 100644 --- a/src/mainboard/google/link/acpi/superio.asl +++ b/src/mainboard/google/link/acpi/superio.asl @@ -6,7 +6,6 @@ #define SIO_EC_MEMMAP_ENABLE // EC Memory Map Resources #define SIO_EC_HOST_ENABLE // EC Host Interface Resources #define SIO_EC_ENABLE_PS2K // Enable PS/2 Keyboard -#define SIO_EC_ENABLE_COM1 // Enable Serial Port 1 /* ACPI code for EC SuperIO functions */ #include "../../../../ec/google/chromeec/acpi/superio.asl" diff --git a/src/mainboard/google/slippy/acpi/superio.asl b/src/mainboard/google/slippy/acpi/superio.asl index 587bb8bf0f..4a1456bb0e 100644 --- a/src/mainboard/google/slippy/acpi/superio.asl +++ b/src/mainboard/google/slippy/acpi/superio.asl @@ -6,7 +6,6 @@ #define SIO_EC_MEMMAP_ENABLE // EC Memory Map Resources #define SIO_EC_HOST_ENABLE // EC Host Interface Resources #define SIO_EC_ENABLE_PS2K // Enable PS/2 Keyboard -#define SIO_EC_ENABLE_COM1 // Enable Serial Port 1 /* ACPI code for EC SuperIO functions */ #include