GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge: Don't use PCI operations on the pci_domain device 

pci ops happen to work on this struct device since the device_path is an union.

This patch still keeps adding the fixed resources in the pci_domain
ops since moving it to the PCI ops which could properly use the
function argument for PCI operations would require all PCI IDs to be
added or else breakages are to be expected.

Change-Id: Id73c16fad4fb9ece78595844a39da993d169f057
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/27244
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2018-06-26 21:06:25 +02:00 committed by Felix Held
parent bf7ad3775c
commit 17041207f2
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/northbridge/intel/sandybridge/northbridge.c
View File

@ -152,26 +152,28 @@ static void pci_domain_set_resources(struct device *dev)
* 14fe00000 5368MB TOUUD * 14fe00000 5368MB TOUUD
*/ */
struct device *mch = dev_find_slot(0, PCI_DEVFN(0, 0));
/* Top of Upper Usable DRAM, including remap */ /* Top of Upper Usable DRAM, including remap */
touud = pci_read_config32(dev, TOUUD+4); touud = pci_read_config32(mch, TOUUD+4);
touud <<= 32; touud <<= 32;
touud |= pci_read_config32(dev, TOUUD); touud |= pci_read_config32(mch, TOUUD);
/* Top of Lower Usable DRAM */ /* Top of Lower Usable DRAM */
tolud = pci_read_config32(dev, TOLUD); tolud = pci_read_config32(mch, TOLUD);
/* Top of Memory - does not account for any UMA */ /* Top of Memory - does not account for any UMA */
tom = pci_read_config32(dev, 0xa4); tom = pci_read_config32(mch, 0xa4);
tom <<= 32; tom <<= 32;
tom |= pci_read_config32(dev, 0xa0); tom |= pci_read_config32(mch, 0xa0);
printk(BIOS_DEBUG, "TOUUD 0x%llx TOLUD 0x%08x TOM 0x%llx\n", printk(BIOS_DEBUG, "TOUUD 0x%llx TOLUD 0x%08x TOM 0x%llx\n",
touud, tolud, tom); touud, tolud, tom);
/* ME UMA needs excluding if total memory <4GB */ /* ME UMA needs excluding if total memory <4GB */
me_base = pci_read_config32(dev, 0x74); me_base = pci_read_config32(mch, 0x74);
me_base <<= 32; me_base <<= 32;
me_base |= pci_read_config32(dev, 0x70); me_base |= pci_read_config32(mch, 0x70);
printk(BIOS_DEBUG, "MEBASE 0x%llx\n", me_base); printk(BIOS_DEBUG, "MEBASE 0x%llx\n", me_base);
@ -190,7 +192,7 @@ static void pci_domain_set_resources(struct device *dev)
} }
/* Graphics memory comes next */ /* Graphics memory comes next */
ggc = pci_read_config16(dev, GGC); ggc = pci_read_config16(mch, GGC);
if (!(ggc & 2)) { if (!(ggc & 2)) {
printk(BIOS_DEBUG, "IGD decoded, subtracting "); printk(BIOS_DEBUG, "IGD decoded, subtracting ");
@ -210,7 +212,7 @@ static void pci_domain_set_resources(struct device *dev)
} }
/* Calculate TSEG size from its base which must be below GTT */ /* Calculate TSEG size from its base which must be below GTT */
tseg_base = pci_read_config32(dev, 0xb8); tseg_base = pci_read_config32(mch, 0xb8);
uma_size = (uma_memory_base - tseg_base) >> 10; uma_size = (uma_memory_base - tseg_base) >> 10;
tomk -= uma_size; tomk -= uma_size;
uma_memory_base = tomk * 1024ULL; uma_memory_base = tomk * 1024ULL;