GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The point of the patch is to make it easier to understand the raminit 

code, specifically the difference between pre_f and f code.

The only functional changes are in printk statements.  The rest is white space.

1. Remove some #if 0 and #if 1 blocks
2. Remove #if USE_DCACHE_RAM blocks.  All K8 boards use CAR.
2. Correct typos (canidate -> candidate)
3. Try to minimize the differences between amdk8_f.h and amdk8_pre_f.h
4. Try to minimize the differences between raminit.c and raminit_f.c
5. Make boards that have rev_f processors include the correct raminit code

There is much more that could be done, but it's a start.

Abuild tested and boot tested on s2892 and serengeti_cheetah.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4337 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Myles Watson 2009-06-04 20:18:42 +00:00
parent d11bd003c6
commit 1725703a1d
11 changed files with 418 additions and 502 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/amd/dbm690t/cache_as_ram_auto.c
View File

@ -86,7 +86,7 @@ static inline int spd_read_byte(u32 device, u32 address)
#include "northbridge/amd/amdk8/amdk8.h" #include "northbridge/amd/amdk8/amdk8.h"
#include "northbridge/amd/amdk8/incoherent_ht.c" #include "northbridge/amd/amdk8/incoherent_ht.c"
#include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/raminit_f.c"
#include "northbridge/amd/amdk8/coherent_ht.c" #include "northbridge/amd/amdk8/coherent_ht.c"
#include "sdram/generic_sdram.c" #include "sdram/generic_sdram.c"
#include "resourcemap.c" #include "resourcemap.c"

2
src/mainboard/amd/pistachio/cache_as_ram_auto.c
View File

@ -80,7 +80,7 @@ static inline int spd_read_byte(u32 device, u32 address)
#include "northbridge/amd/amdk8/amdk8.h" #include "northbridge/amd/amdk8/amdk8.h"
#include "northbridge/amd/amdk8/incoherent_ht.c" #include "northbridge/amd/amdk8/incoherent_ht.c"
#include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/raminit_f.c"
#include "northbridge/amd/amdk8/coherent_ht.c" #include "northbridge/amd/amdk8/coherent_ht.c"
#include "sdram/generic_sdram.c" #include "sdram/generic_sdram.c"
#include "resourcemap.c" #include "resourcemap.c"

2
src/mainboard/amd/serengeti_cheetah/cache_as_ram_auto.c
View File

@ -124,7 +124,7 @@ static inline int spd_read_byte(unsigned device, unsigned address)
#include "northbridge/amd/amdk8/incoherent_ht.c" #include "northbridge/amd/amdk8/incoherent_ht.c"
#include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/raminit_f.c"
#include "sdram/generic_sdram.c" #include "sdram/generic_sdram.c"

2
src/mainboard/technexion/tim8690/cache_as_ram_auto.c
View File

@ -86,7 +86,7 @@ static inline int spd_read_byte(u32 device, u32 address)
#include "northbridge/amd/amdk8/amdk8.h" #include "northbridge/amd/amdk8/amdk8.h"
#include "northbridge/amd/amdk8/incoherent_ht.c" #include "northbridge/amd/amdk8/incoherent_ht.c"
#include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/raminit_f.c"
#include "northbridge/amd/amdk8/coherent_ht.c" #include "northbridge/amd/amdk8/coherent_ht.c"
#include "sdram/generic_sdram.c" #include "sdram/generic_sdram.c"
#include "resourcemap.c" #include "resourcemap.c"

14
src/northbridge/amd/amdk8/Config.lb
View File

@ -1,6 +1,7 @@
uses AGP_APERTURE_SIZE uses AGP_APERTURE_SIZE
uses HAVE_ACPI_TABLES uses HAVE_ACPI_TABLES
uses HAVE_HIGH_TABLES uses HAVE_HIGH_TABLES
uses K8_REV_F_SUPPORT
default AGP_APERTURE_SIZE=0x4000000 default AGP_APERTURE_SIZE=0x4000000
default HAVE_HIGH_TABLES=1 default HAVE_HIGH_TABLES=1
@ -10,12 +11,25 @@ config chip.h
driver northbridge.o driver northbridge.o
driver misc_control.o driver misc_control.o
if K8_REV_F_SUPPORT
makerule raminit_test
depends "$(TOP)/src/northbridge/amd/amdk8/raminit_test.c"
depends "$(TOP)/src/northbridge/amd/amdk8/raminit_f.c"
action "$(HOSTCC) $(HOSTCFLAGS) $(CPUFLAGS) -Wno-unused-function -I$(TOP)/src/include -g $< -o $@"
end
else
makerule raminit_test makerule raminit_test
depends "$(TOP)/src/northbridge/amd/amdk8/raminit_test.c" depends "$(TOP)/src/northbridge/amd/amdk8/raminit_test.c"
depends "$(TOP)/src/northbridge/amd/amdk8/raminit.c" depends "$(TOP)/src/northbridge/amd/amdk8/raminit.c"
action "$(HOSTCC) $(HOSTCFLAGS) $(CPUFLAGS) -Wno-unused-function -I$(TOP)/src/include -g $< -o $@" action "$(HOSTCC) $(HOSTCFLAGS) $(CPUFLAGS) -Wno-unused-function -I$(TOP)/src/include -g $< -o $@"
end end
end
if HAVE_ACPI_TABLES if HAVE_ACPI_TABLES
object amdk8_acpi.o object amdk8_acpi.o
end end

263
src/northbridge/amd/amdk8/amdk8.h
View File

@ -4,269 +4,8 @@
#if K8_REV_F_SUPPORT == 1 #if K8_REV_F_SUPPORT == 1
#include "amdk8_f.h" #include "amdk8_f.h"
#else #else
/* Definitions of various K8 registers */ #include "amdk8_pre_f.h"
/* Function 0 */
#define HT_TRANSACTION_CONTROL 0x68
#define HTTC_DIS_RD_B_P (1 << 0)
#define HTTC_DIS_RD_DW_P (1 << 1)
#define HTTC_DIS_WR_B_P (1 << 2)
#define HTTC_DIS_WR_DW_P (1 << 3)
#define HTTC_DIS_MTS (1 << 4)
#define HTTC_CPU1_EN (1 << 5)
#define HTTC_CPU_REQ_PASS_PW (1 << 6)
#define HTTC_CPU_RD_RSP_PASS_PW (1 << 7)
#define HTTC_DIS_P_MEM_C (1 << 8)
#define HTTC_DIS_RMT_MEM_C (1 << 9)
#define HTTC_DIS_FILL_P (1 << 10)
#define HTTC_RSP_PASS_PW (1 << 11)
#define HTTC_CHG_ISOC_TO_ORD (1 << 12)
#define HTTC_BUF_REL_PRI_SHIFT 13
#define HTTC_BUF_REL_PRI_MASK 3
#define HTTC_BUF_REL_PRI_64 0
#define HTTC_BUF_REL_PRI_16 1
#define HTTC_BUF_REL_PRI_8 2
#define HTTC_BUF_REL_PRI_2 3
#define HTTC_LIMIT_CLDT_CFG (1 << 15)
#define HTTC_LINT_EN (1 << 16)
#define HTTC_APIC_EXT_BRD_CST (1 << 17)
#define HTTC_APIC_EXT_ID (1 << 18)
#define HTTC_APIC_EXT_SPUR (1 << 19)
#define HTTC_SEQ_ID_SRC_NODE_EN (1 << 20)
#define HTTC_DS_NP_REQ_LIMIT_SHIFT 21
#define HTTC_DS_NP_REQ_LIMIT_MASK 3
#define HTTC_DS_NP_REQ_LIMIT_NONE 0
#define HTTC_DS_NP_REQ_LIMIT_1 1
#define HTTC_DS_NP_REQ_LIMIT_4 2
#define HTTC_DS_NP_REQ_LIMIT_8 3
#define HTTC_MED_PRI_BYP_CNT_SHIFT 24
#define HTTC_MED_PRI_BYP_CNT_MASK 3
#define HTTC_HI_PRI_BYP_CNT_SHIFT 26
#define HTTC_HI_PRI_BYP_CNT_MASK 3
/* Function 1 */
#define PCI_IO_BASE0 0xc0
#define PCI_IO_BASE1 0xc8
#define PCI_IO_BASE2 0xd0
#define PCI_IO_BASE3 0xd8
#define PCI_IO_BASE_VGA_EN (1 << 4)
#define PCI_IO_BASE_NO_ISA (1 << 5)
/* Function 2 */
#define DRAM_CSBASE 0x40
#define DRAM_CSMASK 0x60
#define DRAM_BANK_ADDR_MAP 0x80
#define DRAM_TIMING_LOW 0x88
#define DTL_TCL_SHIFT 0
#define DTL_TCL_MASK 0x7
#define DTL_CL_2 1
#define DTL_CL_3 2
#define DTL_CL_2_5 5
#define DTL_TRC_SHIFT 4
#define DTL_TRC_MASK 0xf
#define DTL_TRC_BASE 7
#define DTL_TRC_MIN 7
#define DTL_TRC_MAX 22
#define DTL_TRFC_SHIFT 8
#define DTL_TRFC_MASK 0xf
#define DTL_TRFC_BASE 9
#define DTL_TRFC_MIN 9
#define DTL_TRFC_MAX 24
#define DTL_TRCD_SHIFT 12
#define DTL_TRCD_MASK 0x7
#define DTL_TRCD_BASE 0
#define DTL_TRCD_MIN 2
#define DTL_TRCD_MAX 6
#define DTL_TRRD_SHIFT 16
#define DTL_TRRD_MASK 0x7
#define DTL_TRRD_BASE 0
#define DTL_TRRD_MIN 2
#define DTL_TRRD_MAX 4
#define DTL_TRAS_SHIFT 20
#define DTL_TRAS_MASK 0xf
#define DTL_TRAS_BASE 0
#define DTL_TRAS_MIN 5
#define DTL_TRAS_MAX 15
#define DTL_TRP_SHIFT 24
#define DTL_TRP_MASK 0x7
#define DTL_TRP_BASE 0
#define DTL_TRP_MIN 2
#define DTL_TRP_MAX 6
#define DTL_TWR_SHIFT 28
#define DTL_TWR_MASK 0x1
#define DTL_TWR_BASE 2
#define DTL_TWR_MIN 2
#define DTL_TWR_MAX 3
#define DRAM_TIMING_HIGH 0x8c
#define DTH_TWTR_SHIFT 0
#define DTH_TWTR_MASK 0x1
#define DTH_TWTR_BASE 1
#define DTH_TWTR_MIN 1
#define DTH_TWTR_MAX 2
#define DTH_TRWT_SHIFT 4
#define DTH_TRWT_MASK 0x7
#define DTH_TRWT_BASE 1
#define DTH_TRWT_MIN 1
#define DTH_TRWT_MAX 6
#define DTH_TREF_SHIFT 8
#define DTH_TREF_MASK 0x1f
#define DTH_TREF_100MHZ_4K 0x00
#define DTH_TREF_133MHZ_4K 0x01
#define DTH_TREF_166MHZ_4K 0x02
#define DTH_TREF_200MHZ_4K 0x03
#define DTH_TREF_100MHZ_8K 0x08
#define DTH_TREF_133MHZ_8K 0x09
#define DTH_TREF_166MHZ_8K 0x0A
#define DTH_TREF_200MHZ_8K 0x0B
#define DTH_TWCL_SHIFT 20
#define DTH_TWCL_MASK 0x7
#define DTH_TWCL_BASE 1
#define DTH_TWCL_MIN 1
#define DTH_TWCL_MAX 2
#define DRAM_CONFIG_LOW 0x90
#define DCL_DLL_Disable (1<<0)
#define DCL_D_DRV (1<<1)
#define DCL_QFC_EN (1<<2)
#define DCL_DisDqsHys (1<<3)
#define DCL_Burst2Opt (1<<5)
#define DCL_DramInit (1<<8)
#define DCL_DualDIMMen (1<<9)
#define DCL_DramEnable (1<<10)
#define DCL_MemClrStatus (1<<11)
#define DCL_ESR (1<<12)
#define DCL_SRS (1<<13)
#define DCL_128BitEn (1<<16)
#define DCL_DimmEccEn (1<<17)
#define DCL_UnBufDimm (1<<18)
#define DCL_32ByteEn (1<<19)
#define DCL_x4DIMM_SHIFT 20
#define DCL_DisInRcvrs (1<<24)
#define DCL_BypMax_SHIFT 25
#define DCL_En2T (1<<28)
#define DCL_UpperCSMap (1<<29)
#define DRAM_CONFIG_HIGH 0x94
#define DCH_ASYNC_LAT_SHIFT 0
#define DCH_ASYNC_LAT_MASK 0xf
#define DCH_ASYNC_LAT_BASE 0
#define DCH_ASYNC_LAT_MIN 0
#define DCH_ASYNC_LAT_MAX 15
#define DCH_RDPREAMBLE_SHIFT 8
#define DCH_RDPREAMBLE_MASK 0xf
#define DCH_RDPREAMBLE_BASE ((2<<1)+0) /* 2.0 ns */
#define DCH_RDPREAMBLE_MIN ((2<<1)+0) /* 2.0 ns */
#define DCH_RDPREAMBLE_MAX ((9<<1)+1) /* 9.5 ns */
#define DCH_IDLE_LIMIT_SHIFT 16
#define DCH_IDLE_LIMIT_MASK 0x7
#define DCH_IDLE_LIMIT_0 0
#define DCH_IDLE_LIMIT_4 1
#define DCH_IDLE_LIMIT_8 2
#define DCH_IDLE_LIMIT_16 3
#define DCH_IDLE_LIMIT_32 4
#define DCH_IDLE_LIMIT_64 5
#define DCH_IDLE_LIMIT_128 6
#define DCH_IDLE_LIMIT_256 7
#define DCH_DYN_IDLE_CTR_EN (1 << 19)
#define DCH_MEMCLK_SHIFT 20
#define DCH_MEMCLK_MASK 0x7
#define DCH_MEMCLK_100MHZ 0
#define DCH_MEMCLK_133MHZ 2
#define DCH_MEMCLK_166MHZ 5
#define DCH_MEMCLK_200MHZ 7
#define DCH_MEMCLK_VALID (1 << 25)
#define DCH_MEMCLK_EN0 (1 << 26)
#define DCH_MEMCLK_EN1 (1 << 27)
#define DCH_MEMCLK_EN2 (1 << 28)
#define DCH_MEMCLK_EN3 (1 << 29)
/* Function 3 */
#define MCA_NB_CONFIG 0x44
#define MNC_ECC_EN (1 << 22)
#define MNC_CHIPKILL_EN (1 << 23)
#define SCRUB_CONTROL 0x58
#define SCRUB_NONE 0
#define SCRUB_40ns 1
#define SCRUB_80ns 2
#define SCRUB_160ns 3
#define SCRUB_320ns 4
#define SCRUB_640ns 5
#define SCRUB_1_28us 6
#define SCRUB_2_56us 7
#define SCRUB_5_12us 8
#define SCRUB_10_2us 9
#define SCRUB_20_5us 10
#define SCRUB_41_0us 11
#define SCRUB_81_9us 12
#define SCRUB_163_8us 13
#define SCRUB_327_7us 14
#define SCRUB_655_4us 15
#define SCRUB_1_31ms 16
#define SCRUB_2_62ms 17
#define SCRUB_5_24ms 18
#define SCRUB_10_49ms 19
#define SCRUB_20_97ms 20
#define SCRUB_42ms 21
#define SCRUB_84ms 22
#define SC_DRAM_SCRUB_RATE_SHFIT 0
#define SC_DRAM_SCRUB_RATE_MASK 0x1f
#define SC_L2_SCRUB_RATE_SHIFT 8
#define SC_L2_SCRUB_RATE_MASK 0x1f
#define SC_L1D_SCRUB_RATE_SHIFT 16
#define SC_L1D_SCRUB_RATE_MASK 0x1f
#define SCRUB_ADDR_LOW 0x5C
#define SCRUB_ADDR_HIGH 0x60
#define NORTHBRIDGE_CAP 0xE8
#define NBCAP_128Bit (1 << 0)
#define NBCAP_MP (1 << 1)
#define NBCAP_BIG_MP (1 << 2)
#define NBCAP_ECC (1 << 3)
#define NBCAP_CHIPKILL_ECC (1 << 4)
#define NBCAP_MEMCLK_SHIFT 5
#define NBCAP_MEMCLK_MASK 3
#define NBCAP_MEMCLK_100MHZ 3
#define NBCAP_MEMCLK_133MHZ 2
#define NBCAP_MEMCLK_166MHZ 1
#define NBCAP_MEMCLK_200MHZ 0
#define NBCAP_MEMCTRL (1 << 8)
#define LinkConnected (1 << 0)
#define InitComplete (1 << 1)
#define NonCoherent (1 << 2)
#define ConnectionPending (1 << 4)
#include "raminit.h"
//struct definitions
struct link_pair_st {
device_t udev;
uint32_t upos;
uint32_t uoffs;
device_t dev;
uint32_t pos;
uint32_t offs;
} __attribute__((packed));
struct sys_info {
uint8_t ctrl_present[NODE_NUMS];
struct mem_controller ctrl[NODE_NUMS];
uint32_t nodes;
struct link_pair_st link_pair[16];// enough? only in_conherent
uint32_t link_pair_num;
uint32_t ht_c_num;
uint32_t sbdn;
uint32_t sblk;
uint32_t sbbusn;
} __attribute__((packed));
#endif #endif
#endif /* AMDK8_H */ #endif /* AMDK8_H */

1
src/northbridge/amd/amdk8/amdk8_f.h
View File

@ -456,7 +456,6 @@ that are corresponding to 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x10,
#define NonCoherent (1 << 2) #define NonCoherent (1 << 2)
#define ConnectionPending (1 << 4) #define ConnectionPending (1 << 4)
#include "raminit.h" #include "raminit.h"
//struct definitions //struct definitions

266
src/northbridge/amd/amdk8/amdk8_pre_f.h Normal file
View File

@ -0,0 +1,266 @@
#ifndef AMDK8_PRE_F_H
#define AMDK8_PRE_F_H
/* Definitions of various K8 registers */
/* Function 0 */
#define HT_TRANSACTION_CONTROL 0x68
#define HTTC_DIS_RD_B_P (1 << 0)
#define HTTC_DIS_RD_DW_P (1 << 1)
#define HTTC_DIS_WR_B_P (1 << 2)
#define HTTC_DIS_WR_DW_P (1 << 3)
#define HTTC_DIS_MTS (1 << 4)
#define HTTC_CPU1_EN (1 << 5)
#define HTTC_CPU_REQ_PASS_PW (1 << 6)
#define HTTC_CPU_RD_RSP_PASS_PW (1 << 7)
#define HTTC_DIS_P_MEM_C (1 << 8)
#define HTTC_DIS_RMT_MEM_C (1 << 9)
#define HTTC_DIS_FILL_P (1 << 10)
#define HTTC_RSP_PASS_PW (1 << 11)
#define HTTC_CHG_ISOC_TO_ORD (1 << 12)
#define HTTC_BUF_REL_PRI_SHIFT 13
#define HTTC_BUF_REL_PRI_MASK 3
#define HTTC_BUF_REL_PRI_64 0
#define HTTC_BUF_REL_PRI_16 1
#define HTTC_BUF_REL_PRI_8 2
#define HTTC_BUF_REL_PRI_2 3
#define HTTC_LIMIT_CLDT_CFG (1 << 15)
#define HTTC_LINT_EN (1 << 16)
#define HTTC_APIC_EXT_BRD_CST (1 << 17)
#define HTTC_APIC_EXT_ID (1 << 18)
#define HTTC_APIC_EXT_SPUR (1 << 19)
#define HTTC_SEQ_ID_SRC_NODE_EN (1 << 20)
#define HTTC_DS_NP_REQ_LIMIT_SHIFT 21
#define HTTC_DS_NP_REQ_LIMIT_MASK 3
#define HTTC_DS_NP_REQ_LIMIT_NONE 0
#define HTTC_DS_NP_REQ_LIMIT_1 1
#define HTTC_DS_NP_REQ_LIMIT_4 2
#define HTTC_DS_NP_REQ_LIMIT_8 3
#define HTTC_MED_PRI_BYP_CNT_SHIFT 24
#define HTTC_MED_PRI_BYP_CNT_MASK 3
#define HTTC_HI_PRI_BYP_CNT_SHIFT 26
#define HTTC_HI_PRI_BYP_CNT_MASK 3
/* Function 1 */
#define PCI_IO_BASE0 0xc0
#define PCI_IO_BASE1 0xc8
#define PCI_IO_BASE2 0xd0
#define PCI_IO_BASE3 0xd8
#define PCI_IO_BASE_VGA_EN (1 << 4)
#define PCI_IO_BASE_NO_ISA (1 << 5)
/* Function 2 */
#define DRAM_CSBASE 0x40
#define DRAM_CSMASK 0x60
#define DRAM_BANK_ADDR_MAP 0x80
#define DRAM_TIMING_LOW 0x88
#define DTL_TCL_SHIFT 0
#define DTL_TCL_MASK 0x7
#define DTL_CL_2 1
#define DTL_CL_3 2
#define DTL_CL_2_5 5
#define DTL_TRC_SHIFT 4
#define DTL_TRC_MASK 0xf
#define DTL_TRC_BASE 7
#define DTL_TRC_MIN 7
#define DTL_TRC_MAX 22
#define DTL_TRFC_SHIFT 8
#define DTL_TRFC_MASK 0xf
#define DTL_TRFC_BASE 9
#define DTL_TRFC_MIN 9
#define DTL_TRFC_MAX 24
#define DTL_TRCD_SHIFT 12
#define DTL_TRCD_MASK 0x7
#define DTL_TRCD_BASE 0
#define DTL_TRCD_MIN 2
#define DTL_TRCD_MAX 6
#define DTL_TRRD_SHIFT 16
#define DTL_TRRD_MASK 0x7
#define DTL_TRRD_BASE 0
#define DTL_TRRD_MIN 2
#define DTL_TRRD_MAX 4
#define DTL_TRAS_SHIFT 20
#define DTL_TRAS_MASK 0xf
#define DTL_TRAS_BASE 0
#define DTL_TRAS_MIN 5
#define DTL_TRAS_MAX 15
#define DTL_TRP_SHIFT 24
#define DTL_TRP_MASK 0x7
#define DTL_TRP_BASE 0
#define DTL_TRP_MIN 2
#define DTL_TRP_MAX 6
#define DTL_TWR_SHIFT 28
#define DTL_TWR_MASK 0x1
#define DTL_TWR_BASE 2
#define DTL_TWR_MIN 2
#define DTL_TWR_MAX 3
#define DRAM_TIMING_HIGH 0x8c
#define DTH_TWTR_SHIFT 0
#define DTH_TWTR_MASK 0x1
#define DTH_TWTR_BASE 1
#define DTH_TWTR_MIN 1
#define DTH_TWTR_MAX 2
#define DTH_TRWT_SHIFT 4
#define DTH_TRWT_MASK 0x7
#define DTH_TRWT_BASE 1
#define DTH_TRWT_MIN 1
#define DTH_TRWT_MAX 6
#define DTH_TREF_SHIFT 8
#define DTH_TREF_MASK 0x1f
#define DTH_TREF_100MHZ_4K 0x00
#define DTH_TREF_133MHZ_4K 0x01
#define DTH_TREF_166MHZ_4K 0x02
#define DTH_TREF_200MHZ_4K 0x03
#define DTH_TREF_100MHZ_8K 0x08
#define DTH_TREF_133MHZ_8K 0x09
#define DTH_TREF_166MHZ_8K 0x0A
#define DTH_TREF_200MHZ_8K 0x0B
#define DTH_TWCL_SHIFT 20
#define DTH_TWCL_MASK 0x7
#define DTH_TWCL_BASE 1
#define DTH_TWCL_MIN 1
#define DTH_TWCL_MAX 2
#define DRAM_CONFIG_LOW 0x90
#define DCL_DLL_Disable (1<<0)
#define DCL_D_DRV (1<<1)
#define DCL_QFC_EN (1<<2)
#define DCL_DisDqsHys (1<<3)
#define DCL_Burst2Opt (1<<5)
#define DCL_DramInit (1<<8)
#define DCL_DualDIMMen (1<<9)
#define DCL_DramEnable (1<<10)
#define DCL_MemClrStatus (1<<11)
#define DCL_ESR (1<<12)
#define DCL_SRS (1<<13)
#define DCL_128BitEn (1<<16)
#define DCL_DimmEccEn (1<<17)
#define DCL_UnBuffDimm (1<<18)
#define DCL_32ByteEn (1<<19)
#define DCL_x4DIMM_SHIFT 20
#define DCL_DisInRcvrs (1<<24)
#define DCL_BypMax_SHIFT 25
#define DCL_En2T (1<<28)
#define DCL_UpperCSMap (1<<29)
#define DRAM_CONFIG_HIGH 0x94
#define DCH_ASYNC_LAT_SHIFT 0
#define DCH_ASYNC_LAT_MASK 0xf
#define DCH_ASYNC_LAT_BASE 0
#define DCH_ASYNC_LAT_MIN 0
#define DCH_ASYNC_LAT_MAX 15
#define DCH_RDPREAMBLE_SHIFT 8
#define DCH_RDPREAMBLE_MASK 0xf
#define DCH_RDPREAMBLE_BASE ((2<<1)+0) /* 2.0 ns */
#define DCH_RDPREAMBLE_MIN ((2<<1)+0) /* 2.0 ns */
#define DCH_RDPREAMBLE_MAX ((9<<1)+1) /* 9.5 ns */
#define DCH_IDLE_LIMIT_SHIFT 16
#define DCH_IDLE_LIMIT_MASK 0x7
#define DCH_IDLE_LIMIT_0 0
#define DCH_IDLE_LIMIT_4 1
#define DCH_IDLE_LIMIT_8 2
#define DCH_IDLE_LIMIT_16 3
#define DCH_IDLE_LIMIT_32 4
#define DCH_IDLE_LIMIT_64 5
#define DCH_IDLE_LIMIT_128 6
#define DCH_IDLE_LIMIT_256 7
#define DCH_DYN_IDLE_CTR_EN (1 << 19)
#define DCH_MEMCLK_SHIFT 20
#define DCH_MEMCLK_MASK 0x7
#define DCH_MEMCLK_100MHZ 0
#define DCH_MEMCLK_133MHZ 2
#define DCH_MEMCLK_166MHZ 5
#define DCH_MEMCLK_200MHZ 7
#define DCH_MEMCLK_VALID (1 << 25)
#define DCH_MEMCLK_EN0 (1 << 26)
#define DCH_MEMCLK_EN1 (1 << 27)
#define DCH_MEMCLK_EN2 (1 << 28)
#define DCH_MEMCLK_EN3 (1 << 29)
/* Function 3 */
#define MCA_NB_CONFIG 0x44
#define MNC_ECC_EN (1 << 22)
#define MNC_CHIPKILL_EN (1 << 23)
#define SCRUB_CONTROL 0x58
#define SCRUB_NONE 0
#define SCRUB_40ns 1
#define SCRUB_80ns 2
#define SCRUB_160ns 3
#define SCRUB_320ns 4
#define SCRUB_640ns 5
#define SCRUB_1_28us 6
#define SCRUB_2_56us 7
#define SCRUB_5_12us 8
#define SCRUB_10_2us 9
#define SCRUB_20_5us 10
#define SCRUB_41_0us 11
#define SCRUB_81_9us 12
#define SCRUB_163_8us 13
#define SCRUB_327_7us 14
#define SCRUB_655_4us 15
#define SCRUB_1_31ms 16
#define SCRUB_2_62ms 17
#define SCRUB_5_24ms 18
#define SCRUB_10_49ms 19
#define SCRUB_20_97ms 20
#define SCRUB_42ms 21
#define SCRUB_84ms 22
#define SC_DRAM_SCRUB_RATE_SHFIT 0
#define SC_DRAM_SCRUB_RATE_MASK 0x1f
#define SC_L2_SCRUB_RATE_SHIFT 8
#define SC_L2_SCRUB_RATE_MASK 0x1f
#define SC_L1D_SCRUB_RATE_SHIFT 16
#define SC_L1D_SCRUB_RATE_MASK 0x1f
#define SCRUB_ADDR_LOW 0x5C
#define SCRUB_ADDR_HIGH 0x60
#define NORTHBRIDGE_CAP 0xE8
#define NBCAP_128Bit (1 << 0)
#define NBCAP_MP (1 << 1)
#define NBCAP_BIG_MP (1 << 2)
#define NBCAP_ECC (1 << 3)
#define NBCAP_CHIPKILL_ECC (1 << 4)
#define NBCAP_MEMCLK_SHIFT 5
#define NBCAP_MEMCLK_MASK 3
#define NBCAP_MEMCLK_100MHZ 3
#define NBCAP_MEMCLK_133MHZ 2
#define NBCAP_MEMCLK_166MHZ 1
#define NBCAP_MEMCLK_200MHZ 0
#define NBCAP_MEMCTRL (1 << 8)
#define LinkConnected (1 << 0)
#define InitComplete (1 << 1)
#define NonCoherent (1 << 2)
#define ConnectionPending (1 << 4)
#include "raminit.h"
//struct definitions
struct link_pair_st {
device_t udev;
uint32_t upos;
uint32_t uoffs;
device_t dev;
uint32_t pos;
uint32_t offs;
} __attribute__((packed));
struct sys_info {
uint8_t ctrl_present[NODE_NUMS];
struct mem_controller ctrl[NODE_NUMS];
uint32_t nodes;
struct link_pair_st link_pair[16];// enough? only in_conherent
uint32_t link_pair_num;
uint32_t ht_c_num;
uint32_t sbdn;
uint32_t sblk;
uint32_t sbbusn;
} __attribute__((packed));
#endif /* AMDK8_PRE_F_H */

2
src/northbridge/amd/amdk8/misc_control.c
View File

@ -169,7 +169,7 @@ static void misc_control_init(struct device *dev)
*/ */
cmd_ref = 0x04e20707; /* Registered */ cmd_ref = 0x04e20707; /* Registered */
dcl = pci_read_config32(f2_dev, DRAM_CONFIG_LOW); dcl = pci_read_config32(f2_dev, DRAM_CONFIG_LOW);
if (dcl & DCL_UnBufDimm) { if (dcl & DCL_UnBuffDimm) {
cmd_ref = 0x000D0701; /* Unbuffered */ cmd_ref = 0x000D0701; /* Unbuffered */
} }
cmd = pci_read_config32(dev, 0xd4); cmd = pci_read_config32(dev, 0xd4);

305
src/northbridge/amd/amdk8/raminit.c
View File

@ -3,9 +3,6 @@
2004.12 yhlu add D0 support 2004.12 yhlu add D0 support
2005.02 yhlu add E0 memory hole support 2005.02 yhlu add E0 memory hole support
*/ */
#if K8_REV_F_SUPPORT == 1
#include "raminit_f.c"
#else
#include <cpu/x86/mem.h> #include <cpu/x86/mem.h>
#include <cpu/x86/cache.h> #include <cpu/x86/cache.h>
@ -26,44 +23,23 @@
static void hard_reset(void); static void hard_reset(void);
#endif #endif
#if 1
static void setup_resource_map(const unsigned int *register_values, int max) static void setup_resource_map(const unsigned int *register_values, int max)
{ {
int i; int i;
// print_debug("setting up resource map...."); // printk_debug("setting up resource map....");
#if 0 for (i = 0; i < max; i += 3) {
print_debug("\r\n");
#endif
for(i = 0; i < max; i += 3) {
device_t dev; device_t dev;
unsigned where; unsigned where;
unsigned long reg; unsigned long reg;
#if 0
#if CONFIG_USE_PRINTK_IN_CAR
prink_debug("%08x <- %08x\r\n", register_values[i], register_values[i+2]);
#else
print_debug_hex32(register_values[i]);
print_debug(" <-");
print_debug_hex32(register_values[i+2]);
print_debug("\r\n");
#endif
#endif
dev = register_values[i] & ~0xfff; dev = register_values[i] & ~0xfff;
where = register_values[i] & 0xfff; where = register_values[i] & 0xfff;
reg = pci_read_config32(dev, where); reg = pci_read_config32(dev, where);
reg &= register_values[i+1]; reg &= register_values[i+1];
reg |= register_values[i+2]; reg |= register_values[i+2];
pci_write_config32(dev, where, reg); pci_write_config32(dev, where, reg);
#if 0
reg = pci_read_config32(register_values[i]);
reg &= register_values[i+1];
reg |= register_values[i+2] & ~register_values[i+1];
pci_write_config32(register_values[i], reg);
#endif
} }
// print_debug("done.\r\n"); // printk_debug("done.\n");
} }
#endif
static int controller_present(const struct mem_controller *ctrl) static int controller_present(const struct mem_controller *ctrl)
{ {
@ -78,7 +54,8 @@ static void sdram_set_registers(const struct mem_controller *ctrl)
{ {
static const unsigned int register_values[] = { static const unsigned int register_values[] = {
/* Careful set limit registers before base registers which contain the enables */ /* Careful set limit registers before base registers which
contain the enables */
/* DRAM Limit i Registers /* DRAM Limit i Registers
* F1:0x44 i = 0 * F1:0x44 i = 0
* F1:0x4C i = 1 * F1:0x4C i = 1
@ -547,48 +524,26 @@ static void sdram_set_registers(const struct mem_controller *ctrl)
int i; int i;
int max; int max;
#if 1
if (!controller_present(ctrl)) { if (!controller_present(ctrl)) {
// print_debug("No memory controller present\r\n"); // printk_debug("No memory controller present\n");
return; return;
} }
#endif printk_spew("setting up CPU%02x northbridge registers\n", ctrl->node_id);
print_spew("setting up CPU");
print_spew_hex8(ctrl->node_id);
print_spew(" northbridge registers\r\n");
max = ARRAY_SIZE(register_values); max = ARRAY_SIZE(register_values);
for(i = 0; i < max; i += 3) { for (i = 0; i < max; i += 3) {
device_t dev; device_t dev;
unsigned where; unsigned where;
unsigned long reg; unsigned long reg;
#if 0
#if CONFIG_USE_PRINTK_IN_CAR
prink_debug("%08x <- %08x\r\n", register_values[i], register_values[i+2]);
#else
print_spew_hex32(register_values[i]);
print_spew(" <-");
print_spew_hex32(register_values[i+2]);
print_spew("\r\n");
#endif
#endif
dev = (register_values[i] & ~0xfff) - PCI_DEV(0, 0x18, 0) + ctrl->f0; dev = (register_values[i] & ~0xfff) - PCI_DEV(0, 0x18, 0) + ctrl->f0;
where = register_values[i] & 0xfff; where = register_values[i] & 0xfff;
reg = pci_read_config32(dev, where); reg = pci_read_config32(dev, where);
reg &= register_values[i+1]; reg &= register_values[i+1];
reg |= register_values[i+2]; reg |= register_values[i+2];
pci_write_config32(dev, where, reg); pci_write_config32(dev, where, reg);
#if 0
reg = pci_read_config32(register_values[i]);
reg &= register_values[i+1];
reg |= register_values[i+2];
pci_write_config32(register_values[i], reg);
#endif
} }
print_spew("done.\r\n"); printk_spew("done.\n");
} }
static void hw_enable_ecc(const struct mem_controller *ctrl) static void hw_enable_ecc(const struct mem_controller *ctrl)
{ {
uint32_t dcl, nbcap; uint32_t dcl, nbcap;
@ -632,7 +587,7 @@ static int is_registered(const struct mem_controller *ctrl)
*/ */
uint32_t dcl; uint32_t dcl;
dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW); dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW);
return !(dcl & DCL_UnBufDimm); return !(dcl & DCL_UnBuffDimm);
} }
struct dimm_size { struct dimm_size {
@ -720,7 +675,7 @@ static struct dimm_size spd_get_dimm_size(unsigned device)
goto out; goto out;
val_err: val_err:
die("Bad SPD value\r\n"); die("Bad SPD value\n");
/* If an hw_error occurs report that I have no memory */ /* If an hw_error occurs report that I have no memory */
hw_err: hw_err:
sz.side1 = 0; sz.side1 = 0;
@ -776,7 +731,7 @@ static void set_dimm_size(const struct mem_controller *ctrl, struct dimm_size sz
pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+0)<<2), base0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+0)<<2), base0);
pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+1)<<2), base1); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+1)<<2), base1);
#if QRANK_DIMM_SUPPORT == 1 #if QRANK_DIMM_SUPPORT == 1
if(sz.rank == 4) { if (sz.rank == 4) {
pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+4)<<2), base0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+4)<<2), base0);
pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+5)<<2), base1); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+5)<<2), base1);
} }
@ -787,7 +742,7 @@ static void set_dimm_size(const struct mem_controller *ctrl, struct dimm_size sz
dch = pci_read_config32(ctrl->f2, DRAM_CONFIG_HIGH); dch = pci_read_config32(ctrl->f2, DRAM_CONFIG_HIGH);
dch |= DCH_MEMCLK_EN0 << index; dch |= DCH_MEMCLK_EN0 << index;
#if QRANK_DIMM_SUPPORT == 1 #if QRANK_DIMM_SUPPORT == 1
if(sz.rank == 4) { if (sz.rank == 4) {
dch |= DCH_MEMCLK_EN0 << (index + 2); dch |= DCH_MEMCLK_EN0 << (index + 2);
} }
#endif #endif
@ -809,7 +764,7 @@ static void set_dimm_map(const struct mem_controller *ctrl, struct dimm_size sz,
map = pci_read_config32(ctrl->f2, DRAM_BANK_ADDR_MAP); map = pci_read_config32(ctrl->f2, DRAM_BANK_ADDR_MAP);
map &= ~(0xf << (index * 4)); map &= ~(0xf << (index * 4));
#if QRANK_DIMM_SUPPORT == 1 #if QRANK_DIMM_SUPPORT == 1
if(sz.rank == 4) { if (sz.rank == 4) {
map &= ~(0xf << ( (index + 2) * 4)); map &= ~(0xf << ( (index + 2) * 4));
} }
#endif #endif
@ -817,10 +772,10 @@ static void set_dimm_map(const struct mem_controller *ctrl, struct dimm_size sz,
/* Make certain side1 of the dimm is at least 32MB */ /* Make certain side1 of the dimm is at least 32MB */
if (sz.side1 >= (25 +3)) { if (sz.side1 >= (25 +3)) {
if(is_cpu_pre_d0()) { if (is_cpu_pre_d0()) {
map |= (sz.side1 - (25 + 3)) << (index *4); map |= (sz.side1 - (25 + 3)) << (index *4);
#if QRANK_DIMM_SUPPORT == 1 #if QRANK_DIMM_SUPPORT == 1
if(sz.rank == 4) { if (sz.rank == 4) {
map |= (sz.side1 - (25 + 3)) << ( (index + 2) * 4); map |= (sz.side1 - (25 + 3)) << ( (index + 2) * 4);
} }
#endif #endif
@ -828,7 +783,7 @@ static void set_dimm_map(const struct mem_controller *ctrl, struct dimm_size sz,
else { else {
map |= cs_map_aa[(sz.rows - 12) * 5 + (sz.col - 8) ] << (index*4); map |= cs_map_aa[(sz.rows - 12) * 5 + (sz.col - 8) ] << (index*4);
#if QRANK_DIMM_SUPPORT == 1 #if QRANK_DIMM_SUPPORT == 1
if(sz.rank == 4) { if (sz.rank == 4) {
map |= cs_map_aa[(sz.rows - 12) * 5 + (sz.col - 8) ] << ( (index + 2) * 4); map |= cs_map_aa[(sz.rows - 12) * 5 + (sz.col - 8) ] << ( (index + 2) * 4);
} }
#endif #endif
@ -843,7 +798,7 @@ static long spd_set_ram_size(const struct mem_controller *ctrl, long dimm_mask)
{ {
int i; int i;
for(i = 0; i < DIMM_SOCKETS; i++) { for (i = 0; i < DIMM_SOCKETS; i++) {
struct dimm_size sz; struct dimm_size sz;
if (!(dimm_mask & (1 << i))) { if (!(dimm_mask & (1 << i))) {
continue; continue;
@ -881,7 +836,7 @@ static void route_dram_accesses(const struct mem_controller *ctrl,
limit_reg = 0x44 + index; limit_reg = 0x44 + index;
base_reg = 0x40 + index; base_reg = 0x40 + index;
for(device = PCI_DEV(0, 0x18, 1); device <= PCI_DEV(0, 0x1f, 1); device += PCI_DEV(0, 1, 0)) { for (device = PCI_DEV(0, 0x18, 1); device <= PCI_DEV(0, 0x1f, 1); device += PCI_DEV(0, 1, 0)) {
pci_write_config32(device, limit_reg, limit); pci_write_config32(device, limit_reg, limit);
pci_write_config32(device, base_reg, base); pci_write_config32(device, base_reg, base);
} }
@ -895,13 +850,11 @@ static void set_top_mem(unsigned tom_k, unsigned hole_startk)
} }
/* Report the amount of memory. */ /* Report the amount of memory. */
print_spew("RAM: 0x"); printk_spew("RAM: 0x%08x kB\n", tom_k);
print_spew_hex32(tom_k);
print_spew(" KB\r\n");
/* Now set top of memory */ /* Now set top of memory */
msr_t msr; msr_t msr;
if(tom_k > (4*1024*1024)) { if (tom_k > (4*1024*1024)) {
msr.lo = (tom_k & 0x003fffff) << 10; msr.lo = (tom_k & 0x003fffff) << 10;
msr.hi = (tom_k & 0xffc00000) >> 22; msr.hi = (tom_k & 0xffc00000) >> 22;
wrmsr(TOP_MEM2, msr); wrmsr(TOP_MEM2, msr);
@ -912,7 +865,7 @@ static void set_top_mem(unsigned tom_k, unsigned hole_startk)
*/ */
if (tom_k >= 0x003f0000) { if (tom_k >= 0x003f0000) {
#if HW_MEM_HOLE_SIZEK != 0 #if HW_MEM_HOLE_SIZEK != 0
if(hole_startk != 0) { if (hole_startk != 0) {
tom_k = hole_startk; tom_k = hole_startk;
} else } else
#endif #endif
@ -965,7 +918,7 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl)
chip_selects = 0; chip_selects = 0;
common_size = 0; common_size = 0;
common_cs_mode = 0; common_cs_mode = 0;
for(index = 0; index < 8; index++) { for (index = 0; index < 8; index++) {
unsigned size; unsigned size;
unsigned cs_mode; unsigned cs_mode;
uint32_t value; uint32_t value;
@ -988,12 +941,12 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl)
value = pci_read_config32(ctrl->f2, DRAM_BANK_ADDR_MAP); value = pci_read_config32(ctrl->f2, DRAM_BANK_ADDR_MAP);
cs_mode =( value >> ((index>>1)*4)) & 0xf; cs_mode =( value >> ((index>>1)*4)) & 0xf;
if(cs_mode == 0 ) continue; if (cs_mode == 0 ) continue;
if(common_cs_mode == 0) { if (common_cs_mode == 0) {
common_cs_mode = cs_mode; common_cs_mode = cs_mode;
} }
/* The size differed fail */ /* The cs_mode differed fail */
if(common_cs_mode != cs_mode) { if (common_cs_mode != cs_mode) {
return 0; return 0;
} }
} }
@ -1007,12 +960,12 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl)
} }
/* Find the bits of csbase that we need to interleave on */ /* Find the bits of csbase that we need to interleave on */
if(is_cpu_pre_d0()){ if (is_cpu_pre_d0()){
csbase_inc = 1 << csbase_low_shift[common_cs_mode]; csbase_inc = 1 << csbase_low_shift[common_cs_mode];
if(is_dual_channel(ctrl)) { if (is_dual_channel(ctrl)) {
/* Also we run out of address mask bits if we try and interleave 8 4GB dimms */ /* Also we run out of address mask bits if we try and interleave 8 4GB dimms */
if ((bits == 3) && (common_size == (1 << (32 - 3)))) { if ((bits == 3) && (common_size == (1 << (32 - 3)))) {
// print_debug("8 4GB chip selects cannot be interleaved\r\n"); // printk_debug("8 4GB chip selects cannot be interleaved\n");
return 0; return 0;
} }
csbase_inc <<=1; csbase_inc <<=1;
@ -1020,9 +973,9 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl)
} }
else { else {
csbase_inc = 1 << csbase_low_d0_shift[common_cs_mode]; csbase_inc = 1 << csbase_low_d0_shift[common_cs_mode];
if(is_dual_channel(ctrl)) { if (is_dual_channel(ctrl)) {
if( (bits==3) && (common_cs_mode > 8)) { if ( (bits==3) && (common_cs_mode > 8)) {
// print_debug("8 cs_mode>8 chip selects cannot be interleaved\r\n"); // printk_debug("8 cs_mode>8 chip selects cannot be interleaved\n");
return 0; return 0;
} }
csbase_inc <<=1; csbase_inc <<=1;
@ -1036,7 +989,7 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl)
csbase = 0 | 1; csbase = 0 | 1;
csmask = (((common_size << bits) - 1) << 21); csmask = (((common_size << bits) - 1) << 21);
csmask |= 0xfe00 & ~((csbase_inc << bits) - csbase_inc); csmask |= 0xfe00 & ~((csbase_inc << bits) - csbase_inc);
for(index = 0; index < 8; index++) { for (index = 0; index < 8; index++) {
uint32_t value; uint32_t value;
value = pci_read_config32(ctrl->f2, DRAM_CSBASE + (index << 2)); value = pci_read_config32(ctrl->f2, DRAM_CSBASE + (index << 2));
@ -1049,7 +1002,7 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl)
csbase += csbase_inc; csbase += csbase_inc;
} }
print_spew("Interleaved\r\n"); printk_spew("Interleaved\n");
/* Return the memory size in K */ /* Return the memory size in K */
return common_size << (15 + bits); return common_size << (15 + bits);
@ -1061,14 +1014,14 @@ static unsigned long order_chip_selects(const struct mem_controller *ctrl)
/* Remember which registers we have used in the high 8 bits of tom */ /* Remember which registers we have used in the high 8 bits of tom */
tom = 0; tom = 0;
for(;;) { for (;;) {
/* Find the largest remaining canidate */ /* Find the largest remaining candidate */
unsigned index, canidate; unsigned index, candidate;
uint32_t csbase, csmask; uint32_t csbase, csmask;
unsigned size; unsigned size;
csbase = 0; csbase = 0;
canidate = 0; candidate = 0;
for(index = 0; index < 8; index++) { for (index = 0; index < 8; index++) {
uint32_t value; uint32_t value;
value = pci_read_config32(ctrl->f2, DRAM_CSBASE + (index << 2)); value = pci_read_config32(ctrl->f2, DRAM_CSBASE + (index << 2));
@ -1086,11 +1039,12 @@ static unsigned long order_chip_selects(const struct mem_controller *ctrl)
if (tom & (1 << (index + 24))) { if (tom & (1 << (index + 24))) {
continue; continue;
} }
/* I have a new canidate */ /* I have a new candidate */
csbase = value; csbase = value;
canidate = index; candidate = index;
} }
/* See if I have found a new canidate */
/* See if I have found a new candidate */
if (csbase == 0) { if (csbase == 0) {
break; break;
} }
@ -1099,7 +1053,7 @@ static unsigned long order_chip_selects(const struct mem_controller *ctrl)
size = csbase >> 21; size = csbase >> 21;
/* Remember I have used this register */ /* Remember I have used this register */
tom |= (1 << (canidate + 24)); tom |= (1 << (candidate + 24));
/* Recompute the cs base register value */ /* Recompute the cs base register value */
csbase = (tom << 21) | 1; csbase = (tom << 21) | 1;
@ -1112,9 +1066,9 @@ static unsigned long order_chip_selects(const struct mem_controller *ctrl)
csmask |= 0xfe00; /* For now don't optimize */ csmask |= 0xfe00; /* For now don't optimize */
/* Write the new base register */ /* Write the new base register */
pci_write_config32(ctrl->f2, DRAM_CSBASE + (canidate << 2), csbase); pci_write_config32(ctrl->f2, DRAM_CSBASE + (candidate << 2), csbase);
/* Write the new mask register */ /* Write the new mask register */
pci_write_config32(ctrl->f2, DRAM_CSMASK + (canidate << 2), csmask); pci_write_config32(ctrl->f2, DRAM_CSMASK + (candidate << 2), csmask);
} }
/* Return the memory size in K */ /* Return the memory size in K */
@ -1127,7 +1081,7 @@ unsigned long memory_end_k(const struct mem_controller *ctrl, int max_node_id)
unsigned end_k; unsigned end_k;
/* Find the last memory address used */ /* Find the last memory address used */
end_k = 0; end_k = 0;
for(node_id = 0; node_id < max_node_id; node_id++) { for (node_id = 0; node_id < max_node_id; node_id++) {
uint32_t limit, base; uint32_t limit, base;
unsigned index; unsigned index;
index = node_id << 3; index = node_id << 3;
@ -1149,12 +1103,14 @@ static void order_dimms(const struct mem_controller *ctrl)
read_option(CMOS_VSTART_interleave_chip_selects, CMOS_VLEN_interleave_chip_selects, 1) != 0) { read_option(CMOS_VSTART_interleave_chip_selects, CMOS_VLEN_interleave_chip_selects, 1) != 0) {
tom_k = interleave_chip_selects(ctrl); tom_k = interleave_chip_selects(ctrl);
} else { } else {
print_debug("Interleaving disabled\r\n"); printk_debug("Interleaving disabled\n");
tom_k = 0; tom_k = 0;
} }
if (!tom_k) { if (!tom_k) {
tom_k = order_chip_selects(ctrl); tom_k = order_chip_selects(ctrl);
} }
/* Compute the memory base address */ /* Compute the memory base address */
base_k = memory_end_k(ctrl, ctrl->node_id); base_k = memory_end_k(ctrl, ctrl->node_id);
tom_k += base_k; tom_k += base_k;
@ -1164,16 +1120,15 @@ static void order_dimms(const struct mem_controller *ctrl)
static long disable_dimm(const struct mem_controller *ctrl, unsigned index, long dimm_mask) static long disable_dimm(const struct mem_controller *ctrl, unsigned index, long dimm_mask)
{ {
print_debug("disabling dimm"); printk_debug("disabling dimm %02x\n", index);
print_debug_hex8(index);
print_debug("\r\n");
pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+0)<<2), 0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+0)<<2), 0);
pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+1)<<2), 0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+1)<<2), 0);
dimm_mask &= ~(1 << index); dimm_mask &= ~(1 << index);
return dimm_mask; return dimm_mask;
} }
static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl, long dimm_mask) static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl,
long dimm_mask)
{ {
int i; int i;
int registered; int registered;
@ -1182,7 +1137,7 @@ static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl, long
uint32_t dcl; uint32_t dcl;
unbuffered = 0; unbuffered = 0;
registered = 0; registered = 0;
for(i = 0; (i < DIMM_SOCKETS); i++) { for (i = 0; (i < DIMM_SOCKETS); i++) {
int value; int value;
if (!(dimm_mask & (1 << i))) { if (!(dimm_mask & (1 << i))) {
continue; continue;
@ -1191,6 +1146,7 @@ static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl, long
if (value < 0) { if (value < 0) {
return -1; return -1;
} }
/* Registered dimm ? */ /* Registered dimm ? */
if (value & (1 << 1)) { if (value & (1 << 1)) {
registered = 1; registered = 1;
@ -1205,10 +1161,10 @@ static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl, long
} }
dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW); dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW);
dcl &= ~DCL_UnBufDimm; dcl &= ~DCL_UnBuffDimm;
if (unbuffered) { if (unbuffered) {
if ((has_dualch) && (!is_cpu_pre_d0())) { if ((has_dualch) && (!is_cpu_pre_d0())) {
dcl |= DCL_UnBufDimm; /* set DCL_DualDIMMen too? */ dcl |= DCL_UnBuffDimm; /* set DCL_DualDIMMen too? */
/* set DCL_En2T if you have non-equal DDR mem types! */ /* set DCL_En2T if you have non-equal DDR mem types! */
@ -1217,17 +1173,17 @@ static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl, long
dcl |= DCL_UpperCSMap; dcl |= DCL_UpperCSMap;
} }
} else { } else {
dcl |= DCL_UnBufDimm; dcl |= DCL_UnBuffDimm;
} }
} }
pci_write_config32(ctrl->f2, DRAM_CONFIG_LOW, dcl); pci_write_config32(ctrl->f2, DRAM_CONFIG_LOW, dcl);
#if 0
if (is_registered(ctrl)) { if (is_registered(ctrl)) {
print_debug("Registered\r\n"); printk_spew("Registered\n");
} else { } else {
print_debug("Unbuffered\r\n"); printk_spew("Unbuffered\n");
} }
#endif
return dimm_mask; return dimm_mask;
} }
@ -1236,7 +1192,7 @@ static unsigned int spd_detect_dimms(const struct mem_controller *ctrl)
unsigned dimm_mask; unsigned dimm_mask;
int i; int i;
dimm_mask = 0; dimm_mask = 0;
for(i = 0; i < DIMM_SOCKETS; i++) { for (i = 0; i < DIMM_SOCKETS; i++) {
int byte; int byte;
unsigned device; unsigned device;
device = ctrl->channel0[i]; device = ctrl->channel0[i];
@ -1294,7 +1250,7 @@ static long spd_enable_2channels(const struct mem_controller *ctrl, long dimm_ma
if (!(nbcap & NBCAP_128Bit)) { if (!(nbcap & NBCAP_128Bit)) {
goto single_channel; goto single_channel;
} }
for(i = 0; (i < 4) && (ctrl->channel0[i]); i++) { for (i = 0; (i < 4) && (ctrl->channel0[i]); i++) {
unsigned device0, device1; unsigned device0, device1;
int value0, value1; int value0, value1;
int j; int j;
@ -1304,7 +1260,7 @@ static long spd_enable_2channels(const struct mem_controller *ctrl, long dimm_ma
} }
device0 = ctrl->channel0[i]; device0 = ctrl->channel0[i];
device1 = ctrl->channel1[i]; device1 = ctrl->channel1[i];
for(j = 0; j < ARRAY_SIZE(addresses); j++) { for (j = 0; j < ARRAY_SIZE(addresses); j++) {
unsigned addr; unsigned addr;
addr = addresses[j]; addr = addresses[j];
value0 = spd_read_byte(device0, addr); value0 = spd_read_byte(device0, addr);
@ -1320,7 +1276,7 @@ static long spd_enable_2channels(const struct mem_controller *ctrl, long dimm_ma
} }
} }
} }
print_spew("Enabling dual channel memory\r\n"); printk_spew("Enabling dual channel memory\n");
uint32_t dcl; uint32_t dcl;
dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW); dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW);
dcl &= ~DCL_32ByteEn; dcl &= ~DCL_32ByteEn;
@ -1350,7 +1306,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
{ {
static const struct mem_param speed[] = { static const struct mem_param speed[] = {
{ {
.name = "100Mhz\r\n", .name = "100Mhz",
.cycle_time = 0xa0, .cycle_time = 0xa0,
.divisor = (10 <<1), .divisor = (10 <<1),
.tRC = 0x46, .tRC = 0x46,
@ -1364,7 +1320,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
.rdpreamble = { ((9 << 1) + 0), ((9 << 1) + 0), ((9 << 1) + 0), ((9 << 1) + 0) } .rdpreamble = { ((9 << 1) + 0), ((9 << 1) + 0), ((9 << 1) + 0), ((9 << 1) + 0) }
}, },
{ {
.name = "133Mhz\r\n", .name = "133Mhz",
.cycle_time = 0x75, .cycle_time = 0x75,
.divisor = (7<<1)+1, .divisor = (7<<1)+1,
.tRC = 0x41, .tRC = 0x41,
@ -1378,7 +1334,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
.rdpreamble = { ((8 << 1) + 0), ((7 << 1) + 0), ((7 << 1) + 1), ((7 << 1) + 0) } .rdpreamble = { ((8 << 1) + 0), ((7 << 1) + 0), ((7 << 1) + 1), ((7 << 1) + 0) }
}, },
{ {
.name = "166Mhz\r\n", .name = "166Mhz",
.cycle_time = 0x60, .cycle_time = 0x60,
.divisor = (6<<1), .divisor = (6<<1),
.tRC = 0x3C, .tRC = 0x3C,
@ -1392,7 +1348,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
.rdpreamble = { ((7 << 1) + 1), ((6 << 1) + 0), ((6 << 1) + 1), ((6 << 1) + 0) } .rdpreamble = { ((7 << 1) + 1), ((6 << 1) + 0), ((6 << 1) + 1), ((6 << 1) + 0) }
}, },
{ {
.name = "200Mhz\r\n", .name = "200Mhz",
.cycle_time = 0x50, .cycle_time = 0x50,
.divisor = (5<<1), .divisor = (5<<1),
.tRC = 0x37, .tRC = 0x37,
@ -1410,7 +1366,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
}, },
}; };
const struct mem_param *param; const struct mem_param *param;
for(param = &speed[0]; param->cycle_time ; param++) { for (param = &speed[0]; param->cycle_time ; param++) {
if (min_cycle_time > (param+1)->cycle_time) { if (min_cycle_time > (param+1)->cycle_time) {
break; break;
} }
@ -1418,10 +1374,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
if (!param->cycle_time) { if (!param->cycle_time) {
die("min_cycle_time to low"); die("min_cycle_time to low");
} }
print_spew(param->name); printk_spew("%s\n", param->name);
#ifdef DRAM_MIN_CYCLE_TIME
print_debug(param->name);
#endif
return param; return param;
} }
@ -1458,7 +1411,7 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
/* Compute the least latency with the fastest clock supported /* Compute the least latency with the fastest clock supported
* by both the memory controller and the dimms. * by both the memory controller and the dimms.
*/ */
for(i = 0; i < DIMM_SOCKETS; i++) { for (i = 0; i < DIMM_SOCKETS; i++) {
int new_cycle_time, new_latency; int new_cycle_time, new_latency;
int index; int index;
int latencies; int latencies;
@ -1489,7 +1442,7 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
latency = log2(latencies) -2; latency = log2(latencies) -2;
/* Loop through and find a fast clock with a low latency */ /* Loop through and find a fast clock with a low latency */
for(index = 0; index < 3; index++, latency++) { for (index = 0; index < 3; index++, latency++) {
int spd_value; int spd_value;
if ((latency < 2) || (latency > 4) || if ((latency < 2) || (latency > 4) ||
(!(latencies & (1 << latency)))) { (!(latencies & (1 << latency)))) {
@ -1522,7 +1475,7 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
* any that cannot support the selected memclk and cas latency. * any that cannot support the selected memclk and cas latency.
*/ */
for(i = 0; (i < 4) && (ctrl->channel0[i]); i++) { for (i = 0; (i < 4) && (ctrl->channel0[i]); i++) {
int latencies; int latencies;
int latency; int latency;
int index; int index;
@ -1530,6 +1483,7 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
if (!(dimm_mask & (1 << i))) { if (!(dimm_mask & (1 << i))) {
continue; continue;
} }
latencies = spd_read_byte(ctrl->channel0[i], 18); latencies = spd_read_byte(ctrl->channel0[i], 18);
if (latencies < 0) goto hw_error; if (latencies < 0) goto hw_error;
if (latencies == 0) { if (latencies == 0) {
@ -1540,7 +1494,7 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
latency = log2(latencies) -2; latency = log2(latencies) -2;
/* Walk through searching for the selected latency */ /* Walk through searching for the selected latency */
for(index = 0; index < 3; index++, latency++) { for (index = 0; index < 3; index++, latency++) {
if (!(latencies & (1 << latency))) { if (!(latencies & (1 << latency))) {
continue; continue;
} }
@ -1569,21 +1523,21 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
#if 0 #if 0
//down speed for full load 4 rank support //down speed for full load 4 rank support
#if QRANK_DIMM_SUPPORT #if QRANK_DIMM_SUPPORT
if(dimm_mask == (3|(3<<DIMM_SOCKETS)) ) { if (dimm_mask == (3|(3<<DIMM_SOCKETS)) ) {
int ranks = 4; int ranks = 4;
for(i = 0; (i < 4) && (ctrl->channel0[i]); i++) { for (i = 0; (i < 4) && (ctrl->channel0[i]); i++) {
int val; int val;
if (!(dimm_mask & (1 << i))) { if (!(dimm_mask & (1 << i))) {
continue; continue;
} }
val = spd_read_byte(ctrl->channel0[i], 5); val = spd_read_byte(ctrl->channel0[i], 5);
if(val!=ranks) { if (val!=ranks) {
ranks = val; ranks = val;
break; break;
} }
} }
if(ranks==4) { if (ranks==4) {
if(min_cycle_time <= 0x50 ) { if (min_cycle_time <= 0x50 ) {
min_cycle_time = 0x60; min_cycle_time = 0x60;
} }
} }
@ -1599,8 +1553,8 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
value &= ~(DCH_MEMCLK_MASK << DCH_MEMCLK_SHIFT); value &= ~(DCH_MEMCLK_MASK << DCH_MEMCLK_SHIFT);
#if 0 #if 0
/* Improves DQS centering by correcting for case when core speed multiplier and MEMCLK speed result in odd clock divisor, by selecting the next lowest memory speed, required only at DDR400 and higher speeds with certain DIMM loadings ---- cheating???*/ /* Improves DQS centering by correcting for case when core speed multiplier and MEMCLK speed result in odd clock divisor, by selecting the next lowest memory speed, required only at DDR400 and higher speeds with certain DIMM loadings ---- cheating???*/
if(!is_cpu_pre_e0()) { if (!is_cpu_pre_e0()) {
if(min_cycle_time==0x50) { if (min_cycle_time==0x50) {
value |= 1<<31; value |= 1<<31;
} }
} }
@ -1610,6 +1564,7 @@ static struct spd_set_memclk_result spd_set_memclk(const struct mem_controller *
pci_write_config32(ctrl->f2, DRAM_CONFIG_HIGH, value); pci_write_config32(ctrl->f2, DRAM_CONFIG_HIGH, value);
static const unsigned latencies[] = { DTL_CL_2, DTL_CL_2_5, DTL_CL_3 }; static const unsigned latencies[] = { DTL_CL_2, DTL_CL_2_5, DTL_CL_3 };
/* Update DRAM Timing Low with our selected cas latency */ /* Update DRAM Timing Low with our selected cas latency */
value = pci_read_config32(ctrl->f2, DRAM_TIMING_LOW); value = pci_read_config32(ctrl->f2, DRAM_TIMING_LOW);
value &= ~(DTL_TCL_MASK << DTL_TCL_SHIFT); value &= ~(DTL_TCL_MASK << DTL_TCL_SHIFT);
@ -1852,7 +1807,7 @@ static int update_dimm_x4(const struct mem_controller *ctrl, const struct mem_pa
dimm = 1<<(DCL_x4DIMM_SHIFT+i); dimm = 1<<(DCL_x4DIMM_SHIFT+i);
#if QRANK_DIMM_SUPPORT == 1 #if QRANK_DIMM_SUPPORT == 1
if(rank==4) { if (rank==4) {
dimm |= 1<<(DCL_x4DIMM_SHIFT+i+2); dimm |= 1<<(DCL_x4DIMM_SHIFT+i+2);
} }
#endif #endif
@ -1886,7 +1841,7 @@ static int count_dimms(const struct mem_controller *ctrl)
int dimms; int dimms;
unsigned index; unsigned index;
dimms = 0; dimms = 0;
for(index = 0; index < 8; index += 2) { for (index = 0; index < 8; index += 2) {
uint32_t csbase; uint32_t csbase;
csbase = pci_read_config32(ctrl->f2, (DRAM_CSBASE + (index << 2))); csbase = pci_read_config32(ctrl->f2, (DRAM_CSBASE + (index << 2)));
if (csbase & 1) { if (csbase & 1) {
@ -1941,7 +1896,7 @@ static void set_Trwt(const struct mem_controller *ctrl, const struct mem_param *
clocks = param->dtl_trwt[lat][mtype]; clocks = param->dtl_trwt[lat][mtype];
if ((clocks < DTH_TRWT_MIN) || (clocks > DTH_TRWT_MAX)) { if ((clocks < DTH_TRWT_MIN) || (clocks > DTH_TRWT_MAX)) {
die("Unknown Trwt\r\n"); die("Unknown Trwt\n");
} }
dth = pci_read_config32(ctrl->f2, DRAM_TIMING_HIGH); dth = pci_read_config32(ctrl->f2, DRAM_TIMING_HIGH);
@ -1976,7 +1931,7 @@ static void set_read_preamble(const struct mem_controller *ctrl, const struct me
slots = 0; slots = 0;
for(i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
if (ctrl->channel0[i]) { if (ctrl->channel0[i]) {
slots += 1; slots += 1;
} }
@ -2061,7 +2016,7 @@ static long spd_set_dram_timing(const struct mem_controller *ctrl, const struct
int i; int i;
init_Tref(ctrl, param); init_Tref(ctrl, param);
for(i = 0; i < DIMM_SOCKETS; i++) { for (i = 0; i < DIMM_SOCKETS; i++) {
int rc; int rc;
if (!(dimm_mask & (1 << i))) { if (!(dimm_mask & (1 << i))) {
continue; continue;
@ -2114,7 +2069,7 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
long dimm_mask; long dimm_mask;
#if 1 #if 1
if (!controller_present(ctrl)) { if (!controller_present(ctrl)) {
// print_debug("No memory controller present\r\n"); // printk_debug("No memory controller present\n");
return; return;
} }
#endif #endif
@ -2122,7 +2077,7 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
activate_spd_rom(ctrl); activate_spd_rom(ctrl);
dimm_mask = spd_detect_dimms(ctrl); dimm_mask = spd_detect_dimms(ctrl);
if (!(dimm_mask & ((1 << DIMM_SOCKETS) - 1))) { if (!(dimm_mask & ((1 << DIMM_SOCKETS) - 1))) {
print_debug("No memory for this cpu\r\n"); printk_debug("No memory for this cpu\n");
return; return;
} }
dimm_mask = spd_enable_2channels(ctrl, dimm_mask); dimm_mask = spd_enable_2channels(ctrl, dimm_mask);
@ -2146,7 +2101,7 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
return; return;
hw_spd_err: hw_spd_err:
/* Unrecoverable error reading SPD data */ /* Unrecoverable error reading SPD data */
print_err("SPD error - reset\r\n"); print_err("SPD error - reset\n");
hard_reset(); hard_reset();
return; return;
} }
@ -2164,30 +2119,30 @@ static uint32_t hoist_memory(int controllers, const struct mem_controller *ctrl,
carry_over = (4*1024*1024) - hole_startk; carry_over = (4*1024*1024) - hole_startk;
for(ii=controllers - 1;ii>i;ii--) { for (ii=controllers - 1;ii>i;ii--) {
base = pci_read_config32(ctrl[0].f1, 0x40 + (ii << 3)); base = pci_read_config32(ctrl[0].f1, 0x40 + (ii << 3));
if ((base & ((1<<1)|(1<<0))) != ((1<<1)|(1<<0))) { if ((base & ((1<<1)|(1<<0))) != ((1<<1)|(1<<0))) {
continue; continue;
} }
limit = pci_read_config32(ctrl[0].f1, 0x44 + (ii << 3)); limit = pci_read_config32(ctrl[0].f1, 0x44 + (ii << 3));
for(j = 0; j < controllers; j++) { for (j = 0; j < controllers; j++) {
pci_write_config32(ctrl[j].f1, 0x44 + (ii << 3), limit + (carry_over << 2)); pci_write_config32(ctrl[j].f1, 0x44 + (ii << 3), limit + (carry_over << 2));
pci_write_config32(ctrl[j].f1, 0x40 + (ii << 3), base + (carry_over << 2)); pci_write_config32(ctrl[j].f1, 0x40 + (ii << 3), base + (carry_over << 2));
} }
} }
limit = pci_read_config32(ctrl[0].f1, 0x44 + (i << 3)); limit = pci_read_config32(ctrl[0].f1, 0x44 + (i << 3));
for(j = 0; j < controllers; j++) { for (j = 0; j < controllers; j++) {
pci_write_config32(ctrl[j].f1, 0x44 + (i << 3), limit + (carry_over << 2)); pci_write_config32(ctrl[j].f1, 0x44 + (i << 3), limit + (carry_over << 2));
} }
dev = ctrl[i].f1; dev = ctrl[i].f1;
base = pci_read_config32(dev, 0x40 + (i << 3)); base = pci_read_config32(dev, 0x40 + (i << 3));
basek = (base & 0xffff0000) >> 2; basek = (base & 0xffff0000) >> 2;
if(basek == hole_startk) { if (basek == hole_startk) {
//don't need set memhole here, because hole off set will be 0, overflow //don't need set memhole here, because hole off set will be 0, overflow
//so need to change base reg instead, new basek will be 4*1024*1024 //so need to change base reg instead, new basek will be 4*1024*1024
base &= 0x0000ffff; base &= 0x0000ffff;
base |= (4*1024*1024)<<2; base |= (4*1024*1024)<<2;
for(j = 0; j < controllers; j++) { for (j = 0; j < controllers; j++) {
pci_write_config32(ctrl[j].f1, 0x40 + (i<<3), base); pci_write_config32(ctrl[j].f1, 0x40 + (i<<3), base);
} }
} }
@ -2218,7 +2173,7 @@ static void set_hw_mem_hole(int controllers, const struct mem_controller *ctrl)
* we need to decrease it. * we need to decrease it.
*/ */
uint32_t basek_pri; uint32_t basek_pri;
for(i=0; i<controllers; i++) { for (i=0; i<controllers; i++) {
uint32_t base; uint32_t base;
unsigned base_k; unsigned base_k;
base = pci_read_config32(ctrl[0].f1, 0x40 + (i << 3)); base = pci_read_config32(ctrl[0].f1, 0x40 + (i << 3));
@ -2226,7 +2181,7 @@ static void set_hw_mem_hole(int controllers, const struct mem_controller *ctrl)
continue; continue;
} }
base_k = (base & 0xffff0000) >> 2; base_k = (base & 0xffff0000) >> 2;
if(base_k == hole_startk) { if (base_k == hole_startk) {
/* decrease memory hole startk to make sure it is /* decrease memory hole startk to make sure it is
* in the middle of the previous node * in the middle of the previous node
*/ */
@ -2238,7 +2193,7 @@ static void set_hw_mem_hole(int controllers, const struct mem_controller *ctrl)
#endif #endif
/* Find node number that needs the memory hole configured */ /* Find node number that needs the memory hole configured */
for(i=0; i<controllers; i++) { for (i=0; i<controllers; i++) {
uint32_t base, limit; uint32_t base, limit;
unsigned base_k, limit_k; unsigned base_k, limit_k;
base = pci_read_config32(ctrl[0].f1, 0x40 + (i << 3)); base = pci_read_config32(ctrl[0].f1, 0x40 + (i << 3));
@ -2272,11 +2227,11 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
/* Error if I don't have memory */ /* Error if I don't have memory */
if (memory_end_k(ctrl, controllers) == 0) { if (memory_end_k(ctrl, controllers) == 0) {
die("No memory\r\n"); die("No memory\n");
} }
/* Before enabling memory start the memory clocks */ /* Before enabling memory start the memory clocks */
for(i = 0; i < controllers; i++) { for (i = 0; i < controllers; i++) {
uint32_t dch; uint32_t dch;
if (!controller_present(ctrl + i)) if (!controller_present(ctrl + i))
continue; continue;
@ -2294,12 +2249,11 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
} }
} }
/* We need to wait a minimum of 20 MEMCLKS to enable the InitDram */
/* And if necessary toggle the the reset on the dimms by hand */ /* And if necessary toggle the the reset on the dimms by hand */
memreset(controllers, ctrl); memreset(controllers, ctrl);
/* We need to wait a mimmium of 20 MEMCLKS to enable the InitDram */ for (i = 0; i < controllers; i++) {
for(i = 0; i < controllers; i++) {
uint32_t dcl, dch; uint32_t dcl, dch;
if (!controller_present(ctrl + i)) if (!controller_present(ctrl + i))
continue; continue;
@ -2313,7 +2267,7 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
dcl = pci_read_config32(ctrl[i].f2, DRAM_CONFIG_LOW); dcl = pci_read_config32(ctrl[i].f2, DRAM_CONFIG_LOW);
if (dcl & DCL_DimmEccEn) { if (dcl & DCL_DimmEccEn) {
uint32_t mnc; uint32_t mnc;
print_spew("ECC enabled\r\n"); printk_spew("ECC enabled\n");
mnc = pci_read_config32(ctrl[i].f3, MCA_NB_CONFIG); mnc = pci_read_config32(ctrl[i].f3, MCA_NB_CONFIG);
mnc |= MNC_ECC_EN; mnc |= MNC_ECC_EN;
if (dcl & DCL_128BitEn) { if (dcl & DCL_128BitEn) {
@ -2329,9 +2283,9 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
dcl &= ~DCL_QFC_EN; dcl &= ~DCL_QFC_EN;
dcl |= DCL_DramInit; dcl |= DCL_DramInit;
pci_write_config32(ctrl[i].f2, DRAM_CONFIG_LOW, dcl); pci_write_config32(ctrl[i].f2, DRAM_CONFIG_LOW, dcl);
} }
for(i = 0; i < controllers; i++) {
for (i = 0; i < controllers; i++) {
uint32_t dcl, dch; uint32_t dcl, dch;
if (!controller_present(ctrl + i)) if (!controller_present(ctrl + i))
continue; continue;
@ -2341,18 +2295,17 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
continue; continue;
} }
print_debug("Initializing memory: "); printk_debug("Initializing memory: ");
int loops = 0; int loops = 0;
do { do {
dcl = pci_read_config32(ctrl[i].f2, DRAM_CONFIG_LOW); dcl = pci_read_config32(ctrl[i].f2, DRAM_CONFIG_LOW);
loops += 1; loops++;
if ((loops & 1023) == 0) { if ((loops & 1023) == 0) {
print_debug("."); printk_debug(".");
} }
} while(((dcl & DCL_DramInit) != 0) && (loops < TIMEOUT_LOOPS)); } while(((dcl & DCL_DramInit) != 0) && (loops < TIMEOUT_LOOPS));
if (loops >= TIMEOUT_LOOPS) { if (loops >= TIMEOUT_LOOPS) {
print_debug(" failed\r\n"); printk_debug(" failed\n");
continue; continue;
} }
@ -2365,13 +2318,13 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
} while(((dcl & DCL_MemClrStatus) == 0) || ((dcl & DCL_DramEnable) == 0) ); } while(((dcl & DCL_MemClrStatus) == 0) || ((dcl & DCL_DramEnable) == 0) );
} }
print_debug(" done\r\n"); printk_debug(" done\n");
} }
#if HW_MEM_HOLE_SIZEK != 0 #if HW_MEM_HOLE_SIZEK != 0
// init hw mem hole here // init hw mem hole here
/* DramHoleValid bit only can be set after MemClrStatus is set by Hardware */ /* DramHoleValid bit only can be set after MemClrStatus is set by Hardware */
if(!is_cpu_pre_e0()) if (!is_cpu_pre_e0())
set_hw_mem_hole(controllers, ctrl); set_hw_mem_hole(controllers, ctrl);
#endif #endif
@ -2384,34 +2337,19 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
5. for node interleaving we need to set mem hole to every node ( need recalcute hole offset in f0 for every node) 5. for node interleaving we need to set mem hole to every node ( need recalcute hole offset in f0 for every node)
*/ */
#if USE_DCACHE_RAM == 0
/* Make certain the first 1M of memory is intialized */
print_debug("Clearing initial memory region: ");
/* Use write combine caching while we setup the first 1M */
cache_lbmem(MTRR_TYPE_WRCOMB);
/* clear memory 1meg */
clear_memory((void *)0, CONFIG_LB_MEM_TOPK << 10);
/* The first 1M is now setup, use it */
cache_lbmem(MTRR_TYPE_WRBACK);
print_debug(" done\r\n");
#endif
} }
#if USE_DCACHE_RAM == 1
static void set_sysinfo_in_ram(unsigned val) static void set_sysinfo_in_ram(unsigned val)
{ {
} }
static void fill_mem_ctrl(int controllers, struct mem_controller *ctrl_a, const uint16_t *spd_addr) static void fill_mem_ctrl(int controllers, struct mem_controller *ctrl_a,
const uint16_t *spd_addr)
{ {
int i; int i;
int j; int j;
struct mem_controller *ctrl; struct mem_controller *ctrl;
for(i=0;i<controllers; i++) { for (i=0;i<controllers; i++) {
ctrl = &ctrl_a[i]; ctrl = &ctrl_a[i];
ctrl->node_id = i; ctrl->node_id = i;
ctrl->f0 = PCI_DEV(0, 0x18+i, 0); ctrl->f0 = PCI_DEV(0, 0x18+i, 0);
@ -2419,14 +2357,11 @@ static void fill_mem_ctrl(int controllers, struct mem_controller *ctrl_a, const
ctrl->f2 = PCI_DEV(0, 0x18+i, 2); ctrl->f2 = PCI_DEV(0, 0x18+i, 2);
ctrl->f3 = PCI_DEV(0, 0x18+i, 3); ctrl->f3 = PCI_DEV(0, 0x18+i, 3);
if(spd_addr == (void *)0) continue; if (spd_addr == (void *)0) continue;
for(j=0;j<DIMM_SOCKETS;j++) { for (j=0;j<DIMM_SOCKETS;j++) {
ctrl->channel0[j] = spd_addr[(i*2+0)*DIMM_SOCKETS + j]; ctrl->channel0[j] = spd_addr[(i*2+0)*DIMM_SOCKETS + j];
ctrl->channel1[j] = spd_addr[(i*2+1)*DIMM_SOCKETS + j]; ctrl->channel1[j] = spd_addr[(i*2+1)*DIMM_SOCKETS + j];
} }
} }
} }
#endif
#endif

57
src/northbridge/amd/amdk8/raminit_f.c
View File

@ -712,11 +712,9 @@ static void sdram_set_registers(const struct mem_controller *ctrl, struct sys_in
reg |= register_values[i+2]; reg |= register_values[i+2];
pci_write_config32(dev, where, reg); pci_write_config32(dev, where, reg);
} }
printk_spew("done.\n"); printk_spew("done.\n");
} }
static int is_dual_channel(const struct mem_controller *ctrl) static int is_dual_channel(const struct mem_controller *ctrl)
{ {
uint32_t dcl; uint32_t dcl;
@ -724,7 +722,6 @@ static int is_dual_channel(const struct mem_controller *ctrl)
return dcl & DCL_Width128; return dcl & DCL_Width128;
} }
static int is_opteron(const struct mem_controller *ctrl) static int is_opteron(const struct mem_controller *ctrl)
{ {
/* Test to see if I am an Opteron. /* Test to see if I am an Opteron.
@ -738,7 +735,6 @@ static int is_opteron(const struct mem_controller *ctrl)
return !!(nbcap & NBCAP_128Bit); return !!(nbcap & NBCAP_128Bit);
} }
static int is_registered(const struct mem_controller *ctrl) static int is_registered(const struct mem_controller *ctrl)
{ {
/* Test to see if we are dealing with registered SDRAM. /* Test to see if we are dealing with registered SDRAM.
@ -834,7 +830,8 @@ static void spd_get_dimm_size(unsigned device, struct dimm_size *sz)
static void set_dimm_size(const struct mem_controller *ctrl, static void set_dimm_size(const struct mem_controller *ctrl,
struct dimm_size *sz, unsigned index, struct mem_info *meminfo) struct dimm_size *sz, unsigned index,
struct mem_info *meminfo)
{ {
uint32_t base0, base1; uint32_t base0, base1;
@ -1009,14 +1006,13 @@ static long spd_set_ram_size(const struct mem_controller *ctrl,
return -1; /* Report SPD error */ return -1; /* Report SPD error */
} }
set_dimm_size(ctrl, sz, i, meminfo); set_dimm_size(ctrl, sz, i, meminfo);
set_dimm_cs_map (ctrl, sz, i, meminfo); set_dimm_cs_map(ctrl, sz, i, meminfo);
} }
return meminfo->dimm_mask; return meminfo->dimm_mask;
} }
static void route_dram_accesses(const struct mem_controller *ctrl, static void route_dram_accesses(const struct mem_controller *ctrl,
unsigned long base_k, unsigned long limit_k) unsigned long base_k, unsigned long limit_k)
{ {
/* Route the addresses to the controller node */ /* Route the addresses to the controller node */
unsigned node_id; unsigned node_id;
@ -1045,7 +1041,6 @@ static void route_dram_accesses(const struct mem_controller *ctrl,
} }
} }
static void set_top_mem(unsigned tom_k, unsigned hole_startk) static void set_top_mem(unsigned tom_k, unsigned hole_startk)
{ {
/* Error if I don't have memory */ /* Error if I don't have memory */
@ -1056,9 +1051,9 @@ static void set_top_mem(unsigned tom_k, unsigned hole_startk)
/* Report the amount of memory. */ /* Report the amount of memory. */
printk_debug("RAM: 0x%08x kB\n", tom_k); printk_debug("RAM: 0x%08x kB\n", tom_k);
/* Now set top of memory */
msr_t msr; msr_t msr;
if (tom_k > (4*1024*1024)) { if (tom_k > (4*1024*1024)) {
/* Now set top of memory */
msr.lo = (tom_k & 0x003fffff) << 10; msr.lo = (tom_k & 0x003fffff) << 10;
msr.hi = (tom_k & 0xffc00000) >> 22; msr.hi = (tom_k & 0xffc00000) >> 22;
wrmsr(TOP_MEM2, msr); wrmsr(TOP_MEM2, msr);
@ -1161,7 +1156,6 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl,
csbase_inc <<=1; csbase_inc <<=1;
} }
/* Compute the initial values for csbase and csbask. /* Compute the initial values for csbase and csbask.
* In csbase just set the enable bit and the base to zero. * In csbase just set the enable bit and the base to zero.
* In csmask set the mask bits for the size and page level interleave. * In csmask set the mask bits for the size and page level interleave.
@ -1189,6 +1183,7 @@ static unsigned long interleave_chip_selects(const struct mem_controller *ctrl,
/* Return the memory size in K */ /* Return the memory size in K */
return common_size << ((27-10) + bits); return common_size << ((27-10) + bits);
} }
static unsigned long order_chip_selects(const struct mem_controller *ctrl) static unsigned long order_chip_selects(const struct mem_controller *ctrl)
{ {
unsigned long tom; unsigned long tom;
@ -1278,7 +1273,6 @@ unsigned long memory_end_k(const struct mem_controller *ctrl, int max_node_id)
return end_k; return end_k;
} }
static void order_dimms(const struct mem_controller *ctrl, static void order_dimms(const struct mem_controller *ctrl,
struct mem_info *meminfo) struct mem_info *meminfo)
{ {
@ -1303,7 +1297,6 @@ static void order_dimms(const struct mem_controller *ctrl,
set_top_mem(tom_k, 0); set_top_mem(tom_k, 0);
} }
static long disable_dimm(const struct mem_controller *ctrl, unsigned index, static long disable_dimm(const struct mem_controller *ctrl, unsigned index,
struct mem_info *meminfo) struct mem_info *meminfo)
{ {
@ -1326,7 +1319,6 @@ static long disable_dimm(const struct mem_controller *ctrl, unsigned index,
return meminfo->dimm_mask; return meminfo->dimm_mask;
} }
static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl, static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl,
struct mem_info *meminfo) struct mem_info *meminfo)
{ {
@ -1380,17 +1372,14 @@ static long spd_handle_unbuffered_dimms(const struct mem_controller *ctrl,
} }
pci_write_config32(ctrl->f2, DRAM_CONFIG_LOW, dcl); pci_write_config32(ctrl->f2, DRAM_CONFIG_LOW, dcl);
#if 1
if (meminfo->is_registered) { if (meminfo->is_registered) {
printk_debug("Registered\n"); printk_spew("Registered\n");
} else { } else {
printk_debug("Unbuffered\n"); printk_spew("Unbuffered\n");
} }
#endif
return meminfo->dimm_mask; return meminfo->dimm_mask;
} }
static unsigned int spd_detect_dimms(const struct mem_controller *ctrl) static unsigned int spd_detect_dimms(const struct mem_controller *ctrl)
{ {
unsigned dimm_mask; unsigned dimm_mask;
@ -1624,7 +1613,7 @@ static const struct mem_param *get_mem_param(unsigned min_cycle_time)
if (!param->cycle_time) { if (!param->cycle_time) {
die("min_cycle_time to low"); die("min_cycle_time to low");
} }
printk_debug("%s\n", param->name); printk_spew("%s\n", param->name);
return param; return param;
} }
@ -2088,7 +2077,6 @@ static int update_dimm_TT_1_4(const struct mem_controller *ctrl, const struct me
return 1; return 1;
} }
static int update_dimm_Trcd(const struct mem_controller *ctrl, static int update_dimm_Trcd(const struct mem_controller *ctrl,
const struct mem_param *param, int i, long dimm_mask) const struct mem_param *param, int i, long dimm_mask)
{ {
@ -2126,17 +2114,14 @@ static int update_dimm_Tras(const struct mem_controller *ctrl, const struct mem_
if (clocks < DTL_TRAS_MIN) { if (clocks < DTL_TRAS_MIN) {
clocks = DTL_TRAS_MIN; clocks = DTL_TRAS_MIN;
} }
if (clocks > DTL_TRAS_MAX) { if (clocks > DTL_TRAS_MAX) {
return 0; return 0;
} }
dtl = pci_read_config32(ctrl->f2, DRAM_TIMING_LOW); dtl = pci_read_config32(ctrl->f2, DRAM_TIMING_LOW);
old_clocks = ((dtl >> DTL_TRAS_SHIFT) & DTL_TRAS_MASK) + DTL_TRAS_BASE; old_clocks = ((dtl >> DTL_TRAS_SHIFT) & DTL_TRAS_MASK) + DTL_TRAS_BASE;
if (old_clocks >= clocks) { // someone did it? if (old_clocks >= clocks) { // someone did it?
return 1; return 1;
} }
dtl &= ~(DTL_TRAS_MASK << DTL_TRAS_SHIFT); dtl &= ~(DTL_TRAS_MASK << DTL_TRAS_SHIFT);
dtl |= ((clocks - DTL_TRAS_BASE) << DTL_TRAS_SHIFT); dtl |= ((clocks - DTL_TRAS_BASE) << DTL_TRAS_SHIFT);
pci_write_config32(ctrl->f2, DRAM_TIMING_LOW, dtl); pci_write_config32(ctrl->f2, DRAM_TIMING_LOW, dtl);
@ -2201,7 +2186,6 @@ static int update_dimm_Tref(const struct mem_controller *ctrl,
return 1; return 1;
} }
static void set_4RankRDimm(const struct mem_controller *ctrl, static void set_4RankRDimm(const struct mem_controller *ctrl,
const struct mem_param *param, struct mem_info *meminfo) const struct mem_param *param, struct mem_info *meminfo)
{ {
@ -2235,7 +2219,6 @@ static void set_4RankRDimm(const struct mem_controller *ctrl,
#endif #endif
} }
static uint32_t get_extra_dimm_mask(const struct mem_controller *ctrl, static uint32_t get_extra_dimm_mask(const struct mem_controller *ctrl,
struct mem_info *meminfo) struct mem_info *meminfo)
{ {
@ -2363,7 +2346,6 @@ static void set_DramTerm(const struct mem_controller *ctrl,
pci_write_config32(ctrl->f2, DRAM_CONFIG_LOW, dcl); pci_write_config32(ctrl->f2, DRAM_CONFIG_LOW, dcl);
} }
static void set_ecc(const struct mem_controller *ctrl, static void set_ecc(const struct mem_controller *ctrl,
const struct mem_param *param, struct mem_info *meminfo) const struct mem_param *param, struct mem_info *meminfo)
{ {
@ -2456,19 +2438,16 @@ static void set_Twrwr(const struct mem_controller *ctrl, const struct mem_param
set_TT(ctrl, param, DRAM_TIMING_HIGH, DTH_TWRWR_SHIFT, DTH_TWRWR_MASK,DTH_TWRWR_BASE, DTH_TWRWR_MIN, DTH_TWRWR_MAX, param->Twrwr, "Twrwr"); set_TT(ctrl, param, DRAM_TIMING_HIGH, DTH_TWRWR_SHIFT, DTH_TWRWR_MASK,DTH_TWRWR_BASE, DTH_TWRWR_MIN, DTH_TWRWR_MAX, param->Twrwr, "Twrwr");
} }
static void set_Trdrd(const struct mem_controller *ctrl, const struct mem_param *param) static void set_Trdrd(const struct mem_controller *ctrl, const struct mem_param *param)
{ {
set_TT(ctrl, param, DRAM_TIMING_HIGH, DTH_TRDRD_SHIFT, DTH_TRDRD_MASK,DTH_TRDRD_BASE, DTH_TRDRD_MIN, DTH_TRDRD_MAX, param->Trdrd, "Trdrd"); set_TT(ctrl, param, DRAM_TIMING_HIGH, DTH_TRDRD_SHIFT, DTH_TRDRD_MASK,DTH_TRDRD_BASE, DTH_TRDRD_MIN, DTH_TRDRD_MAX, param->Trdrd, "Trdrd");
} }
static void set_DcqBypassMax(const struct mem_controller *ctrl, const struct mem_param *param) static void set_DcqBypassMax(const struct mem_controller *ctrl, const struct mem_param *param)
{ {
set_TT(ctrl, param, DRAM_CONFIG_HIGH, DCH_DcqBypassMax_SHIFT, DCH_DcqBypassMax_MASK,DCH_DcqBypassMax_BASE, DCH_DcqBypassMax_MIN, DCH_DcqBypassMax_MAX, param->DcqByPassMax, "DcqBypassMax"); // value need to be in CMOS set_TT(ctrl, param, DRAM_CONFIG_HIGH, DCH_DcqBypassMax_SHIFT, DCH_DcqBypassMax_MASK,DCH_DcqBypassMax_BASE, DCH_DcqBypassMax_MIN, DCH_DcqBypassMax_MAX, param->DcqByPassMax, "DcqBypassMax"); // value need to be in CMOS
} }
static void set_Tfaw(const struct mem_controller *ctrl, const struct mem_param *param, struct mem_info *meminfo) static void set_Tfaw(const struct mem_controller *ctrl, const struct mem_param *param, struct mem_info *meminfo)
{ {
static const uint8_t faw_1k[] = {8, 10, 13, 14}; static const uint8_t faw_1k[] = {8, 10, 13, 14};
@ -2486,10 +2465,8 @@ static void set_Tfaw(const struct mem_controller *ctrl, const struct mem_param *
} }
set_TT(ctrl, param, DRAM_CONFIG_HIGH, DCH_FourActWindow_SHIFT, DCH_FourActWindow_MASK, DCH_FourActWindow_BASE, DCH_FourActWindow_MIN, DCH_FourActWindow_MAX, faw, "FourActWindow"); set_TT(ctrl, param, DRAM_CONFIG_HIGH, DCH_FourActWindow_SHIFT, DCH_FourActWindow_MASK, DCH_FourActWindow_BASE, DCH_FourActWindow_MIN, DCH_FourActWindow_MAX, faw, "FourActWindow");
} }
static void set_max_async_latency(const struct mem_controller *ctrl, const struct mem_param *param) static void set_max_async_latency(const struct mem_controller *ctrl, const struct mem_param *param)
{ {
uint32_t dch; uint32_t dch;
@ -2507,7 +2484,6 @@ static void set_max_async_latency(const struct mem_controller *ctrl, const struc
pci_write_config32(ctrl->f2, DRAM_CONFIG_HIGH, dch); pci_write_config32(ctrl->f2, DRAM_CONFIG_HIGH, dch);
} }
static void set_SlowAccessMode(const struct mem_controller *ctrl) static void set_SlowAccessMode(const struct mem_controller *ctrl)
{ {
uint32_t dch; uint32_t dch;
@ -2519,7 +2495,6 @@ static void set_SlowAccessMode(const struct mem_controller *ctrl)
pci_write_config32(ctrl->f2, DRAM_CONFIG_HIGH, dch); pci_write_config32(ctrl->f2, DRAM_CONFIG_HIGH, dch);
} }
/* /*
DRAM_OUTPUT_DRV_COMP_CTRL 0, 0x20 DRAM_OUTPUT_DRV_COMP_CTRL 0, 0x20
DRAM_ADDR_TIMING_CTRL 04, 0x24 DRAM_ADDR_TIMING_CTRL 04, 0x24
@ -2724,7 +2699,6 @@ static void set_RDqsEn(const struct mem_controller *ctrl,
#endif #endif
} }
static void set_idle_cycle_limit(const struct mem_controller *ctrl, static void set_idle_cycle_limit(const struct mem_controller *ctrl,
const struct mem_param *param) const struct mem_param *param)
{ {
@ -2737,14 +2711,12 @@ static void set_idle_cycle_limit(const struct mem_controller *ctrl,
pci_write_config32(ctrl->f2, DRAM_CTRL_MISC, dcm); pci_write_config32(ctrl->f2, DRAM_CTRL_MISC, dcm);
} }
static void set_RdWrQByp(const struct mem_controller *ctrl, static void set_RdWrQByp(const struct mem_controller *ctrl,
const struct mem_param *param) const struct mem_param *param)
{ {
set_TT(ctrl, param, DRAM_CTRL_MISC, DCM_RdWrQByp_SHIFT, DCM_RdWrQByp_MASK,0, 0, 3, 2, "RdWrQByp"); set_TT(ctrl, param, DRAM_CTRL_MISC, DCM_RdWrQByp_SHIFT, DCM_RdWrQByp_MASK,0, 0, 3, 2, "RdWrQByp");
} }
static long spd_set_dram_timing(const struct mem_controller *ctrl, static long spd_set_dram_timing(const struct mem_controller *ctrl,
const struct mem_param *param, const struct mem_param *param,
struct mem_info *meminfo) struct mem_info *meminfo)
@ -3058,14 +3030,6 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl,
/* We need to wait a minimum of 20 MEMCLKS to enable the InitDram */ /* We need to wait a minimum of 20 MEMCLKS to enable the InitDram */
memreset(controllers, ctrl); memreset(controllers, ctrl);
#if 0
printk_debug("prepare to InitDram:");
for (i=0; i<10; i++) {
printk_debug("%08x", i);
print_debug("\b\b\b\b\b\b\b\b");
}
printk_debug("\n");
#endif
/* lets override the rest of the routine */ /* lets override the rest of the routine */
if (suspend) { if (suspend) {
@ -3241,9 +3205,8 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl,
} }
static void fill_mem_ctrl(int controllers, struct mem_controller *ctrl_a, static void fill_mem_ctrl(int controllers, struct mem_controller *ctrl_a,
const uint16_t *spd_addr) const uint16_t *spd_addr)
{ {
int i; int i;
int j; int j;