From 172bcc835f0d214444398c57a0ca9eddd2941ecf Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Sun, 26 Jul 2020 18:15:06 +0200 Subject: [PATCH] soc/intel/cannonlake: Configure SataPwrOptEnable only if SATA is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I522dc7287c85b304f6fc62c0c554e4d062c3c61c Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/43914 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Michael Niewöhner --- src/soc/intel/cannonlake/fsp_params.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c index 46d582102f..0853cca488 100644 --- a/src/soc/intel/cannonlake/fsp_params.c +++ b/src/soc/intel/cannonlake/fsp_params.c @@ -292,15 +292,14 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd) else { params->SataEnable = dev->enabled; params->SataMode = config->SataMode; + params->SataPwrOptEnable = config->satapwroptimize; params->SataSalpSupport = config->SataSalpSupport; memcpy(params->SataPortsEnable, config->SataPortsEnable, sizeof(params->SataPortsEnable)); memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp, sizeof(params->SataPortsDevSlp)); - memcpy(params->SataPortsHotPlug, config->SataPortsHotPlug, sizeof(params->SataPortsHotPlug)); - #if CONFIG(SOC_INTEL_COMETLAKE) memcpy(params->SataPortsDevSlpResetConfig, config->SataPortsDevSlpResetConfig, @@ -550,9 +549,6 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd) params->FastPkgCRampDisableSa = config->FastPkgCRampDisableSa; params->FastPkgCRampDisableFivr = config->FastPkgCRampDisableFivr; - /* Power Optimizer */ - params->SataPwrOptEnable = config->satapwroptimize; - /* Disable PCH ACPI timer */ params->EnableTcoTimer = !config->PmTimerDisabled;