mainboards: Drop stale comment about enumerate_buses()
There is no enumerate_buses() today and also no trace of it in our repository. Also, in current terms, mainboard_enable() is called as the very first thing in our enumeration so the comment seems misleading. Change-Id: Iae620f83c8166c1cfc8b9fb9ef4a7025987bf1be Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79003 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
parent
2a87ef1eca
commit
173922fc88
|
@ -3,9 +3,6 @@
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <soc/int15.h>
|
#include <soc/int15.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
/* Install custom int15 handler for VGA OPROM */
|
/* Install custom int15 handler for VGA OPROM */
|
||||||
|
|
|
@ -20,10 +20,6 @@ static void mainboard_reserve_resources(struct device *dev)
|
||||||
res->flags = IORESOURCE_IRQ | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
|
res->flags = IORESOURCE_IRQ | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
mainboard_reserve_resources(dev);
|
mainboard_reserve_resources(dev);
|
||||||
|
|
|
@ -20,10 +20,6 @@ static void mainboard_reserve_resources(struct device *dev)
|
||||||
res->flags = IORESOURCE_IRQ | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
|
res->flags = IORESOURCE_IRQ | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
mainboard_reserve_resources(dev);
|
mainboard_reserve_resources(dev);
|
||||||
|
|
|
@ -40,8 +40,6 @@ static void mainboard_init(struct device *dev)
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_TXT_STRETCH, 0, 3);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_TXT_STRETCH, 0, 3);
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses(). Is there no mainboard_init()?
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -4,9 +4,6 @@
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
#include <southbridge/intel/bd82x6x/pch.h>
|
#include <southbridge/intel/bd82x6x/pch.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_NONE,
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_NONE,
|
||||||
|
|
|
@ -21,9 +21,6 @@ static int mainboard_smbios_data(struct device *dev, int *handle,
|
||||||
return variant_smbios_data(dev, handle, current);
|
return variant_smbios_data(dev, handle, current);
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -18,9 +18,6 @@ static void mainboard_init(struct device *dev)
|
||||||
lan_init();
|
lan_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -248,9 +248,6 @@ static int butterfly_onboard_smbios_data(struct device *dev, int *handle,
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -8,10 +8,6 @@ static void mainboard_init(struct device *dev)
|
||||||
mainboard_ec_init();
|
mainboard_ec_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -87,10 +87,6 @@ static unsigned long mainboard_write_acpi_tables(
|
||||||
return end_addr;
|
return end_addr;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -8,9 +8,6 @@ static void mainboard_init(struct device *dev)
|
||||||
lan_init();
|
lan_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -162,9 +162,6 @@ static int link_onboard_smbios_data(struct device *dev, int *handle,
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -53,9 +53,6 @@ static int parrot_onboard_smbios_data(struct device *dev, int *handle,
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -45,9 +45,6 @@ static int mainboard_smbios_data(struct device *dev, int *handle,
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -58,9 +58,6 @@ static int mainboard_smbios_data(struct device *dev, int *handle,
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -35,9 +35,6 @@ static void mainboard_init(struct device *dev)
|
||||||
pci_write_config8(ethernet_dev, 0x81, 0x01);
|
pci_write_config8(ethernet_dev, 0x81, 0x01);
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -4,9 +4,6 @@
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
#include "superio_hwm.h"
|
#include "superio_hwm.h"
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 3);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 3);
|
||||||
|
|
|
@ -12,9 +12,6 @@ void mainboard_suspend_resume(void)
|
||||||
apm_control(APM_CNT_FINALIZE);
|
apm_control(APM_CNT_FINALIZE);
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
||||||
|
|
|
@ -4,9 +4,6 @@
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
#include <southbridge/intel/bd82x6x/pch.h>
|
#include <southbridge/intel/bd82x6x/pch.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
||||||
|
|
|
@ -12,10 +12,6 @@ static void mainboard_init(struct device *dev)
|
||||||
mainboard_ec_init();
|
mainboard_ec_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -73,10 +73,6 @@ static unsigned long mainboard_write_acpi_tables(
|
||||||
return end_addr;
|
return end_addr;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -9,10 +9,6 @@ static void mainboard_init(struct device *dev)
|
||||||
mainboard_ec_init();
|
mainboard_ec_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* mainboard_enable is executed as first thing after
|
|
||||||
* enumerate_buses().
|
|
||||||
*/
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -3,9 +3,6 @@
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
||||||
|
|
|
@ -121,9 +121,6 @@ static void hwm_setup(void)
|
||||||
pnp_write_hwm5_index(hwm_base, 0x40, 0x01); /* Init, but no SMI# */
|
pnp_write_hwm5_index(hwm_base, 0x40, 0x01); /* Init, but no SMI# */
|
||||||
}
|
}
|
||||||
|
|
||||||
/* mainboard_enable is executed as first thing after */
|
|
||||||
/* enumerate_buses(). */
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 3);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 3);
|
||||||
|
|
|
@ -138,10 +138,6 @@ static int int15_handler(void)
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
/* mainboard_enable is executed as first thing after */
|
|
||||||
/* enumerate_buses(). */
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
#if CONFIG(PCI_OPTION_ROM_RUN_YABEL) || \
|
#if CONFIG(PCI_OPTION_ROM_RUN_YABEL) || \
|
||||||
|
|
|
@ -3,8 +3,6 @@
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
|
|
||||||
/* mainboard_enable is executed as first thing after
|
|
||||||
enumerate_buses(). */
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
||||||
|
|
|
@ -3,9 +3,6 @@
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
||||||
|
|
|
@ -3,9 +3,6 @@
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
||||||
|
|
|
@ -3,9 +3,6 @@
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
|
||||||
|
|
|
@ -64,9 +64,6 @@ static int lumpy_onboard_smbios_data(struct device *dev, int *handle,
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
dev->ops->init = mainboard_init;
|
dev->ops->init = mainboard_init;
|
||||||
|
|
|
@ -4,9 +4,6 @@
|
||||||
#include <drivers/intel/gma/int15.h>
|
#include <drivers/intel/gma/int15.h>
|
||||||
#include <southbridge/intel/bd82x6x/pch.h>
|
#include <southbridge/intel/bd82x6x/pch.h>
|
||||||
|
|
||||||
// mainboard_enable is executed as first thing after
|
|
||||||
// enumerate_buses().
|
|
||||||
|
|
||||||
static void mainboard_enable(struct device *dev)
|
static void mainboard_enable(struct device *dev)
|
||||||
{
|
{
|
||||||
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
|
||||||
|
|
Loading…
Reference in New Issue