GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/lapic: Drop parallel_cpu_init inside LEGACY_SMP_INIT 

It was not used, platforms should move away from LEGACY_SMP_INIT
instead of maintaining this.

Change-Id: Id89ec4bb0bdc056ac328f31397e4fab02742e444
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55204
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Kyösti Mälkki 2021-05-29 22:22:57 +03:00
parent 75363a93f1
commit 176989a48b
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/cpu/x86/lapic/lapic_cpu_init.c
View File

@ -21,8 +21,6 @@
#include <stdlib.h> #include <stdlib.h>
#include <thread.h> #include <thread.h>
const int parallel_cpu_init = false;
/* This is a lot more paranoid now, since Linux can NOT handle /* This is a lot more paranoid now, since Linux can NOT handle
* being told there is a CPU when none exists. So any errors * being told there is a CPU when none exists. So any errors
* will return 0, meaning no CPU. * will return 0, meaning no CPU.
@ -392,7 +390,6 @@ asmlinkage void secondary_cpu_init(unsigned int index)
{ {
atomic_inc(&active_cpus); atomic_inc(&active_cpus);
if (!parallel_cpu_init)
spin_lock(&start_cpu_lock); spin_lock(&start_cpu_lock);
#ifdef __SSE3__ #ifdef __SSE3__
@ -407,7 +404,6 @@ asmlinkage void secondary_cpu_init(unsigned int index)
#endif #endif
cpu_initialize(index); cpu_initialize(index);
if (!parallel_cpu_init)
spin_unlock(&start_cpu_lock); spin_unlock(&start_cpu_lock);
atomic_dec(&active_cpus); atomic_dec(&active_cpus);
@ -424,9 +420,6 @@ static void start_other_cpus(struct bus *cpu_bus, struct device *bsp_cpu)
if (cpu->path.type != DEVICE_PATH_APIC) if (cpu->path.type != DEVICE_PATH_APIC)
continue; continue;
if (parallel_cpu_init && (cpu == bsp_cpu))
continue;
if (!cpu->enabled) if (!cpu->enabled)
continue; continue;
@ -438,7 +431,6 @@ static void start_other_cpus(struct bus *cpu_bus, struct device *bsp_cpu)
printk(BIOS_ERR, "CPU 0x%02x would not start!\n", printk(BIOS_ERR, "CPU 0x%02x would not start!\n",
cpu->path.apic.apic_id); cpu->path.apic.apic_id);
if (!parallel_cpu_init)
udelay(10); udelay(10);
} }
@ -542,14 +534,10 @@ void initialize_cpus(struct bus *cpu_bus)
if (!CONFIG(SERIALIZED_SMM_INITIALIZATION)) if (!CONFIG(SERIALIZED_SMM_INITIALIZATION))
smm_init(); smm_init();
/* start all aps at first, so we can init ECC all together */
if (is_smp_boot() && parallel_cpu_init)
start_other_cpus(cpu_bus, info->cpu);
/* Initialize the bootstrap processor */ /* Initialize the bootstrap processor */
cpu_initialize(0); cpu_initialize(0);
if (is_smp_boot() && !parallel_cpu_init) if (is_smp_boot())
start_other_cpus(cpu_bus, info->cpu); start_other_cpus(cpu_bus, info->cpu);
/* Now wait the rest of the cpus stop*/ /* Now wait the rest of the cpus stop*/