From 17cd905828427d58b67618784cfeefc31d695bdd Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 13 Nov 2020 16:38:30 +0100 Subject: [PATCH] util/cbfstool/amdcompress: fix argument requirement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The compress and uncompress options don't have arguments and shouldn't consume the next token. So replace required_argument with no_argument for the two options. Change-Id: Ib9b190f2cf606109f82a65d00327871d6ffb7082 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/47573 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Marshall Dawson --- util/cbfstool/amdcompress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/cbfstool/amdcompress.c b/util/cbfstool/amdcompress.c index ad6a039ee9..76089ea340 100644 --- a/util/cbfstool/amdcompress.c +++ b/util/cbfstool/amdcompress.c @@ -29,9 +29,9 @@ static const char *optstring = "i:o:cm:uh"; static struct option long_options[] = { {"infile", required_argument, 0, 'i' }, {"outfile", required_argument, 0, 'o' }, - {"compress", required_argument, 0, 'c' }, + {"compress", no_argument, 0, 'c' }, {"maxsize", required_argument, 0, 'm' }, - {"uncompress", required_argument, 0, 'u' }, + {"uncompress", no_argument, 0, 'u' }, {"help", no_argument, 0, 'h' }, };