GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/psp: Remove unknown section flags 

The `d` flag used in .section is unknown in LLVM/clang 17 and fails
the build. It is also not documented in the ARM compiler manual.
The GNU assembler supports the `d` flag but it also seems to compile
without.

ARM compiler manual: https://developer.arm.com/documentation/101754/0621/armclang-Reference/armclang-Integrated-Assembler/Section-directives
GNU compiler manual: https://sourceware.org/binutils/docs/as/Section.html

`coreboot.rom` does not change between compiling a google skyrim board
with or without this patch. However the debug info for the following
three files in the build directory changes with this patch:
* build/verstage/vendorcode/amd/fsp/mendocino/bl_uapp/bl_uapp_end.o
* build/cbfs/fallback/verstage.elf
* build/cbfs/fallback/verstage.debug

Change-Id: Ie3735b72349b0cfdd27364a39bcdda390af7bfa5
Signed-off-by: Lennart Eichhorn <lennarteichhorn@googlemail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79366
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Lennart Eichhorn 2023-12-01 18:17:39 +01:00 committed by Felix Held
parent f55b711c07
commit 182e56964e
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vendorcode/amd/fsp/cezanne/bl_uapp/bl_uapp_end.S
View File

@ -29,7 +29,7 @@
.arm .arm
.global LastBytes .global LastBytes
.section PSP_FOOTER_DATA, "ad", %note .section PSP_FOOTER_DATA, "a", %note
.balign 64 .balign 64
// Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte // Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte

2
src/vendorcode/amd/fsp/common/bl_uapp/bl_uapp_end.S
View File

@ -29,7 +29,7 @@
.arm .arm
.global LastBytes .global LastBytes
.section PSP_FOOTER_DATA, "ad", %note .section PSP_FOOTER_DATA, "a", %note
.balign 64 .balign 64
// Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte // Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte

2
src/vendorcode/amd/fsp/mendocino/bl_uapp/bl_uapp_end.S
View File

@ -29,7 +29,7 @@
.arm .arm
.global LastBytes .global LastBytes
.section PSP_FOOTER_DATA, "ad", %note .section PSP_FOOTER_DATA, "a", %note
.balign 64 .balign 64
// Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte // Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte

2
src/vendorcode/amd/fsp/picasso/bl_uapp/bl_uapp_end.S
View File

@ -29,7 +29,7 @@
.arm .arm
.global LastBytes .global LastBytes
.section PSP_FOOTER_DATA, "ad", %note .section PSP_FOOTER_DATA, "a", %note
.balign 64 .balign 64
// Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte // Note: this is used for determining the size of the binary. It is 64 byte aligned and 64 byte