From 186c2f9abcd7d98a15ae6b8f92f3fd7cfa41d54e Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Tue, 17 Dec 2019 16:59:47 +0100 Subject: [PATCH] util/nvramtool: Create nvramtool object directories earlier The existing rule created a potential race condition between creating the directory and putting files in there, so use our existing infrastructure for directory creation instead. Change-Id: If52a9f558c7d9ce85f71ba53232594699c9d357a Signed-off-by: Patrick Georgi Reviewed-on: https://review.coreboot.org/c/coreboot/+/37798 Reviewed-by: Angel Pons Reviewed-by: Nico Huber Reviewed-by: Paul Menzel Reviewed-by: Jett Rink Tested-by: build bot (Jenkins) --- util/nvramtool/Makefile.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/util/nvramtool/Makefile.inc b/util/nvramtool/Makefile.inc index 48f6d86557..697428906e 100644 --- a/util/nvramtool/Makefile.inc +++ b/util/nvramtool/Makefile.inc @@ -36,8 +36,7 @@ NVRAMTOOLLDFLAGS += -lregex -lwsock32 nvramtoolobj += win32mmap.o endif -$(objutil)/nvramtool $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli: - mkdir -p $@ +additional-dirs += $(objutil)/nvramtool/accessors $(objutil)/nvramtool/cli $(objutil)/nvramtool/%.o: $(top)/util/nvramtool/%.c printf " HOSTCC $(subst $(objutil)/,,$(@))\n"