GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfstool: remove incorrect section size check 

I was overzealous in checking the section size with respect
to the file size. That check makes no sense as the section only
deals with link sizes -- not on-disk sizes. Remove the check as
it doesn't make any sense.

Change-Id: I348e7847ae3a50badc22693439614f813462445a
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/5384
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
This commit is contained in:
Aaron Durbin 2014-03-13 08:52:17 -05:00 committed by Aaron Durbin
parent ed2bcaa731
commit 19a11d6fe9
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
util/cbfstool/elfheaders.c
View File

@ -306,11 +306,6 @@ shdr_read(const struct buffer *in, Elf64_Ehdr *ehdr, struct xdr *xdr, int bit64)
for (i = 0; i < ehdr->e_shnum; i++) { for (i = 0; i < ehdr->e_shnum; i++) {
DEBUG("Parsing section %d\n", i); DEBUG("Parsing section %d\n", i);
elf_shdr(&b, &shdr[i], ehdr->e_shentsize, xdr, bit64); elf_shdr(&b, &shdr[i], ehdr->e_shentsize, xdr, bit64);
/* Ensure the contents are valid within the elf file. */
if (check_size(in, shdr[i].sh_offset, shdr[i].sh_size,
"section contents"))
return NULL;
} }
return shdr; return shdr;