From 19b3102910f813e71efaa61c86e683afd48899a1 Mon Sep 17 00:00:00 2001 From: Zheng Bao Date: Sat, 30 Oct 2021 21:30:34 +0800 Subject: [PATCH] amd/lpc: Remove the weak function BUG=b:140165023 Change-Id: Idb4613dc08c8dee6c92b4dabb39c2f5c189471aa Signed-off-by: Zheng Bao Reviewed-on: https://review.coreboot.org/c/coreboot/+/58770 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/soc/amd/common/block/include/amdblocks/lpc.h | 2 -- src/soc/amd/common/block/lpc/lpc.c | 5 ----- 2 files changed, 7 deletions(-) diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index daa51f1145..09eafb8b07 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -141,8 +141,6 @@ /* Clear all decoding to the LPC bus and erase any range registers associated * with the enable bits. */ void lpc_disable_decodes(void); -/* LPC is typically enabled very early, but this function is last opportunity */ -void soc_late_lpc_bridge_enable(void); void lpc_enable_port80(void); void lpc_enable_pci_port80(void); void lpc_enable_decode(uint32_t decodes); diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index 365c14dbf3..496816b0f3 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -20,9 +20,6 @@ #include #include -/* Most systems should have already enabled the bridge */ -void __weak soc_late_lpc_bridge_enable(void) { } - static void setup_serirq(void) { u8 byte; @@ -41,8 +38,6 @@ static void lpc_init(struct device *dev) { u8 byte; - soc_late_lpc_bridge_enable(); - /* Initialize isa dma */ isa_dma_init();