From 19cbe03534b955cc3c3e3505e66f852184005140 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Thu, 6 Jun 2019 11:35:43 -0600 Subject: [PATCH] nb/amd/amdmct/mct_ddr3: Remove duplicate conditional This check is already performed at the beginning of dct_ddr_voltage_index(). Change-Id: Ia73025333c152f14249afb16d05f66791e69e7cb Signed-off-by: Jacob Garber Found-by: Coverity CID 1347322, 1347323 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33264 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 945ae8274b..fa8c71447b 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3071,11 +3071,6 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat, */ uint8_t dimm_event_l_pin_support = 0; - if (pDCTstat->DIMMValidDCT[dct] == 0) - ddr_voltage_index = 1; - else - ddr_voltage_index = dct_ddr_voltage_index(pDCTstat, dct); - ddr_voltage_index = dct_ddr_voltage_index(pDCTstat, dct); max_dimms_installable = mctGet_NVbits(NV_MAX_DIMMS_PER_CH);