From 1a14375a8830ec1521fca1eec4047ee14cc25d15 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 27 Dec 2017 20:52:04 +0100 Subject: [PATCH] superio/ite: add missing pnp_conf_mode fields in ops struct This fixes the bug that the LDNs on the affected SIO chips didn't get configured, since the config mode wasn't entered. Change-Id: Ic468847571e164e4e1280428f08fc067b724464e Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/23004 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/superio/ite/it8671f/superio.c | 2 ++ src/superio/ite/it8718f/superio.c | 2 ++ src/superio/ite/it8721f/superio.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/superio/ite/it8671f/superio.c b/src/superio/ite/it8671f/superio.c index f69a06c45f..4fa24de4b5 100644 --- a/src/superio/ite/it8671f/superio.c +++ b/src/superio/ite/it8671f/superio.c @@ -18,6 +18,7 @@ #include #include #include +#include #include "it8671f.h" static void init(struct device *dev) @@ -45,6 +46,7 @@ static struct device_operations ops = { .enable_resources = pnp_enable_resources, .enable = pnp_enable, .init = init, + .ops_pnp_mode = &pnp_conf_mode_870155_aa, }; /* TODO: FDC, PP, KBCM. */ diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c index b4ac679ff6..ca2fedb6d3 100644 --- a/src/superio/ite/it8718f/superio.c +++ b/src/superio/ite/it8718f/superio.c @@ -19,6 +19,7 @@ #include #include #include +#include #include "it8718f.h" #include "chip.h" @@ -59,6 +60,7 @@ static struct device_operations ops = { .enable_resources = pnp_enable_resources, .enable = pnp_enable, .init = init, + .ops_pnp_mode = &pnp_conf_mode_870155_aa, }; /* TODO: IR. */ diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c index 9838659505..cd01f30c72 100644 --- a/src/superio/ite/it8721f/superio.c +++ b/src/superio/ite/it8721f/superio.c @@ -19,6 +19,7 @@ #include #include #include +#include #include "it8721f.h" static void init(struct device *dev) @@ -50,6 +51,7 @@ static struct device_operations ops = { .enable_resources = pnp_enable_resources, .enable = pnp_enable, .init = init, + .ops_pnp_mode = &pnp_conf_mode_870155_aa, }; /* TODO: FDC, PP, EC, KBCM, IR. */