From 1a148753ef93b037cdff5f8d31a9045ddd2a20c3 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Mon, 27 Feb 2023 21:07:26 +0100 Subject: [PATCH] soc/amd/stoneyridge/acpi: introduce and use ACPI_SCI_IRQ definition IRQ9 is used as ACPI SCI IRQ, so add a define for that and use it in the code like it is also done in the other SoCs in soc/amd. Signed-off-by: Felix Held Change-Id: Iddb51d70c15ab1d7088f62b61e22510bd1b30b1e Reviewed-on: https://review.coreboot.org/c/coreboot/+/73320 Reviewed-by: Matt DeVillier Reviewed-by: Martin Roth Tested-by: build bot (Jenkins) --- src/soc/amd/stoneyridge/acpi.c | 4 ++-- src/soc/amd/stoneyridge/include/soc/acpi.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index 81dfc14807..e2fb2e344f 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -40,7 +40,7 @@ unsigned long acpi_fill_madt(unsigned long current) MP_IRQ_TRIGGER_DEFAULT | MP_IRQ_POLARITY_DEFAULT); /* SCI IRQ type override */ current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, - MP_BUS_ISA, 9, 9, + MP_BUS_ISA, ACPI_SCI_IRQ, ACPI_SCI_IRQ, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW); return current; @@ -54,7 +54,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) { printk(BIOS_DEBUG, "pm_base: 0x%04x\n", ACPI_IO_BASE); - fadt->sci_int = 9; /* IRQ 09 - ACPI SCI */ + fadt->sci_int = ACPI_SCI_IRQ; if (permanent_smi_handler()) { fadt->smi_cmd = APM_CNT; diff --git a/src/soc/amd/stoneyridge/include/soc/acpi.h b/src/soc/amd/stoneyridge/include/soc/acpi.h index 21ffd5fbdc..302416e113 100644 --- a/src/soc/amd/stoneyridge/include/soc/acpi.h +++ b/src/soc/amd/stoneyridge/include/soc/acpi.h @@ -6,6 +6,8 @@ #include #include +#define ACPI_SCI_IRQ 9 + #if CONFIG(STONEYRIDGE_LEGACY_FREE) #define FADT_BOOT_ARCH ACPI_FADT_LEGACY_FREE #else