GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/i82801bx: Minor log fixes in IDE driver 

Two issues:
1. without config, there were two NULL derefs
2. output for "Secondary" looked at ide0_enable

Change-Id: I34ddbc0f9b27226981ccbc237e3d59e522076d55
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/6989
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
This commit is contained in:
Patrick Georgi 2014-09-29 19:40:51 +02:00 committed by Patrick Georgi
parent 667c7a3b23
commit 1ab4495204
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/southbridge/intel/i82801bx/ide.c
View File

@ -39,7 +39,7 @@ static void ide_init(struct device *dev)
if (!conf || conf->ide0_enable)
reg16 |= IDE_DECODE_ENABLE;
printk(BIOS_DEBUG, "IDE: %s IDE interface: %s\n", "Primary",
conf->ide0_enable ? "on" : "off");
(reg16 & IDE_DECODE_ENABLE) ? "on" : "off");
pci_write_config16(dev, IDE_TIM_PRI, reg16);
reg16 = pci_read_config16(dev, IDE_TIM_SEC);
@ -47,7 +47,7 @@ static void ide_init(struct device *dev)
if (!conf || conf->ide1_enable)
reg16 |= IDE_DECODE_ENABLE;
printk(BIOS_DEBUG, "IDE: %s IDE interface: %s\n", "Secondary",
conf->ide0_enable ? "on" : "off");
(reg16 & IDE_DECODE_ENABLE) ? "on" : "off");
pci_write_config16(dev, IDE_TIM_SEC, reg16);
}