GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge: Make MCHBAR arithmetics consistent 

Ensure that the operation order is always the same. This results in
changes to the binary, but the effective result is the same.

Change-Id: I9772832c60089b35889df7298e20a2bd02b35b00
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38206
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Angel Pons 2020-01-05 22:31:41 +01:00 committed by Felix Held
parent d5be4e4046
commit 1aba2a32e8
3 changed files with 393 additions and 396 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

781
src/northbridge/intel/sandybridge/raminit_common.c
View File

File diff suppressed because it is too large Load Diff

4
src/northbridge/intel/sandybridge/raminit_ivy.c
View File

@ -590,12 +590,12 @@ static void dram_ioregs(ramctr_timing * ctrl)
// IO clock
FOR_ALL_CHANNELS {
MCHBAR32(0xc00 + 0x100 * channel) = ctrl->rankmap[channel];
MCHBAR32(0xc00 + channel * 0x100) = ctrl->rankmap[channel];
}
// IO command
FOR_ALL_CHANNELS {
MCHBAR32(0x3200 + 0x100 * channel) = ctrl->rankmap[channel];
MCHBAR32(0x3200 + channel * 0x100) = ctrl->rankmap[channel];
}
// IO control

4
src/northbridge/intel/sandybridge/raminit_sandy.c
View File

@ -361,12 +361,12 @@ static void dram_ioregs(ramctr_timing * ctrl)
// IO clock
FOR_ALL_CHANNELS {
MCHBAR32(0xc00 + 0x100 * channel) = ctrl->rankmap[channel];
MCHBAR32(0xc00 + channel * 0x100) = ctrl->rankmap[channel];
}
// IO command
FOR_ALL_CHANNELS {
MCHBAR32(0x3200 + 0x100 * channel) = ctrl->rankmap[channel];
MCHBAR32(0x3200 + channel * 0x100) = ctrl->rankmap[channel];
}
// IO control