GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/qualcomm/sc7280: Remove NVMe init 

We are required to boot with eMMC enabled in the BIOS to store modem
calibration data.  Thus, it doesn't make sense to enable NVMe at boot
time since we will never boot from NVMe w/o eMMC.  We may as well take
the boot time reduction (~100ms) by eliminating NVMe initialization.

BUG=b:185426670, b:254281839
BRANCH=None
TEST=Boot after disabling NVMe and make sure that it still boots
     Note that we are able to see a little over 100ms in boot time
     savings with this change.
     Before: 40:device configuration 824,021 (102,701)
     After:  40:device configuration 717,402 (44)

Cq-Depend: chromium:3964185
Change-Id: I94f614ba0369c073617949285c0781aef5c6263f
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68562
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Shelley Chen 2022-10-18 16:32:20 -07:00
parent d164feb726
commit 1b07797a7b
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/qualcomm/sc7280/Kconfig
View File

@ -19,8 +19,6 @@ config SOC_QUALCOMM_SC7280
select HAVE_LINEAR_FRAMEBUFFER select HAVE_LINEAR_FRAMEBUFFER
select COMPRESS_BOOTBLOCK select COMPRESS_BOOTBLOCK
select HAVE_UART_SPECIAL select HAVE_UART_SPECIAL
select PCI
select NO_ECAM_MMCONF_SUPPORT
if SOC_QUALCOMM_SC7280 if SOC_QUALCOMM_SC7280

8
src/soc/qualcomm/sc7280/soc.c
View File

@ -45,11 +45,15 @@ static struct device_operations soc_ops = {
static void enable_soc_dev(struct device *dev) static void enable_soc_dev(struct device *dev)
{ {
/* Set the operations if it is a special bus type */ /* Set the operations if it is a special bus type */
if (dev->path.type == DEVICE_PATH_DOMAIN) if (dev->path.type == DEVICE_PATH_DOMAIN) {
if (CONFIG(PCI) && CONFIG(NO_ECAM_MMCONF_SUPPORT))
dev->ops = &pci_domain_ops; dev->ops = &pci_domain_ops;
else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) else
printk(BIOS_INFO, "Skip setting PCIe ops\n");
} else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
dev->ops = &soc_ops; dev->ops = &soc_ops;
} }
}
struct chip_operations soc_qualcomm_sc7280_ops = { struct chip_operations soc_qualcomm_sc7280_ops = {
CHIP_NAME("SOC Qualcomm SC7280") CHIP_NAME("SOC Qualcomm SC7280")