From 1b7b7a36978c4294b00edc96ca7cd195f3f597a5 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Fri, 16 Aug 2019 16:23:37 -0600 Subject: [PATCH] mb,autoport: Fix GCC 9 Port_List build error Port_List is an array of 8 elements, and GCC 9 is warning that there are no 'others' when all 8 elements are explicitly initialized, which is causing the build to fail. Remove the 'others => Disabled' clause to silence this. Change-Id: Id082e7a76641438f3fb4c4d976dbd254a7053473 Signed-off-by: Jacob Garber Reviewed-on: https://review.coreboot.org/c/coreboot/+/34918 Reviewed-by: HAOUAS Elyes Reviewed-by: Patrick Georgi Tested-by: build bot (Jenkins) --- src/mainboard/apple/macbookair4_2/gma-mainboard.ads | 3 +-- src/mainboard/google/butterfly/gma-mainboard.ads | 3 +-- src/mainboard/google/parrot/gma-mainboard.ads | 3 +-- src/mainboard/google/stout/gma-mainboard.ads | 3 +-- src/mainboard/hp/8460p/gma-mainboard.ads | 3 +-- src/mainboard/hp/8470p/gma-mainboard.ads | 3 +-- src/mainboard/hp/folio_9470m/gma-mainboard.ads | 3 +-- src/mainboard/hp/revolve_810_g1/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/l520/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/s230u/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/t420/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/t420s/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/t430/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/t430s/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/t520/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/t530/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/x220/gma-mainboard.ads | 3 +-- src/mainboard/lenovo/x230/gma-mainboard.ads | 3 +-- src/mainboard/packardbell/ms2290/gma-mainboard.ads | 3 +-- src/mainboard/samsung/lumpy/gma-mainboard.ads | 3 +-- util/autoport/main.go | 3 +-- 21 files changed, 21 insertions(+), 42 deletions(-) diff --git a/src/mainboard/apple/macbookair4_2/gma-mainboard.ads b/src/mainboard/apple/macbookair4_2/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/apple/macbookair4_2/gma-mainboard.ads +++ b/src/mainboard/apple/macbookair4_2/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/google/butterfly/gma-mainboard.ads b/src/mainboard/google/butterfly/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/google/butterfly/gma-mainboard.ads +++ b/src/mainboard/google/butterfly/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/google/parrot/gma-mainboard.ads b/src/mainboard/google/parrot/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/google/parrot/gma-mainboard.ads +++ b/src/mainboard/google/parrot/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/google/stout/gma-mainboard.ads b/src/mainboard/google/stout/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/google/stout/gma-mainboard.ads +++ b/src/mainboard/google/stout/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/hp/8460p/gma-mainboard.ads b/src/mainboard/hp/8460p/gma-mainboard.ads index da495f6195..01ae99aaaf 100644 --- a/src/mainboard/hp/8460p/gma-mainboard.ads +++ b/src/mainboard/hp/8460p/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/hp/8470p/gma-mainboard.ads b/src/mainboard/hp/8470p/gma-mainboard.ads index da495f6195..01ae99aaaf 100644 --- a/src/mainboard/hp/8470p/gma-mainboard.ads +++ b/src/mainboard/hp/8470p/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/hp/folio_9470m/gma-mainboard.ads b/src/mainboard/hp/folio_9470m/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/hp/folio_9470m/gma-mainboard.ads +++ b/src/mainboard/hp/folio_9470m/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads b/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads index da495f6195..01ae99aaaf 100644 --- a/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads +++ b/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/l520/gma-mainboard.ads b/src/mainboard/lenovo/l520/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/l520/gma-mainboard.ads +++ b/src/mainboard/lenovo/l520/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/s230u/gma-mainboard.ads b/src/mainboard/lenovo/s230u/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/s230u/gma-mainboard.ads +++ b/src/mainboard/lenovo/s230u/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t420/gma-mainboard.ads b/src/mainboard/lenovo/t420/gma-mainboard.ads index e9471cb352..a19bf339fd 100644 --- a/src/mainboard/lenovo/t420/gma-mainboard.ads +++ b/src/mainboard/lenovo/t420/gma-mainboard.ads @@ -27,7 +27,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t420s/gma-mainboard.ads b/src/mainboard/lenovo/t420s/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/t420s/gma-mainboard.ads +++ b/src/mainboard/lenovo/t420s/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t430/gma-mainboard.ads b/src/mainboard/lenovo/t430/gma-mainboard.ads index e9471cb352..a19bf339fd 100644 --- a/src/mainboard/lenovo/t430/gma-mainboard.ads +++ b/src/mainboard/lenovo/t430/gma-mainboard.ads @@ -27,7 +27,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t430s/gma-mainboard.ads b/src/mainboard/lenovo/t430s/gma-mainboard.ads index d635d88fb9..8cf5d2fe13 100644 --- a/src/mainboard/lenovo/t430s/gma-mainboard.ads +++ b/src/mainboard/lenovo/t430s/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t520/gma-mainboard.ads b/src/mainboard/lenovo/t520/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/t520/gma-mainboard.ads +++ b/src/mainboard/lenovo/t520/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t530/gma-mainboard.ads b/src/mainboard/lenovo/t530/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/t530/gma-mainboard.ads +++ b/src/mainboard/lenovo/t530/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x220/gma-mainboard.ads b/src/mainboard/lenovo/x220/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/x220/gma-mainboard.ads +++ b/src/mainboard/lenovo/x220/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x230/gma-mainboard.ads b/src/mainboard/lenovo/x230/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/lenovo/x230/gma-mainboard.ads +++ b/src/mainboard/lenovo/x230/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/packardbell/ms2290/gma-mainboard.ads b/src/mainboard/packardbell/ms2290/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/packardbell/ms2290/gma-mainboard.ads +++ b/src/mainboard/packardbell/ms2290/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/src/mainboard/samsung/lumpy/gma-mainboard.ads b/src/mainboard/samsung/lumpy/gma-mainboard.ads index d4a5d7d990..e45320f36e 100644 --- a/src/mainboard/samsung/lumpy/gma-mainboard.ads +++ b/src/mainboard/samsung/lumpy/gma-mainboard.ads @@ -28,7 +28,6 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; diff --git a/util/autoport/main.go b/util/autoport/main.go index ab49a14a9d..03523a2c39 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -925,8 +925,7 @@ private package GMA.Mainboard is HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal); end GMA.Mainboard; `)