GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/block/*/Kconfig: Guard options with if-blocks 

The usual structure of these files is a global enable symbol, usually
followed by an if-block which contains all other dependent symbols.

Use this instead of having a `depends on` line to each symbol. Guard all
symbols, even if they originally were not guarded, since they don't do
anything useful unless the global enable option is selected.

Change-Id: If5347187b07a46192f0063011ab197b5047f555f
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45043
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2020-09-02 19:57:34 +02:00
parent 042edd389b
commit 1b89f5eeab
3 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/intel/common/block/gpio/Kconfig
View File

@ -4,42 +4,40 @@ config SOC_INTEL_COMMON_BLOCK_GPIO
help help
Intel Processor common GPIO support Intel Processor common GPIO support
if SOC_INTEL_COMMON_BLOCK_GPIO
# Use to program Interrupt Polarity Control (IPCx) register # Use to program Interrupt Polarity Control (IPCx) register
# Each bit represents IRQx Active High Polarity Disable configuration: # Each bit represents IRQx Active High Polarity Disable configuration:
# when set to 1, the interrupt polarity associated with IRQx is inverted # when set to 1, the interrupt polarity associated with IRQx is inverted
# to appear as Active Low to IOAPIC and vice versa # to appear as Active Low to IOAPIC and vice versa
config SOC_INTEL_COMMON_BLOCK_GPIO_ITSS_POL_CFG config SOC_INTEL_COMMON_BLOCK_GPIO_ITSS_POL_CFG
depends on SOC_INTEL_COMMON_BLOCK_GPIO
bool bool
default n default n
# Used to configure Pad Tolerance as 1.8V or 3.3V # Used to configure Pad Tolerance as 1.8V or 3.3V
config SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL config SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL
depends on SOC_INTEL_COMMON_BLOCK_GPIO
bool bool
default n default n
# Used to configure IOSSTATE and IOSTERM # Used to configure IOSSTATE and IOSTERM
config SOC_INTEL_COMMON_BLOCK_GPIO_IOSTANDBY config SOC_INTEL_COMMON_BLOCK_GPIO_IOSTANDBY
depends on SOC_INTEL_COMMON_BLOCK_GPIO
bool bool
default n default n
# Used to provide support for legacy macros # Used to provide support for legacy macros
config SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS config SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS
depends on SOC_INTEL_COMMON_BLOCK_GPIO
bool bool
default n default n
# Indicate if multiple ACPI devices are used for each gpio community. # Indicate if multiple ACPI devices are used for each gpio community.
config SOC_INTEL_COMMON_BLOCK_GPIO_MULTI_ACPI_DEVICES config SOC_INTEL_COMMON_BLOCK_GPIO_MULTI_ACPI_DEVICES
depends on SOC_INTEL_COMMON_BLOCK_GPIO
bool bool
default n default n
# Indicate if SoC supports dual-routing of GPIOs (to different paths like SCI, # Indicate if SoC supports dual-routing of GPIOs (to different paths like SCI,
# NMI, SMI, IOAPIC). This is required to support IRQ and wake on the same pad. # NMI, SMI, IOAPIC). This is required to support IRQ and wake on the same pad.
config SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT config SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT
depends on SOC_INTEL_COMMON_BLOCK_GPIO
bool bool
default n default n
endif

6
src/soc/intel/common/block/sgx/Kconfig
View File

@ -6,16 +6,16 @@ config SOC_INTEL_COMMON_BLOCK_SGX
help help
Intel Processor common SGX support Intel Processor common SGX support
if SOC_INTEL_COMMON_BLOCK_SGX
config SOC_INTEL_COMMON_BLOCK_SGX_LOCK_MEMORY config SOC_INTEL_COMMON_BLOCK_SGX_LOCK_MEMORY
bool bool
depends on SOC_INTEL_COMMON_BLOCK_SGX
default n default n
help help
Lock memory before SGX activation. This is only needed if MCHECK does not do it. Lock memory before SGX activation. This is only needed if MCHECK does not do it.
config SOC_INTEL_COMMON_BLOCK_SGX_ENABLE config SOC_INTEL_COMMON_BLOCK_SGX_ENABLE
bool "Enable Software Guard Extensions (SGX) if available" bool "Enable Software Guard Extensions (SGX) if available"
depends on SOC_INTEL_COMMON_BLOCK_SGX
default n default n
help help
Intel Software Guard Extensions (SGX) is a set of new CPU instructions that can be Intel Software Guard Extensions (SGX) is a set of new CPU instructions that can be
@ -70,3 +70,5 @@ config SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED
bool "Disabled" bool "Disabled"
endchoice endchoice
endif

5
src/soc/intel/common/block/uart/Kconfig
View File

@ -4,9 +4,10 @@ config SOC_INTEL_COMMON_BLOCK_UART
help help
Intel Processor common UART support Intel Processor common UART support
if SOC_INTEL_COMMON_BLOCK_UART
config INTEL_LPSS_UART_FOR_CONSOLE config INTEL_LPSS_UART_FOR_CONSOLE
bool bool
depends on SOC_INTEL_COMMON_BLOCK_UART
select DRIVERS_UART_8250MEM_32 select DRIVERS_UART_8250MEM_32
select FIXED_UART_FOR_CONSOLE select FIXED_UART_FOR_CONSOLE
help help
@ -14,3 +15,5 @@ config INTEL_LPSS_UART_FOR_CONSOLE
for the coreboot console. for the coreboot console.
WARNING: UART_FOR_CONSOLE has to be set to a correct value, WARNING: UART_FOR_CONSOLE has to be set to a correct value,
otherwise wrong pad configurations might be selected. otherwise wrong pad configurations might be selected.
endif