GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/volteer: Remove RIPTO support for camera 

GPIO D4 was used for camera reset for both front and rear cameras
(RCAM_RST_L/FCAM_RST_L) in RIPTO. For later volteer versions,
GPIO F15 is dedicated to the rear camera reset (RCAM_RST_L).

Before, BOARD_GOOGLE_VOLTEER flag was used for setting the right
RCAM_RST_L per volteer version. However, we don't support RIPTO
anymore. Also using flags for different volteer version support can
be error-prone. Removing RIPTO support.

BUG=b:171726823
BRANCH=none
TEST=Build and boot volteer proto2 or later version. Camera should
work without an issue.

Signed-off-by: Daniel Kang <daniel.h.kang@intel.com>
Change-Id: I961fc17092887b4807c12c95f7139bb7e7b33e91
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46826
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Daniel Kang 2020-10-26 12:43:52 -07:00 committed by Tim Wawrzynczak
parent 1627e2f158
commit 1b940d17a8
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
View File

@ -157,11 +157,7 @@ Scope (\_SB.PCI0.I2C3)
MCON(3,1) /* Clock 3, 19.2MHz */
/* Pull RST low */
#if CONFIG(BOARD_GOOGLE_VOLTEER)
CTXS(GPP_F15)
#else
CTXS(GPP_D4)
#endif
/* Pull SNRPWR_EN high */
STXS(GPP_H14)
@ -176,11 +172,8 @@ Scope (\_SB.PCI0.I2C3)
REFC++
/* Pull RST high */
#if CONFIG(BOARD_GOOGLE_VOLTEER)
STXS(GPP_F15)
#else
STXS(GPP_D4)
#endif
Sleep(1) /* t2 */
STA = 1
@ -192,11 +185,7 @@ Scope (\_SB.PCI0.I2C3)
MCOF(3) /* Clock 3 */
/* Pull RST low */
#if CONFIG(BOARD_GOOGLE_VOLTEER)
CTXS(GPP_F15)
#else
CTXS(GPP_D4)
#endif
If (REFC == 1)
{