From 1ba6049ad92c9dbc0f5a388d6211ba25bf989cc0 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Wed, 2 Feb 2022 20:09:27 +0100 Subject: [PATCH] drivers/smmstore/store.c: Add static assertion based on fmap Instead of having runtime failures that are hard to debug because SMM debugging is disabled by default assert some properties of fmap at buildtime. Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/61562 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Matt DeVillier --- src/drivers/smmstore/store.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index 24e8a88edd..6ba3f53695 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -2,6 +2,7 @@ #include #include +#include #include #include #include @@ -10,6 +11,13 @@ #define SMMSTORE_REGION "SMMSTORE" + +_Static_assert(IS_ALIGNED(FMAP_SECTION_SMMSTORE_START, SMM_BLOCK_SIZE), + "SMMSTORE FMAP region not aligned to 64K"); + +_Static_assert(SMM_BLOCK_SIZE <= FMAP_SECTION_SMMSTORE_SIZE, + "SMMSTORE FMAP region must be at least 64K"); + /* * The region format is still not finalized, but so far it looks like this: * (