From 1c03da5f5af11c4ba1e8e1280be32ceb06af045a Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 14 Oct 2021 21:48:13 +0200 Subject: [PATCH] soc/amd/common: move configure_espi_with_mb_hook implementation Move the actual implementation of configure_espi_with_mb_hook out of the header file and into the espi_util.c file. Signed-off-by: Felix Held Change-Id: I1106e69a52bf329a41e8e12fd09db846310b102a Reviewed-on: https://review.coreboot.org/c/coreboot/+/58340 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/soc/amd/common/block/include/amdblocks/espi.h | 6 +----- src/soc/amd/common/block/lpc/espi_util.c | 7 +++++++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/soc/amd/common/block/include/amdblocks/espi.h b/src/soc/amd/common/block/include/amdblocks/espi.h index e12b1b8486..f9e25707d0 100644 --- a/src/soc/amd/common/block/include/amdblocks/espi.h +++ b/src/soc/amd/common/block/include/amdblocks/espi.h @@ -132,10 +132,6 @@ int espi_setup(void); void mb_set_up_early_espi(void); /* Setup eSPI with any mainboard specific initialization. */ -static inline void configure_espi_with_mb_hook(void) -{ - mb_set_up_early_espi(); - espi_setup(); -} +void configure_espi_with_mb_hook(void); #endif /* AMD_BLOCK_ESPI_H */ diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index ebc8f45979..4eb700be19 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -1053,3 +1053,10 @@ int espi_setup(void) return 0; } + +/* Setup eSPI with any mainboard specific initialization. */ +void configure_espi_with_mb_hook(void) +{ + mb_set_up_early_espi(); + espi_setup(); +}