GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/cbmem: Remove the cbmem_top_init() hook 

This hook is unused and with the need for initializing storage to
share cbmem_top over other stages gone, there is likely no future
need for this.

Change-Id: I4ba9daea61b6d7b8949bbd2c4fb71d0a0fa20d93
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36369
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Michael Niewöhner
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Arthur Heymans 2019-10-27 07:18:41 +01:00
parent 8b7cd43d5d
commit 1c54bc4849
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/include/cbmem.h
View File

@ -63,11 +63,6 @@ int cbmem_initialize_id_size(u32 id, u64 size);
void cbmem_initialize_empty(void); void cbmem_initialize_empty(void);
void cbmem_initialize_empty_id_size(u32 id, u64 size); void cbmem_initialize_empty_id_size(u32 id, u64 size);
/* Optional hook for platforms to initialize cbmem_top() value. When employed
* it's called a single time during boot at cbmem initialization/recovery
* time. */
void cbmem_top_init(void);
/* Return the top address for dynamic cbmem. The address returned needs to /* Return the top address for dynamic cbmem. The address returned needs to
* be consistent across romstage and ramstage, and it is required to be * be consistent across romstage and ramstage, and it is required to be
* below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no * below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no

6
src/lib/imd_cbmem.c
View File

@ -130,10 +130,6 @@ void cbmem_initialize_empty(void)
cbmem_initialize_empty_id_size(0, 0); cbmem_initialize_empty_id_size(0, 0);
} }
void __weak cbmem_top_init(void)
{
}
static void cbmem_top_init_once(void) static void cbmem_top_init_once(void)
{ {
/* Call one-time hook on expected cbmem init during boot. This sequence /* Call one-time hook on expected cbmem init during boot. This sequence
@ -141,8 +137,6 @@ static void cbmem_top_init_once(void)
if (!ENV_ROMSTAGE) if (!ENV_ROMSTAGE)
return; return;
cbmem_top_init();
/* The test is only effective on X86 and when address hits UC memory. */ /* The test is only effective on X86 and when address hits UC memory. */
if (ENV_X86) if (ENV_X86)
quick_ram_check_or_die((uintptr_t)cbmem_top() - sizeof(u32)); quick_ram_check_or_die((uintptr_t)cbmem_top() - sizeof(u32));