GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/edid: Zero struct only when used 

Change-Id: I1c14e7458153fb992b17f30d7015321fae533bb2
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38913
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Paul Menzel 2020-02-15 13:12:04 +01:00 committed by Patrick Georgi
parent 433bf770fc
commit 1ced4e64b0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/edid.c
View File

@ -1138,8 +1138,6 @@ int decode_edid(unsigned char *edid, int size, struct edid *out)
.conformant = EDID_CONFORMANT, .conformant = EDID_CONFORMANT,
}; };
memset(out, 0, sizeof(*out));
if (!edid) { if (!edid) {
printk(BIOS_ERR, "No EDID found\n"); printk(BIOS_ERR, "No EDID found\n");
return EDID_ABSENT; return EDID_ABSENT;
@ -1152,6 +1150,8 @@ int decode_edid(unsigned char *edid, int size, struct edid *out)
return EDID_ABSENT; return EDID_ABSENT;
} }
memset(out, 0, sizeof(*out));
if (manufacturer_name(edid + 0x08, out->manufacturer_name)) if (manufacturer_name(edid + 0x08, out->manufacturer_name))
c.manufacturer_name_well_formed = 1; c.manufacturer_name_well_formed = 1;