From 1d3c2e65724ed92eeef723c1acdc86ba91cbd682 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 8 Jun 2021 06:23:39 +0300 Subject: [PATCH] arch/x86/ioapic: Reduce API exposure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I6ff18e5ede0feda65f81c064394febd3eebc5247 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/55316 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/arch/x86/include/arch/ioapic.h | 3 --- src/arch/x86/ioapic.c | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/arch/x86/include/arch/ioapic.h b/src/arch/x86/include/arch/ioapic.h index 288f54cefc..12f9387632 100644 --- a/src/arch/x86/include/arch/ioapic.h +++ b/src/arch/x86/include/arch/ioapic.h @@ -26,9 +26,6 @@ #define SMI (2 << 8) #define INT (1 << 8) -u32 io_apic_read(void *ioapic_base, u32 reg); -void io_apic_write(void *ioapic_base, u32 reg, u32 value); -void set_ioapic_id(void *ioapic_base, u8 ioapic_id); u8 get_ioapic_id(void *ioapic_base); u8 get_ioapic_version(void *ioapic_base); diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index 1440bb4331..28bbcb14f2 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -6,13 +6,13 @@ #include #include -u32 io_apic_read(void *ioapic_base, u32 reg) +static u32 io_apic_read(void *ioapic_base, u32 reg) { write32(ioapic_base, reg); return read32(ioapic_base + 0x10); } -void io_apic_write(void *ioapic_base, u32 reg, u32 value) +static void io_apic_write(void *ioapic_base, u32 reg, u32 value) { write32(ioapic_base, reg); write32(ioapic_base + 0x10, value); @@ -108,7 +108,7 @@ static void route_i8259_irq0(void *ioapic_base) } } -void set_ioapic_id(void *ioapic_base, u8 ioapic_id) +static void set_ioapic_id(void *ioapic_base, u8 ioapic_id) { int i;