GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/drivers/ipmi: Add DEBUG_IPMI option 

IPMI debug was extra spewy, so add a debug option as SPI and
other drivers have when they need to be debugged.

Original-Signed-off-by: Marc Jones <marcjones@sysproconsulting.com>
Original-Reviewed-on: https://review.coreboot.org/c/coreboot/+/52449
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: Angel Pons <th3fanbus@gmail.com>
(cherry picked from commit dc12daf277)

Change-Id: If586b5feea74de0e6ed677af18e61dedf1216939
Signed-off-by: Marc Jones <marcjones@sysproconsulting.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54878
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Marc Jones 2021-04-16 14:26:08 -06:00 committed by Werner Zeh
parent 3ec21b07fb
commit 1d3fbda9ee
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Kconfig
View File

@ -1031,6 +1031,13 @@ config DEBUG_SPI_FLASH
help help
This option enables additional SPI flash related debug messages. This option enables additional SPI flash related debug messages.
config DEBUG_IPMI
bool "Output verbose IPMI debug messages"
default n
depends on IPMI_KCS
help
This option enables additional IPMI related debug messages.
if SOUTHBRIDGE_INTEL_BD82X6X && DEFAULT_CONSOLE_LOGLEVEL_8 if SOUTHBRIDGE_INTEL_BD82X6X && DEFAULT_CONSOLE_LOGLEVEL_8
# Only visible with the right southbridge and loglevel. # Only visible with the right southbridge and loglevel.
config DEBUG_INTEL_ME config DEBUG_INTEL_ME

12
src/drivers/ipmi/ipmi_kcs.c
View File

@ -41,7 +41,8 @@
static unsigned char ipmi_kcs_status(int port) static unsigned char ipmi_kcs_status(int port)
{ {
unsigned char status = inb(IPMI_STAT(port)); unsigned char status = inb(IPMI_STAT(port));
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, status); if (CONFIG(DEBUG_IPMI))
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, status);
return status; return status;
} }
@ -75,7 +76,8 @@ static int ipmi_kcs_send_data_byte(int port, const unsigned char byte)
{ {
unsigned char status; unsigned char status;
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, byte); if (CONFIG(DEBUG_IPMI))
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, byte);
outb(byte, IPMI_DATA(port)); outb(byte, IPMI_DATA(port));
@ -98,7 +100,8 @@ static int ipmi_kcs_send_last_data_byte(int port, const unsigned char byte)
{ {
unsigned char status; unsigned char status;
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, byte); if (CONFIG(DEBUG_IPMI))
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, byte);
if (wait_ibf_timeout(port)) if (wait_ibf_timeout(port))
return 1; return 1;
@ -119,7 +122,8 @@ static int ipmi_kcs_send_last_data_byte(int port, const unsigned char byte)
static int ipmi_kcs_send_cmd_byte(int port, const unsigned char byte) static int ipmi_kcs_send_cmd_byte(int port, const unsigned char byte)
{ {
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, byte); if (CONFIG(DEBUG_IPMI))
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, byte);
if (wait_ibf_timeout(port)) if (wait_ibf_timeout(port))
return 1; return 1;