From 1d9199c60eae91cc09e9849f559da485e0490a94 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 7 Jul 2018 00:27:44 +0200 Subject: [PATCH] ec/quanta: pass ops to pnp_enable_devices instead of LDN-specific override Since ops was passed as override in the pnp_dev_info struct, the generic pnp_ops that was passed to pnp_enable_devices was never used. Change-Id: I59eb60efeefcdbe8b2dc08e17453cf95bdfd39b1 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/27395 Reviewed-by: Alexander Couzens Tested-by: build bot (Jenkins) --- src/ec/quanta/ene_kb3940q/ec.c | 5 ++--- src/ec/quanta/it8518/ec.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c index b25a51ba01..11a1cb8e7d 100644 --- a/src/ec/quanta/ene_kb3940q/ec.c +++ b/src/ec/quanta/ene_kb3940q/ec.c @@ -154,13 +154,12 @@ static struct device_operations ops = { }; static struct pnp_info pnp_dev_info[] = { - { &ops, 0, 0, 0, } + { NULL, 0, 0, 0, } }; static void enable_dev(struct device *dev) { - pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), - pnp_dev_info); + pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } struct chip_operations ec_quanta_ene_kb3940q_ops = { diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c index 3a5173317d..e293f7cb6a 100644 --- a/src/ec/quanta/it8518/ec.c +++ b/src/ec/quanta/it8518/ec.c @@ -167,13 +167,12 @@ static struct device_operations ops = { }; static struct pnp_info pnp_dev_info[] = { - { &ops, 0, 0, 0, } + { NULL, 0, 0, 0, } }; static void enable_dev(struct device *dev) { - pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), - pnp_dev_info); + pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } struct chip_operations ec_quanta_it8518_ops = {