GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "soc/intel/cannonlake: Add missing min sleep state for thermal device" 

This reverts commit d64b66ba267a217d0b6716309019c36c8cfdf8c2:
"soc/intel/cannonlake: Add missing min sleep state for thermal device."

Reverting because commit e00523aae2 ("soc/intel/cannonlake: Drop
entries from soc_acpi_name()") removed the ACPI device name for the PCH
thermal device, since there is no ACPI device defined for it. Removing
the name without removing the minimum sleep state caused an invalid LPI
entry to be created, which caused a Windows BSOD: INTERNAL_POWER_ERROR.

TEST=build/boot Win11 on google/puff (wyvern).

Change-Id: I2dfe76d5f72cde7742cee338fa24eaafb84c4604
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80057
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
Matt DeVillier 2024-01-16 17:27:16 -06:00 committed by Felix Singer
parent c4e5e91cbd
commit 1dbe82b5fe
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/intel/cannonlake/acpi.c
View File

@ -170,7 +170,6 @@ static struct min_sleep_state min_pci_sleep_states[] = {
{ SA_DEVFN_TS, ACPI_DEVICE_SLEEP_D3 },
{ SA_DEVFN_IPU, ACPI_DEVICE_SLEEP_D3 },
{ SA_DEVFN_GNA, ACPI_DEVICE_SLEEP_D3 },
{ PCH_DEVFN_THERMAL, ACPI_DEVICE_SLEEP_D3 },
{ PCH_DEVFN_UFS, ACPI_DEVICE_SLEEP_D3 },
{ PCH_DEVFN_GSPI2, ACPI_DEVICE_SLEEP_D3 },
{ PCH_DEVFN_ISH, ACPI_DEVICE_SLEEP_D3 },