GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing 

Checking whether a pointer is NULL after it has been dereferenced makes
zero sense. Make sure the `wifi_ssdt_write_properties()` function never
gets invoked with a NULL argument for the `dev` parameter, and simplify
the logic around the `is_cnvi_ddr_rfim_enabled` variable accordingly.

Change-Id: I3fbc9565e7e9b4e1c14a68f6a5fd779577045236
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63340
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Angel Pons 2022-04-03 21:10:26 +02:00 committed by Felix Held
parent 32ec4526a0
commit 1e124b94fc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/wifi/generic/acpi.c
View File

@ -533,11 +533,9 @@ static void wifi_ssdt_write_device(const struct device *dev, const char *path)
static void wifi_ssdt_write_properties(const struct device *dev, const char *scope)
{
bool is_cnvi_ddr_rfim_enabled = false;
const struct drivers_wifi_generic_config *config = dev->chip_info;
if (dev && config)
is_cnvi_ddr_rfim_enabled = config->enable_cnvi_ddr_rfim;
bool is_cnvi_ddr_rfim_enabled = config && config->enable_cnvi_ddr_rfim;
/* Scope */
acpigen_write_scope(scope);
@ -646,6 +644,8 @@ const char *wifi_pcie_acpi_name(const struct device *dev)
void wifi_cnvi_fill_ssdt(const struct device *dev)
{
const char *path;
if (!dev)
return;
path = acpi_device_path(dev->bus->dev);
if (!path)