GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Kconfig: Hide BOARD_ID_MANUAL. 

board_id() returns an integer which is platform-specific. 0 for one port
is different from 0 for another port. So there is no default board_id()
and hence enabling it on boards other than urara would cause build failure.
Not enabling it on urara or just setting id to "(none)" as is default results
in board_id() = 0 which means urara and an error message on console.

Change-Id: I94618f36a75e7505984bbec345a31fe0fa9cc867
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/10379
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Vladimir Serbinenko 2015-05-30 22:47:22 +02:00
parent d73745178b
commit 1e16142997
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Kconfig
View File

@ -302,7 +302,7 @@ config BOARD_ID_AUTO
(ie. GPIO) select this configuration option. (ie. GPIO) select this configuration option.
config BOARD_ID_MANUAL config BOARD_ID_MANUAL
bool "Add board ID file to CBFS" bool
default n default n
depends on !BOARD_ID_AUTO depends on !BOARD_ID_AUTO
help help

1
src/mainboard/google/urara/Kconfig
View File

@ -29,6 +29,7 @@ config BOARD_SPECIFIC_OPTIONS
select CPU_IMGTEC_PISTACHIO select CPU_IMGTEC_PISTACHIO
select COMMON_CBFS_SPI_WRAPPER select COMMON_CBFS_SPI_WRAPPER
select SPI_FLASH select SPI_FLASH
select BOARD_ID_MANUAL
config MAINBOARD_DIR config MAINBOARD_DIR
string string