GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/nvidia/mcp55: Fix P_state generation 

amd_generate_powernow is never called by in lpc_slave_ops.
Move it to lpc_ops like on all other AMD southbridges.

TESTED on Gigabyte ga-m57sli-s4

Change-Id: I7db036e681d591a19e15dd3eaafb88b72a41bea1
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/17977
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Arthur Heymans 2016-12-28 12:35:06 +01:00 committed by Martin Roth
parent c258bc1ac6
commit 1eef32d92b
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/southbridge/nvidia/mcp55/lpc.c
View File

@ -240,10 +240,21 @@ static void mcp55_lpc_enable_resources(device_t dev)
mcp55_lpc_enable_childrens_resources(dev); mcp55_lpc_enable_childrens_resources(dev);
} }
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
static void southbridge_acpi_fill_ssdt_generator(device_t device)
{
amd_generate_powernow(0, 0, 0);
}
#endif
static struct device_operations lpc_ops = { static struct device_operations lpc_ops = {
.read_resources = mcp55_lpc_read_resources, .read_resources = mcp55_lpc_read_resources,
.set_resources = pci_dev_set_resources, .set_resources = pci_dev_set_resources,
.enable_resources = mcp55_lpc_enable_resources, .enable_resources = mcp55_lpc_enable_resources,
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
.acpi_fill_ssdt_generator = southbridge_acpi_fill_ssdt_generator,
.write_acpi_tables = acpi_write_hpet,
#endif
.init = lpc_init, .init = lpc_init,
.scan_bus = scan_lpc_bus, .scan_bus = scan_lpc_bus,
.ops_pci = &mcp55_pci_ops, .ops_pci = &mcp55_pci_ops,
@ -264,21 +275,11 @@ static const struct pci_driver lpc_driver __pci_driver = {
.devices = lpc_ids, .devices = lpc_ids,
}; };
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
static void southbridge_acpi_fill_ssdt_generator(device_t device)
{
amd_generate_powernow(0, 0, 0);
}
#endif
static struct device_operations lpc_slave_ops = { static struct device_operations lpc_slave_ops = {
.read_resources = mcp55_lpc_read_resources, .read_resources = mcp55_lpc_read_resources,
.set_resources = pci_dev_set_resources, .set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources, .enable_resources = pci_dev_enable_resources,
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES) #if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
.acpi_fill_ssdt_generator = southbridge_acpi_fill_ssdt_generator,
.write_acpi_tables = acpi_write_hpet, .write_acpi_tables = acpi_write_hpet,
#endif #endif
.init = lpc_slave_init, .init = lpc_slave_init,