GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload/keyboard: Reset to scancode set #2 on exit 

If we select scancode set #1 and keep that, it can confuse Linux
with keyboards that don't return to set #2 when asked to load the
defaults. This happens for instance with various integrated Think-
Pad keyboards but was also seen with an external PS/2 one.

The chosen configuration, scancode set #2 without translation, seems
to be the default for many systems. So we can expect other payloads
and kernels to work with it.

Change-Id: I28d74590e9f04d32bb2bbd461b67f15014f927ec
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47594
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2020-11-14 13:43:21 +01:00 committed by Patrick Georgi
parent 4dc92782fc
commit 1f2b5fb201
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
payloads/libpayload/drivers/i8042/keyboard.c
View File

@ -655,6 +655,11 @@ void keyboard_disconnect(void)
keyboard_cmd(I8042_KBCMD_DEFAULT_DIS); keyboard_cmd(I8042_KBCMD_DEFAULT_DIS);
keyboard_drain_input(); keyboard_drain_input();
/* Nobody but us seems to still use scancode set #1.
So try to hand over with more modern settings. */
set_scancode_set(2);
i8042_set_kbd_translation(false);
/* Send keyboard disconnect command */ /* Send keyboard disconnect command */
i8042_cmd(I8042_CMD_DIS_KB); i8042_cmd(I8042_CMD_DIS_KB);