GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arm(64): Change write32() argument order to match x86 

This patch changes the argument order for the (now temporarily unused)
write32() accessor macro (and equivalents for other lengths) from
(value, address) to (address, value) in order to conform with the
equivalent on x86. Also removes one remaining use of write32() on ARM
that slipped through since coccinelle doesn't inspect header files.

BRANCH=none
BUG=chromium:444723
TEST=Compiled Cosmos, Daisy, Blaze, Pit, Ryu, Storm and Pinky.

Change-Id: Id5739b144f6a5cfd40958ea68510dcf0b89fbfa9
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: f02cae8b04f2042530bafc91346d11bb666aa42d
Original-Change-Id: Ia91c2c19d8444e853a2fc12590a52c2b6447a1b9
Original-Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/254863
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/9835
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Julius Werner 2015-02-19 14:43:59 -08:00 committed by Patrick Georgi
parent d21a329866
commit 1f60f971fc
6 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/arch/arm/include/arch/io.h
View File

@ -32,11 +32,11 @@
* re-factor all code to specify the data length intended. * re-factor all code to specify the data length intended.
*/ */
#define readb(a) read8(a) #define readb(a) read8(a)
#define writeb(v,a) write8(v,a) #define writeb(v,a) write8(a,v)
#define readw(a) read16(a) #define readw(a) read16(a)
#define writew(v,a) write16(v,a) #define writew(v,a) write16(a,v)
#define readl(a) read32(a) #define readl(a) read32(a)
#define writel(v,a) write32(v,a) #define writel(v,a) write32(a,v)
/* /*
* Clear and set bits in one shot. These macros can be used to clear and * Clear and set bits in one shot. These macros can be used to clear and

6
src/arch/arm/include/armv4/arch/arch_io.h
View File

@ -40,17 +40,17 @@ static inline uint32_t read32(const void *addr)
return *(volatile uint32_t *)addr; return *(volatile uint32_t *)addr;
} }
static inline void write8(uint8_t val, void *addr) static inline void write8(void *addr, uint8_t val)
{ {
*(volatile uint8_t *)addr = val; *(volatile uint8_t *)addr = val;
} }
static inline void write16(uint16_t val, void *addr) static inline void write16(void *addr, uint16_t val)
{ {
*(volatile uint16_t *)addr = val; *(volatile uint16_t *)addr = val;
} }
static inline void write32(uint32_t val, void *addr) static inline void write32(void *addr, uint32_t val)
{ {
*(volatile uint32_t *)addr = val; *(volatile uint32_t *)addr = val;
} }

6
src/arch/arm/include/armv7/arch/arch_io.h
View File

@ -44,21 +44,21 @@ static inline uint32_t read32(const void *addr)
return *(volatile uint32_t *)addr; return *(volatile uint32_t *)addr;
} }
static inline void write8(uint8_t val, void *addr) static inline void write8(void *addr, uint8_t val)
{ {
dmb(); dmb();
*(volatile uint8_t *)addr = val; *(volatile uint8_t *)addr = val;
dmb(); dmb();
} }
static inline void write16(uint16_t val, void *addr) static inline void write16(void *addr, uint16_t val)
{ {
dmb(); dmb();
*(volatile uint16_t *)addr = val; *(volatile uint16_t *)addr = val;
dmb(); dmb();
} }
static inline void write32(uint32_t val, void *addr) static inline void write32(void *addr, uint32_t val)
{ {
dmb(); dmb();
*(volatile uint32_t *)addr = val; *(volatile uint32_t *)addr = val;

4
src/arch/arm64/include/arch/io.h
View File

@ -32,9 +32,9 @@
* re-factor all code to specify the data length intended. * re-factor all code to specify the data length intended.
*/ */
#define readb(a) read8(a) #define readb(a) read8(a)
#define writeb(v,a) write8(v,a) #define writeb(v,a) write8(a,v)
#define readl(a) read32(a) #define readl(a) read32(a)
#define writel(v,a) write32(v,a) #define writel(v,a) write32(a,v)
/* /*
* Clear and set bits in one shot. These macros can be used to clear and * Clear and set bits in one shot. These macros can be used to clear and

6
src/arch/arm64/include/armv8/arch/arch_io.h
View File

@ -45,21 +45,21 @@ static inline uint32_t read32(const void *addr)
return *(volatile uint32_t *)addr; return *(volatile uint32_t *)addr;
} }
static inline void write8(uint8_t val, void *addr) static inline void write8(void *addr, uint8_t val)
{ {
dmb(); dmb();
*(volatile uint8_t *)addr = val; *(volatile uint8_t *)addr = val;
dmb(); dmb();
} }
static inline void write16(uint16_t val, void *addr) static inline void write16(void *addr, uint16_t val)
{ {
dmb(); dmb();
*(volatile uint16_t *)addr = val; *(volatile uint16_t *)addr = val;
dmb(); dmb();
} }
static inline void write32(uint32_t val, void *addr) static inline void write32(void *addr, uint32_t val)
{ {
dmb(); dmb();
*(volatile uint32_t *)addr = val; *(volatile uint32_t *)addr = val;

4
src/soc/qualcomm/ipq806x/include/soc/iomap.h
View File

@ -44,8 +44,8 @@
macros for read/write. Hence, special macros for readl_i and writel_i are macros for read/write. Hence, special macros for readl_i and writel_i are
included to do this in one place for all occurrences in vendor code included to do this in one place for all occurrences in vendor code
*/ */
#define readl_i(a) read32((const void *)(a)) #define readl_i(a) readl((const void *)(a))
#define writel_i(v,a) write32(v,(void *)a) #define writel_i(v,a) writel(v,(void *)a)
#define clrsetbits_le32_i(addr, clear, set) \ #define clrsetbits_le32_i(addr, clear, set) \
clrsetbits_le32(((void *)(addr)), (clear), (set)) clrsetbits_le32(((void *)(addr)), (clear), (set))